From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CAF1C433EF for ; Tue, 28 Sep 2021 14:34:46 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB74161209 for ; Tue, 28 Sep 2021 14:34:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB74161209 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.198032.351327 (Exim 4.92) (envelope-from ) id 1mVEBe-0003n6-Tr; Tue, 28 Sep 2021 14:34:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 198032.351327; Tue, 28 Sep 2021 14:34:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVEBe-0003mz-Qb; Tue, 28 Sep 2021 14:34:26 +0000 Received: by outflank-mailman (input) for mailman id 198032; Tue, 28 Sep 2021 14:34:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mVEBc-0003mt-T6 for xen-devel@lists.xenproject.org; Tue, 28 Sep 2021 14:34:25 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2c224ebe-2069-11ec-bc9b-12813bfff9fa; Tue, 28 Sep 2021 14:34:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c224ebe-2069-11ec-bc9b-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1632839663; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=f/M1jQ2L65vBY+5NOTnXuTSK69Cn7Gv109tQtoDyCZQ=; b=e+6osednOVPo8jlFrpPzUjR3fQqNh+7PMG5tfNRGVj2hpniQ3PcHOCMD 97sJy1Fko0r4gnA1R8kAFhPWcsjpaGBvyOl/jdDID67iE9X4GTI9zw0w6 BfyolqR1BDOc+gQMBVWmsXsVwpX9VhKWiEnuRpkMpzFKh3HOX3i8WdH1H s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: XHx0p4GWcpWl7gaTST2+Tdfmmeveplcbwb0/+o1oFrOlW7eY9ICW7FW6/NbSqGU67QBFwgtt1s Bc9x71w8tSWoUxnm+d/DiKItlUkqLa+3bDefJl+7iqpdqhKiA6kPFeKJ9nJ2utWG/BuXvGHKE6 g6z8FVfwkWjrteaEBeumYeRcBJsTKN4iafMp06l2n3UvFDLsLIxrKt3Q+b1lVy/VGpLSRsdO/g agbUfBIQodtNprQfHbutS4/vCVYQYT1Fcf442McHMMv5ktZUMTgx6tQKSMbloJZnxiF800uwQK 2KyqUcOSRc/VAa6e47rLX3NO X-SBRS: 5.1 X-MesageID: 55646089 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:kTn6O6xJGVr7CMI7vdp6t+e1wSrEfRIJ4+MujC+fZmUNrF6WrkUFx 2ZKC2uAbKyOYmf2Lt4jaNi09h9U6JLTzYRgSAI4qSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s7yrRp2tQAbeWRWGthh /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt+5V7 tpQrcKpdSIoP4aSxucHSkRcLAgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY250QQaiGN 5txhTxHdCTSfR9qYVQuBdEyt+X4pXDSUHpWpwfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep 0rF8n7/DxVcM8aQoRKa9lq8i+mJmjn0MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM UN80igkoLU29UerZsLgRBD+q3mB1jYdRNh4A+A88BuKyKff/0CeHGdsZjxcbN0rsucmSDps0 UWG9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewc6aS0K/sG9ub0WjxPkEIhgCrfoiuLcTGSYL y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2NADv6v1oRiJqNItzwsAeHvZ6sOa7DFjG8U G44d99yBQzkJb+KjjDFZOwQELyz6/+BPVUwanY0RMJ5plxBF5O5FL28AQ2Sxm81bq7omhezO Sc/XD+9ArcIZxNGioctP+qM5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/plZ snLK5/2US9BYUiC8NZQb7xGuVPM7npirV4/uLihl0j3uVZgTCT9pUg53KumMblisfLsTPT9+ NdDLcqaoyizo8WkChQ7BbU7dAhQRVBiXMieg5UOKoarf1o3cEl8WqS56e5wJORYc1F9y76gE oeVARQDljISRBTvdG23V5yUQOm0AMkj/S5lZ3xE0JTB8yFLXLtDJZw3L/MfFYTLPsQzpRKtZ /VaKciGHNpVTTHLp2YUYZXn9dQwfxW3nwOeeSGiZWFnLZJnQgXI/P7ifxfuq3ZSXnbm65Nmr u3yzB7fTLoCWx9mUJTcZsWwwg7jpnMagu9zARfFe4EBZEX2/YF2ACXtlftrcdoUIBDOy2LCh QabCBsVv8fXpIox/IWbjKyItd7xQeB/AlBbDy/Q6rPvbXvW+W+qwIlhVueUfG+CCDOoqfv6P egMlqPyKvwKmlpOorFQKbczwPJs/cbrqp9b0h9gQCfBYWO0B+4yOXKBx8RO6PFAn+cLpQusV 0uT0dBGIrHVatj9GVscKQd5POSO0fYYxmvb4fgveRio4SZ2+PyMUFlIPgnKgytYdeMnPIQgy OYnmcgX9w3g1UZ6bofY1nhZpzaWM3gNc6Q7rZVLUobkhz0ixkxGfZGBWDT954uCaokUP0QnS tNOaHEuW1iIKpL+TkcO IronPort-HdrOrdr: A9a23:Ix1i1q4JSmKmWkK5QgPXwMjXdLJyesId70hD6qhwISY6TiW9rb HLoB17726QtN9/YhwdcLy7VJVoBEmskqKdgrNhX4tKPjOHhILAFugLhuHfKn/bak7DH4ZmpM FdmsNFaeEYY2IUsfrH X-IronPort-AV: E=Sophos;i="5.85,329,1624334400"; d="scan'208";a="55646089" Date: Tue, 28 Sep 2021 15:33:57 +0100 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Subject: Re: [XEN PATCH v4] xen: rework `checkpolicy` detection when using "randconfig" Message-ID: References: <20210928083944.780398-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Tue, Sep 28, 2021 at 03:46:01PM +0200, Jan Beulich wrote: > On 28.09.2021 10:39, Anthony PERARD wrote: > > This will help prevent the CI loop from having build failures when > > `checkpolicy` isn't available when doing "randconfig" jobs. > > > > To prevent "randconfig" from selecting XSM_FLASK_POLICY when > > `checkpolicy` isn't available, we will actually override the config > > output with the use of KCONFIG_ALLCONFIG. > > > > Doing this way still allow a user/developer to set XSM_FLASK_POLICY > > even when "checkpolicy" isn't available. It also prevent the build > > system from reset the config when "checkpolicy" isn't available > > anymore. And XSM_FLASK_POLICY is still selected automatically when > > `checkpolicy` is available. > > But this also work well for "randconfig", as it will not select > > XSM_FLASK_POLICY when "checkpolicy" is missing. > > > > This patch allows to easily add more override which depends on the > > environment. > > > > Also, move the check out of Config.mk and into xen/ build system. > > Nothing in tools/ is using that information as it's done by > > ./configure. > > > > We named the new file ".allconfig.tmp" as ".*.tmp" are already ignored > > via .gitignore. > > > > Remove '= y' in Kconfig as it isn't needed, only a value "y" is true, > > anything else is considered false. > > Seeing you say this explicitly makes me wonder - is this actually true? I've check that this was true by empirical testing before sending the patch. But the documentation isn't clear to me about the meaning of 'default y if "m"'. So would you rather keep '= y' just to stay on the safe side? > At least when modules are enabled (which our kconfig is capable of even > if we don't use that part of it), "m" is also "kind of" true, and the > related logic really isn't quite boolean iirc. > > Everything else looks goot to me now, thanks. Thanks, -- Anthony PERARD