Re: [yocto] [meta-security][PATCH 2/2] swtpm: fix build issues of missing expect

[Kristian Klausen <kristian@klausen.dk>]

Den Tue, Sep 28, 2021 at 16:39:09 -0700 skrev Armin Kuster:
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb b/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
> index 807c02b..d602ee0 100644
> --- a/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
> +++ b/meta-tpm/recipes-tpm/swtpm/swtpm_0.6.1.bb
> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=fe8092c832b71ef20dfe4c6d3decb3a8"
>  SECTION = "apps"
>  
>  # coreutils-native and net-tools-native are reportedly only required for the tests
> -DEPENDS = "libtasn1 coreutils-native expect socat glib-2.0 net-tools-native libtpm json-glib"
> +DEPENDS = "libtasn1 coreutils-native expect socat glib-2.0 net-tools-native libtpm json-glib expect expect-native"

expect is there twice now (+ native). Would expect-native be enough or 
do we also need expect?

>  
>  SRCREV = "98187d24fe14851653a7c46eb16e9c5f0b9beaa1"
>  SRC_URI = "git://github.com/stefanberger/swtpm.git;branch=stable-0.6 \
> @@ -28,7 +28,7 @@ PACKAGECONFIG[openssl] = "--with-openssl, --without-openssl, openssl"
>  # expect, bash, tpm2-pkcs11-tools (tpm2_ptool), tpmtool and certtool is
>  # used by swtpm-create-tpmca (the last two is provided by gnutls)
>  # gnutls is required by: swtpm-create-tpmca, swtpm-localca and swtpm_cert
> -PACKAGECONFIG[gnutls] = "--with-gnutls, --without-gnutls, gnutls, gnutls, expect bash tpm2-pkcs11-tools"
> +PACKAGECONFIG[gnutls] = "--with-gnutls, --without-gnutls, gnutls, gnutls, bash tpm2-pkcs11-tools"

expect is needed as a runtime dependency for swtpm-create-tpmca, but I 
added it as a recommended dependency as I don't think all people are 
interesting in swtpm-create-tpmca working out-of-the-box.
expect should still be here, no?

>  PACKAGECONFIG[selinux] = "--with-selinux, --without-selinux, libselinux"
>  PACKAGECONFIG[cuse] = "--with-cuse, --without-cuse, fuse"
>  PACKAGECONFIG[seccomp] = "--with-seccomp, --without-seccomp, libseccomp"
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#54899): https://lists.yoctoproject.org/g/yocto/message/54899
> Mute This Topic: https://lists.yoctoproject.org/mt/85937662/6376886
> Group Owner: yocto+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [kristian@klausen.dk]
> -=-=-=-=-=-=-=-=-=-=-=-
>