From: Patrick Williams <patrick@stwcx.xyz>
To: Kumar Thangavel <thangavel.k@hcl.com>
Cc: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
Vernon Mauery <vernon.mauery@linux.intel.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
Ed Tanous <ed@tanous.net>, Amithash Prasad <amithash@fb.com>,
"Velumani T-ERS, HCLTech" <velumanit@hcl.com>
Subject: Re: EEPROM Validation issue in Fru Device.
Date: Wed, 29 Sep 2021 06:48:40 -0500 [thread overview]
Message-ID: <YVRSmInJszjpBTsY@heinlein> (raw)
In-Reply-To: <PS2PR04MB3589C40CCE3B07C5A2B79A3AFDA99@PS2PR04MB3589.apcprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
On Wed, Sep 29, 2021 at 05:53:33AM +0000, Kumar Thangavel wrote:
>
> 1. How the function isDevice16Bit Validated for 16 bit device ?
My understanding is that Vijay wrote this originally when he wrote the Tiogapass
port. You should be able to confirm if it works there.
>
> 2. Is my validation and analysis is correct ?
Other people have complained (on Discord) that this current code doesn't work
for all eeproms. If you have something that works better and doesn't break
Tiogapass support, I would expect it to be accepted as a change in fru-device.
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-09-29 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 5:49 EEPROM Validation issue in Fru Device Kumar Thangavel
2021-09-29 5:53 ` Kumar Thangavel
2021-09-29 11:48 ` Patrick Williams [this message]
2021-09-29 13:29 ` Kumar Thangavel
2021-09-30 1:50 ` [External] " Lei Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVRSmInJszjpBTsY@heinlein \
--to=patrick@stwcx.xyz \
--cc=amithash@fb.com \
--cc=ed@tanous.net \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=thangavel.k@hcl.com \
--cc=velumanit@hcl.com \
--cc=vernon.mauery@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.