From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D608C433F5 for ; Wed, 29 Sep 2021 12:42:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AC0A3613D3 for ; Wed, 29 Sep 2021 12:42:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC0A3613D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3F2DB940023; Wed, 29 Sep 2021 08:42:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A0FC940020; Wed, 29 Sep 2021 08:42:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2908F940023; Wed, 29 Sep 2021 08:42:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 1A72D940020 for ; Wed, 29 Sep 2021 08:42:48 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B55951837B4A7 for ; Wed, 29 Sep 2021 12:42:47 +0000 (UTC) X-FDA: 78640575174.18.11279A7 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by imf04.hostedemail.com (Postfix) with ESMTP id 719BE50000B9 for ; Wed, 29 Sep 2021 12:42:47 +0000 (UTC) Received: by mail-wr1-f53.google.com with SMTP id u18so4040864wrg.5 for ; Wed, 29 Sep 2021 05:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7Crw1tVUQAw1+Hp0YgsE0e4Jsu9zg954QmWXXzjua34=; b=SQW7/3a7ALvaqjEQo1zWCZgGG0BdC/tgonB8N4L3LBcRN7T4Zot/kQnCA7aiWV/Luf QJab4aMFF90JbX0CPi47HylK6sTw85pNSyLmk3NyrtKlPsrWp5CSnPiIhOp5CaIrkxpv 6SQa5gLP+mJ2IICiT+nnsGVQnKmsrNEDDPTEie/0HZBdoQ890oWUzo5g6SiG5EJi9Vsc LRanAAdQLgotIrbntPEIZINwBcJrfg1OzBdnSNzzY2JzlLy3RHBrso3637uiEu1nMsxJ 6lNRyM4/3vbdZVaSE94Z4ozmHAldI9rOl1jsiR6baiJNMqhgFctomaRdDsymCtpQW0O7 1XbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7Crw1tVUQAw1+Hp0YgsE0e4Jsu9zg954QmWXXzjua34=; b=N4LsczECWhQF4N2TiwONHM0EeFlioowZ66VBN3oM9jK99giniSrkuHHklhHBpjy1M3 xZWeuIIQumnkia+Sw5MQmz3rW2dbeWl9M6QIgQNYfaFc5XfpWCRIj2ei373fiAwFTwca 6FP8qKrHwk7Rxlw0BMOOmaSj2eXF9O6tFIemoBAz9qMF7SNq+AMflqlqyhR9nWdVBf4+ fdwVotG1OhFgehwuaVK5tZdWIRGzAUNafQvtGbzUXrclBKmENVfxFuBcYoi/BDk/2EA3 s85lDSnBwhV9QFOpwWOGd+H6lizg+iV9yI+OiOWvYQhj4SSjUZlYkvfyKq12gMPR3tCJ uI4Q== X-Gm-Message-State: AOAM533ReLhWUF4CocHxwmsrTy4wPPl2gt6cLqQIsqAitBATsCTLPpAY ReVbRPBiAw0RCScu8BZItNi2BQ== X-Google-Smtp-Source: ABdhPJwJFxmuGl8iGLUBnBvMQxMOg/Y+fm/YDjAeU844WjwC8NudzFvZ3g1wIqFptSgVkmBNAl1bxg== X-Received: by 2002:a5d:4cc6:: with SMTP id c6mr6595976wrt.108.1632919366025; Wed, 29 Sep 2021 05:42:46 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:c9be:b970:304:6a4d]) by smtp.gmail.com with ESMTPSA id c8sm2257328wru.30.2021.09.29.05.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Sep 2021 05:42:45 -0700 (PDT) Date: Wed, 29 Sep 2021 14:42:40 +0200 From: Marco Elver To: yanjun.zhu@linux.dev Cc: ryabinin.a.a@gmail.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: Re: [PATCH 1/1] mm/kasan: avoid export __kasan_kmalloc Message-ID: References: <20210929234929.857611-1-yanjun.zhu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929234929.857611-1-yanjun.zhu@linux.dev> User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 719BE50000B9 X-Stat-Signature: wscew468s7hkdzewyb8hfenr3uxg3udt Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="SQW7/3a7"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of elver@google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=elver@google.com X-HE-Tag: 1632919367-600781 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001698, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 29, 2021 at 07:49PM -0400, yanjun.zhu@linux.dev wrote: > From: Zhu Yanjun > > Since the function __kasan_kmalloc is only used in kasan module, > remove EXPORT_SYMBOL to this function. This is incorrect, see below. > @@ -521,7 +521,6 @@ void * __must_check __kasan_kmalloc(struct kmem_cache *cache, const void *object > { > return ____kasan_kmalloc(cache, object, size, flags); > } > -EXPORT_SYMBOL(__kasan_kmalloc); Sorry, but this will break all users of kmalloc() with KASAN on if !TRACING: __always_inline kmalloc() include/linux/slab.h -> __always_inline kmem_cache_alloc_trace() include/linux/slab.h -> __always_inline kasan_kmalloc() include/linux/kasan.h -> __kasan_kmalloc() mm/kasan/common.c