From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Wed, 29 Sep 2021 17:43:34 +0100 From: Catalin Marinas Subject: Re: [PATCH v17 15/15] arm64: trans_pgd: remove trans_pgd_map_page() Message-ID: References: <20210916231325.125533-1-pasha.tatashin@soleen.com> <20210916231325.125533-16-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210916231325.125533-16-pasha.tatashin@soleen.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Pasha Tatashin Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, will@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, james.morse@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, linux-mm@kvack.org, mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com, tglx@linutronix.de, selindag@gmail.com, tyhicks@linux.microsoft.com, kernelfans@gmail.com, akpm@linux-foundation.org, madvenka@linux.microsoft.com On Thu, Sep 16, 2021 at 07:13:25PM -0400, Pasha Tatashin wrote: > The intend of trans_pgd_map_page() was to map contiguous range of VA > memory to the memory that is getting relocated during kexec. However, > since we are now using linear map instead of contiguous range this > function is not needed > > Suggested-by: Pingfan Liu > Signed-off-by: Pasha Tatashin > --- > arch/arm64/include/asm/trans_pgd.h | 5 +-- > arch/arm64/mm/trans_pgd.c | 57 ------------------------------ > 2 files changed, 1 insertion(+), 61 deletions(-) > > diff --git a/arch/arm64/include/asm/trans_pgd.h b/arch/arm64/include/asm/trans_pgd.h > index 7b04d32b102c..033d400a4ea4 100644 > --- a/arch/arm64/include/asm/trans_pgd.h > +++ b/arch/arm64/include/asm/trans_pgd.h > @@ -15,7 +15,7 @@ > /* > * trans_alloc_page > * - Allocator that should return exactly one zeroed page, if this > - * allocator fails, trans_pgd_create_copy() and trans_pgd_map_page() > + * allocator fails, trans_pgd_create_copy() and trans_pgd_idmap_page() > * return -ENOMEM error. > * > * trans_alloc_arg > @@ -30,9 +30,6 @@ struct trans_pgd_info { > int trans_pgd_create_copy(struct trans_pgd_info *info, pgd_t **trans_pgd, > unsigned long start, unsigned long end); > > -int trans_pgd_map_page(struct trans_pgd_info *info, pgd_t *trans_pgd, > - void *page, unsigned long dst_addr, pgprot_t pgprot); So this function never got used in mainline after commit 7018d467ff2d ("arm64: trans_pgd: hibernate: idmap the single page that holds the copy page routines"). I guess it's because we merged part of v10 of this series and in v12 you dropped the contiguous VA range in favour of a copy of the linear map. -- Catalin _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D5CC433F5 for ; Wed, 29 Sep 2021 16:45:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0197361262 for ; Wed, 29 Sep 2021 16:45:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0197361262 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6mWdZGCxCSR8QXAqV1YhLRguBj4ruwd5GGuQ3NEBwYQ=; b=FeQzWhcLfekbJc qZ00IhHadRth8EYEBye03LoKA/kl9sdrEf6iLWTuqqZZs9AEtYnMzBqaBIzcBkzKvWsVhdJZRgZgi Do/ioitdPd19tNemwn+2wRpG2JqbcMQXgZCPVzsNMhEyg6e0w9NI7SJKYuqppG68l69Rp6Npepbd7 K9ZbHnQLHjLipHvG6peDWVRK5biUshcvg/16zB5EIm/d/qeu7rhSjQ3qz1jzdqHfLUmkWRQt4tWBT 8hMZJSNViH5Y1kytOEN1oMxCl7FYfzgMDHUf/LqIfRUbue9U6F9cP02qNkycl13Hj0egc9ykZHvPL As6lrQs3swhsCEajurHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcgO-00BrIM-FG; Wed, 29 Sep 2021 16:43:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcgJ-00BrH9-2I; Wed, 29 Sep 2021 16:43:44 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B826161411; Wed, 29 Sep 2021 16:43:37 +0000 (UTC) Date: Wed, 29 Sep 2021 17:43:34 +0100 From: Catalin Marinas To: Pasha Tatashin Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, will@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, james.morse@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, linux-mm@kvack.org, mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com, tglx@linutronix.de, selindag@gmail.com, tyhicks@linux.microsoft.com, kernelfans@gmail.com, akpm@linux-foundation.org, madvenka@linux.microsoft.com Subject: Re: [PATCH v17 15/15] arm64: trans_pgd: remove trans_pgd_map_page() Message-ID: References: <20210916231325.125533-1-pasha.tatashin@soleen.com> <20210916231325.125533-16-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210916231325.125533-16-pasha.tatashin@soleen.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_094343_143685_0A0AC9F6 X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 16, 2021 at 07:13:25PM -0400, Pasha Tatashin wrote: > The intend of trans_pgd_map_page() was to map contiguous range of VA > memory to the memory that is getting relocated during kexec. However, > since we are now using linear map instead of contiguous range this > function is not needed > > Suggested-by: Pingfan Liu > Signed-off-by: Pasha Tatashin > --- > arch/arm64/include/asm/trans_pgd.h | 5 +-- > arch/arm64/mm/trans_pgd.c | 57 ------------------------------ > 2 files changed, 1 insertion(+), 61 deletions(-) > > diff --git a/arch/arm64/include/asm/trans_pgd.h b/arch/arm64/include/asm/trans_pgd.h > index 7b04d32b102c..033d400a4ea4 100644 > --- a/arch/arm64/include/asm/trans_pgd.h > +++ b/arch/arm64/include/asm/trans_pgd.h > @@ -15,7 +15,7 @@ > /* > * trans_alloc_page > * - Allocator that should return exactly one zeroed page, if this > - * allocator fails, trans_pgd_create_copy() and trans_pgd_map_page() > + * allocator fails, trans_pgd_create_copy() and trans_pgd_idmap_page() > * return -ENOMEM error. > * > * trans_alloc_arg > @@ -30,9 +30,6 @@ struct trans_pgd_info { > int trans_pgd_create_copy(struct trans_pgd_info *info, pgd_t **trans_pgd, > unsigned long start, unsigned long end); > > -int trans_pgd_map_page(struct trans_pgd_info *info, pgd_t *trans_pgd, > - void *page, unsigned long dst_addr, pgprot_t pgprot); So this function never got used in mainline after commit 7018d467ff2d ("arm64: trans_pgd: hibernate: idmap the single page that holds the copy page routines"). I guess it's because we merged part of v10 of this series and in v12 you dropped the contiguous VA range in favour of a copy of the linear map. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE582C433FE for ; Wed, 29 Sep 2021 16:43:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4096761262 for ; Wed, 29 Sep 2021 16:43:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4096761262 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C8045940044; Wed, 29 Sep 2021 12:43:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C302694003A; Wed, 29 Sep 2021 12:43:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1F23940044; Wed, 29 Sep 2021 12:43:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id A3EE094003A for ; Wed, 29 Sep 2021 12:43:42 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 46A5E8249980 for ; Wed, 29 Sep 2021 16:43:42 +0000 (UTC) X-FDA: 78641182284.29.309338D Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP id F077F50000AD for ; Wed, 29 Sep 2021 16:43:41 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B826161411; Wed, 29 Sep 2021 16:43:37 +0000 (UTC) Date: Wed, 29 Sep 2021 17:43:34 +0100 From: Catalin Marinas To: Pasha Tatashin Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, will@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, james.morse@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, linux-mm@kvack.org, mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com, tglx@linutronix.de, selindag@gmail.com, tyhicks@linux.microsoft.com, kernelfans@gmail.com, akpm@linux-foundation.org, madvenka@linux.microsoft.com Subject: Re: [PATCH v17 15/15] arm64: trans_pgd: remove trans_pgd_map_page() Message-ID: References: <20210916231325.125533-1-pasha.tatashin@soleen.com> <20210916231325.125533-16-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916231325.125533-16-pasha.tatashin@soleen.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F077F50000AD X-Stat-Signature: f7bi3dj44b5aeydf8zeqeiya7fgnywcd Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf04.hostedemail.com: domain of cmarinas@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-HE-Tag: 1632933821-128183 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 16, 2021 at 07:13:25PM -0400, Pasha Tatashin wrote: > The intend of trans_pgd_map_page() was to map contiguous range of VA > memory to the memory that is getting relocated during kexec. However, > since we are now using linear map instead of contiguous range this > function is not needed > > Suggested-by: Pingfan Liu > Signed-off-by: Pasha Tatashin > --- > arch/arm64/include/asm/trans_pgd.h | 5 +-- > arch/arm64/mm/trans_pgd.c | 57 ------------------------------ > 2 files changed, 1 insertion(+), 61 deletions(-) > > diff --git a/arch/arm64/include/asm/trans_pgd.h b/arch/arm64/include/asm/trans_pgd.h > index 7b04d32b102c..033d400a4ea4 100644 > --- a/arch/arm64/include/asm/trans_pgd.h > +++ b/arch/arm64/include/asm/trans_pgd.h > @@ -15,7 +15,7 @@ > /* > * trans_alloc_page > * - Allocator that should return exactly one zeroed page, if this > - * allocator fails, trans_pgd_create_copy() and trans_pgd_map_page() > + * allocator fails, trans_pgd_create_copy() and trans_pgd_idmap_page() > * return -ENOMEM error. > * > * trans_alloc_arg > @@ -30,9 +30,6 @@ struct trans_pgd_info { > int trans_pgd_create_copy(struct trans_pgd_info *info, pgd_t **trans_pgd, > unsigned long start, unsigned long end); > > -int trans_pgd_map_page(struct trans_pgd_info *info, pgd_t *trans_pgd, > - void *page, unsigned long dst_addr, pgprot_t pgprot); So this function never got used in mainline after commit 7018d467ff2d ("arm64: trans_pgd: hibernate: idmap the single page that holds the copy page routines"). I guess it's because we merged part of v10 of this series and in v12 you dropped the contiguous VA range in favour of a copy of the linear map. -- Catalin