From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: John Garry <john.garry@huawei.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.com>, Paul Clarke <pc@us.ibm.com>,
kajoljain <kjain@linux.ibm.com>,
linux-perf-users@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
Sandeep Dasgupta <sdasgup@google.com>
Subject: Re: [PATCH v9 00/13] Don't compute events that won't be used in a metric.
Date: Wed, 29 Sep 2021 13:51:23 -0300 [thread overview]
Message-ID: <YVSZi3PhwsNl3LdE@kernel.org> (raw)
In-Reply-To: <CAP-5=fXcq6Npio0n9y8znknNUGJ4ovtbi=hHr4jWG6H38=BzSA@mail.gmail.com>
Em Wed, Sep 29, 2021 at 09:09:24AM -0700, Ian Rogers escreveu:
> On Wed, Sep 29, 2021 at 8:16 AM John Garry <john.garry@huawei.com> wrote:
> >
> > On 23/09/2021 08:46, Ian Rogers wrote:
> > > For a metric like:
> > > EVENT1 if #smt_on else EVENT2
> > >
> > > currently EVENT1 and EVENT2 will be measured and then when the metric
> > > is reported EVENT1 or EVENT2 will be printed depending on the value
> > > from smt_on() during the expr parsing. Computing both events is
> > > unnecessary and can lead to multiplexing as discussed in this thread:
> > > https://lore.kernel.org/lkml/20201110100346.2527031-1-irogers@google.com/
> > >
> > > This change modifies expression parsing so that constants are
> > > considered when building the set of ids (events) and only events not
> > > contributing to a constant value are measured.
> >
> > Based on some testing on my arm64 platform, no regression seen, so:
> >
> > Tested-by: John Garry <john.garry@huawei.com>
>
> Awesome, much thanks Jiri, John, Andi for the reviews and testing!
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2021-09-29 16:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 7:46 [PATCH v9 00/13] Don't compute events that won't be used in a metric Ian Rogers
2021-09-23 7:46 ` [PATCH v9 01/13] perf metric: Restructure struct expr_parse_ctx Ian Rogers
2021-09-23 7:46 ` [PATCH v9 02/13] perf metric: Use NAN for missing event IDs Ian Rogers
2021-09-23 7:46 ` [PATCH v9 03/13] perf expr: Remove unused headers and inline d_ratio Ian Rogers
2021-09-23 7:46 ` [PATCH v9 04/13] perf expr: Separate token declataion from type Ian Rogers
2021-09-23 7:46 ` [PATCH v9 05/13] perf expr: Use macros for operators Ian Rogers
2021-09-23 7:46 ` [PATCH v9 06/13] perf expr: Move actions to the left Ian Rogers
2021-09-23 7:46 ` [PATCH v9 07/13] perf metric: Rename expr__find_other Ian Rogers
2021-09-23 7:46 ` [PATCH v9 08/13] perf metric: Add utilities to work on ids map Ian Rogers
2021-09-23 7:46 ` [PATCH v9 09/13] perf metric: Allow metrics with no events Ian Rogers
2021-09-23 7:46 ` [PATCH v9 10/13] perf expr: Merge find_ids and regular parsing Ian Rogers
2021-09-28 20:56 ` Jiri Olsa
2021-09-28 21:20 ` Ian Rogers
2021-09-23 7:46 ` [PATCH v9 11/13] perf expr: Propagate constants for binary operations Ian Rogers
2021-09-23 7:46 ` [PATCH v9 12/13] perf metric: Don't compute unused events Ian Rogers
2021-09-23 7:46 ` [PATCH v9 13/13] perf metric: Avoid events for an 'if' constant result Ian Rogers
2021-09-29 5:35 ` [PATCH v9 00/13] Don't compute events that won't be used in a metric Jiri Olsa
2021-09-29 15:19 ` John Garry
2021-09-29 16:09 ` Ian Rogers
2021-09-29 16:51 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVSZi3PhwsNl3LdE@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=sdasgup@google.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.