From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Michael Petlan <mpetlan@redhat.com>,
linux-perf-users@vger.kernel.org, jolsa@kernel.org
Subject: Re: [PATCH] perf tests vmlinux-kallsyms: ignore hidden symbols
Date: Wed, 29 Sep 2021 14:14:24 -0300 [thread overview]
Message-ID: <YVSe8Fv6YAbuLJFQ@kernel.org> (raw)
In-Reply-To: <CAP-5=fUN_fYmgm69ruBvp6E+nkLKsTvZwHqGzaRd471MhMRykA@mail.gmail.com>
Em Wed, Sep 22, 2021 at 09:36:11AM -0700, Ian Rogers escreveu:
> On Wed, Sep 22, 2021 at 8:27 AM Michael Petlan <mpetlan@redhat.com> wrote:
> >
> > Certain kernel symbols are purposely hidden from kallsyms. The function
> > is_ignored_symbol() from scripts/kallsyms.c decides if a symbol should
> > be hidden or not.
> >
> > The perf test "vmlinux symtab matches kallsyms" fails in case perf finds
> > some of the hidden symbols in its machine image and can't match them to
> > kallsyms.
> >
> > Let's add a filter to check if a symbol not found isn't one of these
> > before failing the test.
> >
> > The function is_ignored_symbol() has been copied from scripts/kallsyms.c
> > and needs to be updated along with the original.
> >
> > Signed-off-by: Michael Petlan <mpetlan@redhat.com>
>
> Acked-by: Ian Rogers <irogers@google.com>
>
> It is a shame this can't be a library to ensure the function is kept in sync.
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2021-09-29 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 15:27 [PATCH] perf tests vmlinux-kallsyms: ignore hidden symbols Michael Petlan
2021-09-22 16:36 ` Ian Rogers
2021-09-29 17:14 ` Arnaldo Carvalho de Melo [this message]
2021-09-29 21:10 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2021-07-08 12:28 Michael Petlan
2021-07-13 9:57 ` Jiri Olsa
2021-07-23 8:54 ` Michael Petlan
2021-07-23 9:03 ` Michael Petlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVSe8Fv6YAbuLJFQ@kernel.org \
--to=acme@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mpetlan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.