From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Wed, 29 Sep 2021 18:21:42 +0100 From: Catalin Marinas Subject: Re: [PATCH v17 00/15] arm64: MMU enabled kexec relocation Message-ID: References: <20210916231325.125533-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210916231325.125533-1-pasha.tatashin@soleen.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Pasha Tatashin Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, will@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, james.morse@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, linux-mm@kvack.org, mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com, tglx@linutronix.de, selindag@gmail.com, tyhicks@linux.microsoft.com, kernelfans@gmail.com, akpm@linux-foundation.org, madvenka@linux.microsoft.com On Thu, Sep 16, 2021 at 07:13:10PM -0400, Pasha Tatashin wrote: > Pasha Tatashin (15): > arm64: kernel: add helper for booted at EL2 and not VHE > arm64: trans_pgd: hibernate: Add trans_pgd_copy_el2_vectors > arm64: hibernate: abstract ttrb0 setup function > arm64: kexec: flush image and lists during kexec load time > arm64: kexec: skip relocation code for inplace kexec > arm64: kexec: Use dcache ops macros instead of open-coding > arm64: kexec: pass kimage as the only argument to relocation function > arm64: kexec: configure EL2 vectors for kexec > arm64: kexec: relocate in EL1 mode > arm64: kexec: use ld script for relocation function > arm64: kexec: install a copy of the linear-map > arm64: kexec: keep MMU enabled during kexec relocation > arm64: kexec: remove the pre-kexec PoC maintenance > arm64: kexec: remove cpu-reset.h > arm64: trans_pgd: remove trans_pgd_map_page() FWIW, I'm fine with this series. I think the only concern raised by James and not addressed is the possibility of the failure of the memory allocation for copying the page tables during kexec. If anyone will complain in the future, we can look into adding a fallback mechanism to do the relocation with the MMU off. Acked-by: Catalin Marinas _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF41C433EF for ; Wed, 29 Sep 2021 17:24:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F6BE61465 for ; Wed, 29 Sep 2021 17:24:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F6BE61465 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k/0IVZ+Hq99Ci+XxMbtE+UVOq64nnWlTNTx10wMRw/g=; b=YWMLHYl/fvij3S W+hA44uHGYQHKQowQMeqy3gG2ShmQ+OSXoJpnlYBlTiNSJ3c8Pj+W9w8QmtAtZR83ZgajBvJzz6PT oi+VfqLo8Fgq9nif4hsM338WiIaA6T/02oiO17Z7CJSDq9V7E3a/Fh0X2vlolgtFSyL0SdBDpwG1b 9BhFZYNzdPMtRjp6GvVxuNGoxzYnO2C9xJCt/JZX8ag4IHS56II7cK5BhjdKDX63lp97fp8T/QBvD tDi2ZQf3QtF49SE7R+Gcn+6Gh1A/UA5y8rz9Xy/6UEjAhcPFAskN3vc5X2P7uNc3qsQQlCuj2CkM/ h1/20rbhqDvvvZUCIHBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVdHG-00BuOd-Hl; Wed, 29 Sep 2021 17:21:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVdHB-00BuNs-Aw; Wed, 29 Sep 2021 17:21:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E40260E08; Wed, 29 Sep 2021 17:21:45 +0000 (UTC) Date: Wed, 29 Sep 2021 18:21:42 +0100 From: Catalin Marinas To: Pasha Tatashin Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, will@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, james.morse@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, linux-mm@kvack.org, mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com, tglx@linutronix.de, selindag@gmail.com, tyhicks@linux.microsoft.com, kernelfans@gmail.com, akpm@linux-foundation.org, madvenka@linux.microsoft.com Subject: Re: [PATCH v17 00/15] arm64: MMU enabled kexec relocation Message-ID: References: <20210916231325.125533-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210916231325.125533-1-pasha.tatashin@soleen.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_102149_418003_7494382E X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 16, 2021 at 07:13:10PM -0400, Pasha Tatashin wrote: > Pasha Tatashin (15): > arm64: kernel: add helper for booted at EL2 and not VHE > arm64: trans_pgd: hibernate: Add trans_pgd_copy_el2_vectors > arm64: hibernate: abstract ttrb0 setup function > arm64: kexec: flush image and lists during kexec load time > arm64: kexec: skip relocation code for inplace kexec > arm64: kexec: Use dcache ops macros instead of open-coding > arm64: kexec: pass kimage as the only argument to relocation function > arm64: kexec: configure EL2 vectors for kexec > arm64: kexec: relocate in EL1 mode > arm64: kexec: use ld script for relocation function > arm64: kexec: install a copy of the linear-map > arm64: kexec: keep MMU enabled during kexec relocation > arm64: kexec: remove the pre-kexec PoC maintenance > arm64: kexec: remove cpu-reset.h > arm64: trans_pgd: remove trans_pgd_map_page() FWIW, I'm fine with this series. I think the only concern raised by James and not addressed is the possibility of the failure of the memory allocation for copying the page tables during kexec. If anyone will complain in the future, we can look into adding a fallback mechanism to do the relocation with the MMU off. Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D47C433F5 for ; Wed, 29 Sep 2021 17:21:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A21561465 for ; Wed, 29 Sep 2021 17:21:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6A21561465 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D8EE0940048; Wed, 29 Sep 2021 13:21:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3E3394003A; Wed, 29 Sep 2021 13:21:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2DB3940048; Wed, 29 Sep 2021 13:21:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id B2E4994003A for ; Wed, 29 Sep 2021 13:21:51 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6A8B7183F96BA for ; Wed, 29 Sep 2021 17:21:51 +0000 (UTC) X-FDA: 78641278422.35.F2DC7EC Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf10.hostedemail.com (Postfix) with ESMTP id 154F3600199C for ; Wed, 29 Sep 2021 17:21:50 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E40260E08; Wed, 29 Sep 2021 17:21:45 +0000 (UTC) Date: Wed, 29 Sep 2021 18:21:42 +0100 From: Catalin Marinas To: Pasha Tatashin Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, will@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, james.morse@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, linux-mm@kvack.org, mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com, tglx@linutronix.de, selindag@gmail.com, tyhicks@linux.microsoft.com, kernelfans@gmail.com, akpm@linux-foundation.org, madvenka@linux.microsoft.com Subject: Re: [PATCH v17 00/15] arm64: MMU enabled kexec relocation Message-ID: References: <20210916231325.125533-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916231325.125533-1-pasha.tatashin@soleen.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 154F3600199C X-Stat-Signature: fmhz57fysxkq4wa9o1tkimg3ariqg5a7 Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-HE-Tag: 1632936110-654294 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 16, 2021 at 07:13:10PM -0400, Pasha Tatashin wrote: > Pasha Tatashin (15): > arm64: kernel: add helper for booted at EL2 and not VHE > arm64: trans_pgd: hibernate: Add trans_pgd_copy_el2_vectors > arm64: hibernate: abstract ttrb0 setup function > arm64: kexec: flush image and lists during kexec load time > arm64: kexec: skip relocation code for inplace kexec > arm64: kexec: Use dcache ops macros instead of open-coding > arm64: kexec: pass kimage as the only argument to relocation function > arm64: kexec: configure EL2 vectors for kexec > arm64: kexec: relocate in EL1 mode > arm64: kexec: use ld script for relocation function > arm64: kexec: install a copy of the linear-map > arm64: kexec: keep MMU enabled during kexec relocation > arm64: kexec: remove the pre-kexec PoC maintenance > arm64: kexec: remove cpu-reset.h > arm64: trans_pgd: remove trans_pgd_map_page() FWIW, I'm fine with this series. I think the only concern raised by James and not addressed is the possibility of the failure of the memory allocation for copying the page tables during kexec. If anyone will complain in the future, we can look into adding a fallback mechanism to do the relocation with the MMU off. Acked-by: Catalin Marinas