From: Wolfram Sang <wsa@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH] i2c: i801: Use PCI bus rescan mutex to protect P2SB access
Date: Wed, 29 Sep 2021 22:13:14 +0200 [thread overview]
Message-ID: <YVTI2i6n6Gv0zGv3@kunai> (raw)
In-Reply-To: <7521c130-d777-6a26-bd14-1ed784f828cc@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
On Sun, Sep 05, 2021 at 05:59:42PM +0200, Heiner Kallweit wrote:
> As pointed out by Andy in [0] using a local mutex here isn't strictly
> wrong but not sufficient. We should hold the PCI rescan lock for P2SB
> operations.
>
> [0] https://www.spinics.net/lists/linux-i2c/msg52717.html
>
> Fixes: 1a987c69ce2c ("i2c: i801: make p2sb_spinlock a mutex")
> Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-09-29 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 15:59 [PATCH] i2c: i801: Use PCI bus rescan mutex to protect P2SB access Heiner Kallweit
2021-09-06 8:30 ` Andy Shevchenko
2021-09-06 9:21 ` Jean Delvare
2021-09-29 20:13 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVTI2i6n6Gv0zGv3@kunai \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.