All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Ray Kinsella <mdr@ashroe.eu>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mbuf: remove deprecated bad outer IPv4 checksum flag on Rx
Date: Wed, 29 Sep 2021 23:51:20 +0200	[thread overview]
Message-ID: <YVTf2P2iVJlzb73n@platinum> (raw)
In-Reply-To: <20210929073734.1382905-1-andrew.rybchenko@oktetlabs.ru>

Hi Andrew,

On Wed, Sep 29, 2021 at 10:37:34AM +0300, Andrew Rybchenko wrote:
> Removed offload flag PKT_RX_EIP_CKSUM_BAD. PKT_RX_OUTER_IP_CKSUM_BAD
> should be used as a replacement.
> 
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

FYI, I just submitted a patchset that removes all PKT_ flags and
fixes the namespace. I will rebase it on top of your patch.

> ---
>  doc/guides/rel_notes/deprecation.rst   | 7 +------
>  doc/guides/rel_notes/release_21_11.rst | 3 +++
>  lib/mbuf/rte_mbuf_core.h               | 7 -------
>  3 files changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 59445a6f42..3175426dad 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -42,7 +42,7 @@ Deprecation Notices
>  * mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``.
>    A compatibility layer will be kept until DPDK 22.11, except for the flags
>    that are already deprecated (``PKT_RX_L4_CKSUM_BAD``, ``PKT_RX_IP_CKSUM_BAD``,
> -  ``PKT_RX_EIP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
> +  ``PKT_RX_OUTER_IP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
>  

I think this one should not be modified.

You can add my ack to the v2.

Thanks!
Olivier

  reply	other threads:[~2021-09-29 21:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  7:37 [dpdk-dev] [PATCH] mbuf: remove deprecated bad outer IPv4 checksum flag on Rx Andrew Rybchenko
2021-09-29 21:51 ` Olivier Matz [this message]
2021-10-11 14:51   ` Andrew Rybchenko
2021-10-11 14:28 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-10-13 21:03   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVTf2P2iVJlzb73n@platinum \
    --to=olivier.matz@6wind.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=mdr@ashroe.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.