From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, kuba@kernel.org, lukas@wunner.de,
kadlec@netfilter.org, fw@strlen.de, ast@kernel.org,
edumazet@google.com, tgraf@suug.ch, nevola@gmail.com,
john.fastabend@gmail.com, willemb@google.com
Subject: Re: [PATCH nf-next v5 0/6] Netfilter egress hook
Date: Thu, 30 Sep 2021 09:19:24 +0200 [thread overview]
Message-ID: <YVVk/C6mb8O3QMPJ@salvia> (raw)
In-Reply-To: <e4f1700c-c299-7091-1c23-60ec329a5b8d@iogearbox.net>
On Thu, Sep 30, 2021 at 08:08:53AM +0200, Daniel Borkmann wrote:
> On 9/28/21 11:55 AM, Pablo Neira Ayuso wrote:
> > Hi,
> >
> > This patchset v5 that re-adds the Netfilter egress:
> >
> > 1) Rename linux/netfilter_ingress.h to linux/netfilter_netdev.h
> > from Lukas Wunner.
> >
> > 2) Generalize ingress hook file to accomodate egress support,
> > from Lukas Wunner.
> >
> > 3) Modularize Netfilter ingress hook into nf_tables_netdev: Daniel
> > Borkmann is requesting for a mechanism to allow to blacklist
> > Netfilter, this allows users to blacklist this new module that
> > includes ingress chain and the new egress chain for the netdev
> > family. There is no other in-tree user of the ingress and egress
> > hooks than this which might interfer with his matter.
> >
> > 4) Place the egress hook again before the tc egress hook as requested
> > by Daniel Borkmann. Patch to add egress hook from Lukas Wunner.
> > The Netfilter egress hook remains behind the static key, if unused
> > performance degradation is negligible.
> >
> > 5) Add netfilter egress handling to af_packet.
> >
> > Arguably, distributors might decide to compile nf_tables_netdev
> > built-in. Traditionally, distributors have compiled their kernels using
> > the default configuration that Netfilter Kconfig provides (ie. use
> > modules whenever possible). In any case, I consider that distributor
> > policy is out of scope in this discussion, providing a mechanism to
> > allow Daniel to prevent Netfilter ingress and egress chains to be loaded
> > should be sufficient IMHO.
>
> Hm, so in the case of SRv6 users were running into a similar issue and commit
> 7a3f5b0de364 ("netfilter: add netfilter hooks to SRv6 data plane") [0] added
> a new hook along with a sysctl which defaults the new hook to off.
>
> The rationale for it was given as "the hooks are enabled via nf_hooks_lwtunnel
> sysctl to make sure existing netfilter rulesets do not break." [0,1]
>
> If the suggestion to flag the skb [2] one way or another from the tc forwarding
> path (e.g. skb bit or per-cpu marker) is not technically feasible, then why not
> do a sysctl toggle like in the SRv6 case?
I am already providing a global toggle to disable netdev
ingress/egress hooks?
In the SRv6 case that is not possible.
Why do you need you need a sysctl knob when my proposal is already
addressing your needs?
next prev parent reply other threads:[~2021-09-30 7:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 9:55 [PATCH nf-next v5 0/6] Netfilter egress hook Pablo Neira Ayuso
2021-09-28 9:55 ` [PATCH nf-next v5 1/6] netfilter: Rename ingress hook include file Pablo Neira Ayuso
2021-09-28 9:55 ` [PATCH nf-next v5 2/6] netfilter: Generalize " Pablo Neira Ayuso
2021-09-28 9:55 ` [PATCH nf-next v5 3/6] netfilter: nf_tables: move netdev ingress filter chain to nf_tables_netdev.c Pablo Neira Ayuso
2021-09-28 9:55 ` [PATCH nf-next v5 4/6] netfilter: Introduce egress hook Pablo Neira Ayuso
2021-09-28 9:55 ` [PATCH nf-next v5 5/6] af_packet: " Pablo Neira Ayuso
2021-09-28 9:55 ` [PATCH nf-next v5 6/6] netfilter: nf_tables: add egress support Pablo Neira Ayuso
2021-09-30 6:08 ` [PATCH nf-next v5 0/6] Netfilter egress hook Daniel Borkmann
2021-09-30 6:52 ` Lukas Wunner
2021-09-30 7:10 ` Daniel Borkmann
2021-09-30 7:21 ` Pablo Neira Ayuso
2021-09-30 7:19 ` Pablo Neira Ayuso [this message]
2021-09-30 7:33 ` Daniel Borkmann
2021-09-30 9:21 ` Pablo Neira Ayuso
2021-09-30 14:28 ` Jakub Kicinski
2021-09-30 15:13 ` Pablo Neira Ayuso
2021-09-30 16:06 ` Jakub Kicinski
2021-09-30 18:00 ` Pablo Neira Ayuso
2021-09-30 19:17 ` Jakub Kicinski
2021-09-30 17:12 ` Lukas Wunner
2021-09-30 17:19 ` Jakub Kicinski
2021-09-30 17:36 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVVk/C6mb8O3QMPJ@salvia \
--to=pablo@netfilter.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=john.fastabend@gmail.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=tgraf@suug.ch \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.