From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Tomas Winkler" <tomas.winkler@intel.com>,
"Alexander Usyskin" <alexander.usyskin@intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
"Arnd Bergmann" <arnd@arndb.de>, "Christoph Hellwig" <hch@lst.de>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Michal Marek" <michal.lkml@markovi.net>,
"Nick Desaulniers" <ndesaulniers@google.com>
Subject: Re: [PATCH v3 2/4] uuid: Make guid_t completely internal type to the kernel
Date: Fri, 1 Oct 2021 16:20:38 +0300 [thread overview]
Message-ID: <YVcLJmb4h7ZRBmoh@smile.fi.intel.com> (raw)
In-Reply-To: <YVcKAH6C/dAZqoAw@smile.fi.intel.com>
On Fri, Oct 01, 2021 at 04:15:44PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 01, 2021 at 02:01:15PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Oct 01, 2021 at 02:37:45PM +0300, Andy Shevchenko wrote:
> > > The guid_t type was defined in UAPI by mistake.
> > > Keep it an internal type and leave uuid_le UAPI
> > > for it's only user, i.e. MEI.
> >
> > It's used in they hyper-v drivers as a uapi between the kernel and the
> > hypervisor, so isn't that something valid here?
>
> I'm not sure I see that interface defined in the kernel. As far as I remember
> the guid_t is used solely inside kernel by Hyper-V code and the rest is using
> raw buffers. Can you point out to the specific place(s)?
Ah, it's a leftover inclusion in the uapi! Thanks for noticing.
I will add a patch to replace it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-10-01 13:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 11:37 [PATCH v3 1/4] modpost: Mark uuid_le type only for MEI Andy Shevchenko
2021-10-01 11:37 ` [PATCH v3 2/4] uuid: Make guid_t completely internal type to the kernel Andy Shevchenko
2021-10-01 12:01 ` Greg Kroah-Hartman
2021-10-01 13:15 ` Andy Shevchenko
2021-10-01 13:20 ` Andy Shevchenko [this message]
2021-10-01 11:37 ` [PATCH v3 3/4] mei: Move uuid_le_cmp() to its only user Andy Shevchenko
2021-10-01 11:37 ` [PATCH v3 4/4] mei: Unite uuid.h and mei.h in uAPI Andy Shevchenko
2021-10-01 22:41 ` kernel test robot
2021-10-01 22:41 ` kernel test robot
2021-10-01 11:59 ` [PATCH v3 1/4] modpost: Mark uuid_le type only for MEI Greg Kroah-Hartman
2021-10-01 12:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVcLJmb4h7ZRBmoh@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.usyskin@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=tomas.winkler@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.