From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Chris Lew <clew@codeaurora.org>,
Deepak Kumar Singh <deesin@codeaurora.org>
Subject: Re: [PATCH v2 3/4] soc: qcom: smem: Support reserved-memory description
Date: Fri, 1 Oct 2021 07:23:32 -0700 [thread overview]
Message-ID: <YVcZ5FsM2u+3uoK4@ripper> (raw)
In-Reply-To: <9a4ef69d-df15-0fbc-3735-6d7c861855ac@linaro.org>
On Fri 01 Oct 00:08 PDT 2021, Vladimir Zapolskiy wrote:
> On 9/30/21 9:21 PM, Bjorn Andersson wrote:
[..]
> > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
[..]
> > @@ -895,12 +892,14 @@ static int qcom_smem_map_memory(struct qcom_smem *smem, struct device *dev,
> > static int qcom_smem_probe(struct platform_device *pdev)
> > {
> > struct smem_header *header;
> > + struct reserved_mem *rmem;
> > struct qcom_smem *smem;
> > size_t array_size;
> > int num_regions;
> > int hwlock_id;
> > u32 version;
> > int ret;
> > + int i;
>
> Just a nitpicking, the index can be unsigned.
>
It's compared against the "num_regions", which is also signed. So I
think it should be signed.
[..]
> > + for (i = 0; i < num_regions; i++) {
Thanks for the review!
Regards,
Bjorn
next prev parent reply other threads:[~2021-10-01 14:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 18:21 [PATCH v2 0/4] dt-bindings: soc: smem: Make indirection optional Bjorn Andersson
2021-09-30 18:21 ` [PATCH v2 1/4] dt-bindings: sram: Document qcom,rpm-msg-ram Bjorn Andersson
2021-10-06 21:18 ` Rob Herring
2021-09-30 18:21 ` [PATCH v2 2/4] dt-bindings: soc: smem: Make indirection optional Bjorn Andersson
2021-10-06 21:19 ` Rob Herring
2021-09-30 18:21 ` [PATCH v2 3/4] soc: qcom: smem: Support reserved-memory description Bjorn Andersson
2021-10-01 7:08 ` Vladimir Zapolskiy
2021-10-01 14:23 ` Bjorn Andersson [this message]
2021-10-06 21:20 ` Rob Herring
2021-09-30 18:21 ` [PATCH v2 4/4] arm64: dts: qcom: sdm845: Drop standalone smem node Bjorn Andersson
2021-10-17 15:31 ` (subset) " Bjorn Andersson
2021-10-01 7:11 ` [PATCH v2 0/4] dt-bindings: soc: smem: Make indirection optional Vladimir Zapolskiy
2021-10-16 4:40 ` patchwork-bot+linux-arm-msm
2021-10-17 15:31 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVcZ5FsM2u+3uoK4@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=clew@codeaurora.org \
--cc=deesin@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.