From: Rob Herring <robh@kernel.org>
To: Souradeep Chowdhury <schowdhu@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org,
Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, ckadabi@codeaurora.org,
tsoni@codeaurora.org, bryanh@codeaurora.org,
psodagud@codeaurora.org, satyap@codeaurora.org,
pheragu@codeaurora.org, Rajendra Nayak <rnayak@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Subject: Re: [PATCH V0 1/7] dt-bindings: connector: Add property for eud type c connector
Date: Mon, 4 Oct 2021 11:37:09 -0500 [thread overview]
Message-ID: <YVsttQySDnaXxOuI@robh.at.kernel.org> (raw)
In-Reply-To: <246c9d24da27b6ce91d5f1e536fa96ac5656a0b2.1633343547.git.schowdhu@codeaurora.org>
On Mon, Oct 04, 2021 at 04:46:19PM +0530, Souradeep Chowdhury wrote:
> Added the property for EUD(Embedded USB Debug) connector.Added
> the "reg" and "interrupts" property which is needed for EUD.
You are going to need a better explanation of this h/w.
>
> Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org>
> ---
> .../devicetree/bindings/connector/usb-connector.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 7eb8659..908129f 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -30,6 +30,21 @@ properties:
> - const: samsung,usb-connector-11pin
> - const: usb-b-connector
>
> + - items:
> + - enum:
> + - qcom,sc7280-usb-connector-eud
> + - const: qcom,usb-connector-eud
> + - const: usb-c-connector
> +
> + reg:
> + items:
> + - description: EUD Base Register Region
> + - description: EUD Mode Manager Region
A connector node represents the physical connector on a board. That
can't really be an MMIO peripheral. Maybe you need a node for EUD and
then it should have a connector child node? Don't really know without
understanding this h/w.
> +
> + interrupts:
> + description:
> + EUD interrupt
> +
> label:
> description: Symbolic name for the connector.
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
>
next prev parent reply other threads:[~2021-10-04 16:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 11:16 [PATCH V0 0/7] Add Embedded USB Debugger (EUD) driver Souradeep Chowdhury
2021-10-04 11:16 ` [PATCH V0 1/7] dt-bindings: connector: Add property for eud type c connector Souradeep Chowdhury
2021-10-04 16:37 ` Rob Herring [this message]
2021-10-05 13:11 ` schowdhu
2021-10-05 16:37 ` Bjorn Andersson
2021-10-07 9:25 ` schowdhu
2021-10-12 3:22 ` Bjorn Andersson
2021-11-02 9:20 ` schowdhu
2021-10-04 11:16 ` [PATCH V0 2/7] dt-bindings: usb: dwc3: Update dwc3 properties for EUD connector Souradeep Chowdhury
2021-10-04 15:50 ` Bjorn Andersson
2021-10-05 12:57 ` schowdhu
2021-10-04 11:16 ` [PATCH V0 3/7] usb: dwc3: drd: Register the eud connector child node for dwc3 Souradeep Chowdhury
2021-10-05 4:42 ` kernel test robot
2021-10-05 4:42 ` kernel test robot
2021-10-05 12:32 ` kernel test robot
2021-10-05 12:32 ` kernel test robot
2021-10-04 11:16 ` [PATCH V0 4/7] usb: common: eud: Added the driver support for Embedded USB Debugger(EUD) Souradeep Chowdhury
2021-10-04 11:31 ` Greg KH
2021-10-05 12:54 ` schowdhu
2021-10-04 16:42 ` Bjorn Andersson
2021-10-05 7:14 ` Joe Perches
2021-10-05 13:58 ` schowdhu
2021-10-05 13:01 ` schowdhu
2021-10-04 20:08 ` Randy Dunlap
2021-10-05 13:57 ` schowdhu
2021-10-04 11:16 ` [PATCH V0 5/7] arm64: dts: qcom: sc7280: Add EUD connector node Souradeep Chowdhury
2021-10-04 11:16 ` [PATCH V0 6/7] arm64: dts: qcom: sc7280: Set the default dr_mode for usb2 Souradeep Chowdhury
2021-10-04 11:16 ` [PATCH V0 7/7] MAINTAINERS: Add maintainer entry for EUD Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVsttQySDnaXxOuI@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryanh@codeaurora.org \
--cc=ckadabi@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pheragu@codeaurora.org \
--cc=psodagud@codeaurora.org \
--cc=pure.logic@nexus-software.ie \
--cc=rnayak@codeaurora.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=satyap@codeaurora.org \
--cc=schowdhu@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.