From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Abhinav Kumar <abhinavk@codeaurora.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Rob Clark <robdclark@gmail.com>, Rob Herring <robh+dt@kernel.org>,
Sean Paul <sean@poorly.run>, Kuogee Hsieh <khsieh@codeaurora.org>,
Tanmay Shah <tanmay@codeaurora.org>,
Chandan Uddaraju <chandanu@codeaurora.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] drm/msm/dp: Refactor ioremap wrapper
Date: Mon, 4 Oct 2021 18:19:34 -0700 [thread overview]
Message-ID: <YVuoJgquTnCYviRo@ripper> (raw)
In-Reply-To: <CAE-0n52bY27rZzarqrgjh37W3SsyvKTH70H++SmqoZOyETZKPw@mail.gmail.com>
On Mon 04 Oct 18:04 PDT 2021, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2021-10-01 10:43:58)
> > In order to deal with multiple memory ranges in the following commit
> > change the ioremap wrapper to not poke directly into the dss_io_data
> > struct.
> >
> > While at it, devm_ioremap_resource() already prints useful error
> > messages on failure, so omit the unnecessary prints from the caller.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> I realize this will cause some prints when we use old DTs. I suppose
> that's OK though because we'll have more incentive to update existing
> DT.
The use of the current binding is fairly limited, so I think that makes
sense. Abhinav also requested earlier that we do that and drop the
fallback sooner rather than later, which I would like to see as well.
Thanks,
Bjorn
next prev parent reply other threads:[~2021-10-05 1:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 17:43 [PATCH v3 0/5] drm/msm/dp: Allow variation in register regions Bjorn Andersson
2021-10-01 17:43 ` [PATCH v3 1/5] dt-bindings: msm/dp: Change reg definition Bjorn Andersson
2021-10-05 20:56 ` [Freedreno] " abhinavk
2021-10-01 17:43 ` [PATCH v3 2/5] drm/msm/dp: Use devres for ioremap() Bjorn Andersson
2021-10-01 17:43 ` [PATCH v3 3/5] drm/msm/dp: Refactor ioremap wrapper Bjorn Andersson
2021-10-05 1:04 ` Stephen Boyd
2021-10-05 1:19 ` Bjorn Andersson [this message]
2021-10-05 20:59 ` [Freedreno] " abhinavk
2021-10-01 17:43 ` [PATCH v3 4/5] drm/msm/dp: Store each subblock in the io region Bjorn Andersson
2021-10-05 21:04 ` [Freedreno] " abhinavk
2021-10-01 17:44 ` [PATCH v3 5/5] drm/msm/dp: Allow sub-regions to be specified in DT Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVuoJgquTnCYviRo@ripper \
--to=bjorn.andersson@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=chandanu@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=tanmay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.