From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 2/3] usb: gadget: configfs: add gadget_info for config group
Date: Tue, 5 Oct 2021 13:11:56 +0200 [thread overview]
Message-ID: <YVwy/AHW2jfeGRnl@kroah.com> (raw)
In-Reply-To: <1630976977-13938-3-git-send-email-quic_linyyuan@quicinc.com>
On Tue, Sep 07, 2021 at 09:09:36AM +0800, Linyu Yuan wrote:
> add gadget_info pointer in struct config_usb_cfg
> to allow common gadget info trace from configfs layer.
Again, I do not understand this description, can you please try to
reword it?
>
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> ---
> v2: no change
> v3: change struct inside configfs.c
> v4: no change
> v5: no change
>
> drivers/usb/gadget/configfs.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 5b2e6f9..cea12c3 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -70,6 +70,7 @@ struct config_usb_cfg {
> struct usb_configuration c;
> struct list_head func_list;
> struct usb_gadget_strings *gstrings[MAX_USB_STRING_LANGS + 1];
> + struct gadget_info *gi;
You add a pointer, where are you removing it?
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-05 11:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 1:09 [PATCH v5 0/3] usb: gadget: configfs: add some trace event Linyu Yuan
2021-09-07 1:09 ` [PATCH v5 1/3] usb: gadget: configfs: avoid list move operation of usb_function Linyu Yuan
2021-10-05 11:10 ` Greg Kroah-Hartman
2021-10-09 2:26 ` Linyu Yuan (QUIC)
2021-10-10 13:04 ` Greg Kroah-Hartman
2021-10-12 3:54 ` Linyu Yuan (QUIC)
2021-10-12 7:30 ` Greg Kroah-Hartman
2021-10-13 2:54 ` Linyu Yuan (QUIC)
2021-10-09 5:28 ` Linyu Yuan (QUIC)
2021-09-07 1:09 ` [PATCH v5 2/3] usb: gadget: configfs: add gadget_info for config group Linyu Yuan
2021-10-05 11:11 ` Greg Kroah-Hartman [this message]
2021-10-09 5:32 ` Linyu Yuan (QUIC)
2021-09-07 1:09 ` [PATCH v5 3/3] usb: gadget: configfs: add some trace event Linyu Yuan
2021-10-05 11:16 ` Greg Kroah-Hartman
2021-10-08 1:09 ` Jack Pham
2021-10-08 5:38 ` Greg Kroah-Hartman
2021-10-08 5:50 ` Trilok Soni
2021-10-16 15:29 ` Linyu Yuan (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVwy/AHW2jfeGRnl@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_linyyuan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.