From: Lee Jones <lee.jones@linaro.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
users@linux.kernel.org, tools@linux.kernel.org
Subject: Re: Acked-by missed when applying
Date: Tue, 5 Oct 2021 14:50:40 +0100 [thread overview]
Message-ID: <YVxYMAjIbEEUKs3I@google.com> (raw)
In-Reply-To: <20211005153735.7a50b3c6@coco.lan>
On Tue, 05 Oct 2021, Mauro Carvalho Chehab wrote:
> Em Tue, 5 Oct 2021 08:53:28 -0400
> Konstantin Ryabitsev <konstantin@linuxfoundation.org> escreveu:
>
> > On Tue, Oct 05, 2021 at 01:48:04PM +0100, Lee Jones wrote:
> > > > > Can you think of a reason why `b4` missed Greg's Ack here?
> > > >
> > > > Because you applied the first v2 patch, not the second v2 threaded to
> > > > the 1st one that Greg acked.
> > >
> > > Not sure I understand.
> > >
> > > This is the thread of the patch I merged:
> > >
> > > https://i.imgur.com/k4hD9kO.png
> > >
> > > Greg's Ack is located in the 5th message down.
> >
> > If you look at the thread overview, you'll notice that there are two messages
> > with identical subjects, sent 3 weeks apart:
> >
> > 2021-09-02 12:47 [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata
> >
> > and
> >
> > 2021-09-28 6:58 [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata
> >
> > As far as b4 is treating things internally, the second v2 (from Sep 28)
> > starts a new thread, so any trailers sent to the Sep-02 version will not
> > apply to the Sep-29 version and vice versa.
>
> The patch is actually identical (and I guess it is also identical
> to version 1). I ended forgetting that I had already submitted it during
> the merge window. So, I ended forgetting to either increase its version
> number or to add a RESEND to it.
>
> Sorry for the mess.
If it wasn't you, it would have been someone else.
Thanks for highlighting issue.
Hopefully it can be resolved trivially.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-10-05 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 8:01 Acked-by missed when applying Lee Jones
2021-10-05 12:22 ` Rob Herring
2021-10-05 12:45 ` Konstantin Ryabitsev
2021-10-05 12:49 ` Mark Brown
2021-10-05 13:25 ` Theodore Ts'o
2021-10-05 13:22 ` Lee Jones
2021-10-05 12:48 ` Lee Jones
2021-10-05 12:53 ` Konstantin Ryabitsev
2021-10-05 13:12 ` Lee Jones
2021-10-05 13:37 ` Mauro Carvalho Chehab
2021-10-05 13:50 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVxYMAjIbEEUKs3I@google.com \
--to=lee.jones@linaro.org \
--cc=konstantin@linuxfoundation.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=tools@linux.kernel.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.