From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF3AC433F5 for ; Tue, 5 Oct 2021 15:22:49 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id BF53D61502 for ; Tue, 5 Oct 2021 15:22:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF53D61502 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 37FE24B32B; Tue, 5 Oct 2021 11:22:48 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fA31+tuI0hHQ; Tue, 5 Oct 2021 11:22:47 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0E2BB4B30F; Tue, 5 Oct 2021 11:22:47 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 590A34B305 for ; Tue, 5 Oct 2021 11:22:45 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Y2a+BSU-efa for ; Tue, 5 Oct 2021 11:22:44 -0400 (EDT) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 35AEF4B2A1 for ; Tue, 5 Oct 2021 11:22:44 -0400 (EDT) Received: by mail-pg1-f182.google.com with SMTP id h3so9453094pgb.7 for ; Tue, 05 Oct 2021 08:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jsoEJt9R8crAH2RcsfBnQLCdcmXo4iVFPCHH8skN9hQ=; b=Ed27JI5WdcMBjzCmHglgYbPkFapHRW8VivzST0erYb/L/PV6Fx0rpTBNDt1223jRVb eQ5IVgSRDi5VCqGDiJM5A7rbcPMvwg6w1jg0wDhDNxogy7g8tXHb5gAQu3MkQZ4aTk9Q D+35shvAdiTeBDH9W72MNR7F3tUnMUT8t+zTm8lCHdonVdqfrCyFpDQ97vP6AwGRNn/X GOqBrTVYIjZiBhdOV7etEqYr4+lx5qlCy7z4mzvugVDQwWWAnXWWM9Dac9u4kMeqF4o0 q66/1KN+gVVuBQ71H+9jz7Qi8kNlcIq5g+ueK+T83d6rxeradLUvtNWie9PUJyUcAjyk VesA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jsoEJt9R8crAH2RcsfBnQLCdcmXo4iVFPCHH8skN9hQ=; b=VbbMKi2HkSc7rRKO7CRFBvavkkXbNqUubQn0+U/y3Gtf87WI57j2tk6BXrrFbB1/WT m+eWO3GefoqQUV8LGZOYUi8kxpNrE7LhkQ8Z9Y83sTxFykXKNdN9SGJyVwSSqTJJxwnn qu4jL54jzBkym1k/ABGTqVV2HvNNDCLlNlYrQgVw5MmQpwA2k9EEbxSGvRgfMbivm6+g b8792ad7/dO/BNXYMSb8iOlykWzwTXiHsv3aq/cu37ptwG/cDh0h/xZFB6dmBPwcSdk6 tNbYN9/r7SZLJePGXBZ2eJjMxFuQ4P0nlm8ZXRD9VC4c8jaJUnfcLDEFKa1+IcNv1aAM 19fQ== X-Gm-Message-State: AOAM531zfatvCCVzQ81/pUGYhWygHRX+78+jd7sdUZssr/lsXdzl45b+ Vn80ShRI6FKZCryUE0ilxsUCrA== X-Google-Smtp-Source: ABdhPJyd+BrY951cMRvWU+Hdnw02yUD1081dLTCog2uFgukEdDRDWflW+t6MGsO3nWUcqCgRuybMcw== X-Received: by 2002:a62:b50d:0:b0:44b:b81f:a956 with SMTP id y13-20020a62b50d000000b0044bb81fa956mr30655368pfe.27.1633447363159; Tue, 05 Oct 2021 08:22:43 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id z2sm6907837pfe.210.2021.10.05.08.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 08:22:42 -0700 (PDT) Date: Tue, 5 Oct 2021 15:22:39 +0000 From: Sean Christopherson To: Oliver Upton Subject: Re: [PATCH v8 7/7] KVM: x86: Expose TSC offset controls to userspace Message-ID: References: <20210916181538.968978-1-oupton@google.com> <20210916181538.968978-8-oupton@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210916181538.968978-8-oupton@google.com> Cc: Catalin Marinas , kvm@vger.kernel.org, Will Deacon , Marc Zyngier , Peter Shier , David Matlack , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVGh1LCBTZXAgMTYsIDIwMjEsIE9saXZlciBVcHRvbiB3cm90ZToKPiArc3RhdGljIGludCBr dm1fYXJjaF90c2NfZ2V0X2F0dHIoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LAo+ICsJCQkJIHN0cnVj dCBrdm1fZGV2aWNlX2F0dHIgKmF0dHIpCj4gK3sKPiArCXU2NCBfX3VzZXIgKnVhZGRyID0gKHU2 NCBfX3VzZXIgKilhdHRyLT5hZGRyOwoKLi4uCgo+ICtzdGF0aWMgaW50IGt2bV9hcmNoX3RzY19z ZXRfYXR0cihzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUsCj4gKwkJCQkgc3RydWN0IGt2bV9kZXZpY2Vf YXR0ciAqYXR0cikKPiArewo+ICsJdTY0IF9fdXNlciAqdWFkZHIgPSAodTY0IF9fdXNlciAqKWF0 dHItPmFkZHI7CgpUaGVzZSBjYXN0cyBicmVhayAzMi1iaXQgYnVpbGRzIGJlY2F1c2Ugb2YgdHJ1 bmNhdGluZyBhdHRyLT5hZGRyIGZyb20gNjQtYml0IGludAp0byBhIDMyLWJpdCBwb2ludGVyLiAg VGhlIGFkZHJlc3Mgc2hvdWxkIGFsc28gYmUgY2hlY2tlZCB0byB2ZXJpZnkgYml0cyA2MzozMiBh cmUKbm90IHNldCBvbiAzMi1iaXQga2VybmVscy4KCmFyY2gveDg2L2t2bS94ODYuYzogSW4gZnVu Y3Rpb24g4oCYa3ZtX2FyY2hfdHNjX2dldF9hdHRy4oCZOgphcmNoL3g4Ni9rdm0veDg2LmM6NDk0 NzoyMjogZXJyb3I6IGNhc3QgdG8gcG9pbnRlciBmcm9tIGludGVnZXIgb2YgZGlmZmVyZW50IHNp emUgWy1XZXJyb3I9aW50LXRvLXBvaW50ZXItY2FzdF0KIDQ5NDcgfCAgdTY0IF9fdXNlciAqdWFk ZHIgPSAodTY0IF9fdXNlciAqKWF0dHItPmFkZHI7CiAgICAgIHwgICAgICAgICAgICAgICAgICAg ICAgXgphcmNoL3g4Ni9rdm0veDg2LmM6IEluIGZ1bmN0aW9uIOKAmGt2bV9hcmNoX3RzY19zZXRf YXR0cuKAmToKYXJjaC94ODYva3ZtL3g4Ni5jOjQ5Njc6MjI6IGVycm9yOiBjYXN0IHRvIHBvaW50 ZXIgZnJvbSBpbnRlZ2VyIG9mIGRpZmZlcmVudCBzaXplIFstV2Vycm9yPWludC10by1wb2ludGVy LWNhc3RdCiA0OTY3IHwgIHU2NCBfX3VzZXIgKnVhZGRyID0gKHU2NCBfX3VzZXIgKilhdHRyLT5h ZGRyOwogICAgICB8ICAgICAgICAgICAgICAgICAgICAgIF4KCgpOb3Qgc3VyZSBpZiB0aGVyZSdz IGEgbW9yZSBlbGVnYW50IGFwcHJvYWNoIHRoYW4gY2FzdHMgZ2Fsb3JlPwoKZGlmZiAtLWdpdCBh L2FyY2gveDg2L2t2bS94ODYuYyBiL2FyY2gveDg2L2t2bS94ODYuYwppbmRleCA4ZTVlNDYyZmZk NjUuLjM5MzBlNWRjZGYwZSAxMDA2NDQKLS0tIGEvYXJjaC94ODYva3ZtL3g4Ni5jCisrKyBiL2Fy Y2gveDg2L2t2bS94ODYuYwpAQCAtNDk0NCw5ICs0OTQ0LDEyIEBAIHN0YXRpYyBpbnQga3ZtX2Fy Y2hfdHNjX2hhc19hdHRyKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKIHN0YXRpYyBpbnQga3ZtX2Fy Y2hfdHNjX2dldF9hdHRyKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc3RydWN0IGt2bV9kZXZpY2VfYXR0ciAqYXR0cikKIHsKLSAgICAgICB1 NjQgX191c2VyICp1YWRkciA9ICh1NjQgX191c2VyICopYXR0ci0+YWRkcjsKKyAgICAgICB1NjQg X191c2VyICp1YWRkciA9ICh1NjQgX191c2VyICopKHVuc2lnbmVkIGxvbmcpYXR0ci0+YWRkcjsK ICAgICAgICBpbnQgcjsKCisgICAgICAgaWYgKCh1NjQpKHVuc2lnbmVkIGxvbmcpdWFkZHIgIT0g YXR0ci0+YWRkcikKKyAgICAgICAgICAgICAgIHJldHVybiAtRUZBVUxUOworCiAgICAgICAgc3dp dGNoIChhdHRyLT5hdHRyKSB7CiAgICAgICAgY2FzZSBLVk1fVkNQVV9UU0NfT0ZGU0VUOgogICAg ICAgICAgICAgICAgciA9IC1FRkFVTFQ7CkBAIC00OTY0LDEwICs0OTY3LDEzIEBAIHN0YXRpYyBp bnQga3ZtX2FyY2hfdHNjX2dldF9hdHRyKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKIHN0YXRpYyBp bnQga3ZtX2FyY2hfdHNjX3NldF9hdHRyKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGt2bV9kZXZpY2VfYXR0ciAqYXR0cikKIHsK LSAgICAgICB1NjQgX191c2VyICp1YWRkciA9ICh1NjQgX191c2VyICopYXR0ci0+YWRkcjsKKyAg ICAgICB1NjQgX191c2VyICp1YWRkciA9ICh1NjQgX191c2VyICopKHVuc2lnbmVkIGxvbmcpYXR0 ci0+YWRkcjsKICAgICAgICBzdHJ1Y3Qga3ZtICprdm0gPSB2Y3B1LT5rdm07CiAgICAgICAgaW50 IHI7CgorICAgICAgIGlmICgodTY0KSh1bnNpZ25lZCBsb25nKXVhZGRyICE9IGF0dHItPmFkZHIp CisgICAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsKKwogICAgICAgIHN3aXRjaCAoYXR0ci0+ YXR0cikgewogICAgICAgIGNhc2UgS1ZNX1ZDUFVfVFNDX09GRlNFVDogewogICAgICAgICAgICAg ICAgdTY0IG9mZnNldCwgdHNjLCBuczsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1i aWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3Zt YXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A14CEC433F5 for ; Tue, 5 Oct 2021 15:24:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F4A161165 for ; Tue, 5 Oct 2021 15:24:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F4A161165 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aupiZGUt88myAb102FeSejVzLmqX4h0z1NB9QWIctgc=; b=qrtg9nFnspj7wx wQkeuEPtjt5V7irMOwbYaHGh1hI+QXHSqU9Np2lyPL/IEmd0Y8fE9bFhA5ZmNiPufqXnSIjA26wA3 KWvU3/vnyy+T5ANpXdDROH1VN0FaDqLEO3qguoOsRBagpSHBJzvEUiIpFVkg0rHmCbkKvek3sYb7P 4GMZjaVQHelaKOYjDKBVD3RCUheKmTCxZHwYfXRpCtOtcu7rPEb01nEpKXchQNnukOPn74TCRxaoM XQv3BVUf0ePv3kK+4GZ4o+Ofz+4qCNjKQnenFZQzRfcAqpx1UShKIed8sSmoxf9ZfXRyF4BSMJPuR +H1WYXhvJ3MDactNDGNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXmHI-00B35m-IY; Tue, 05 Oct 2021 15:22:48 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXmHE-00B358-Iy for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 15:22:45 +0000 Received: by mail-pf1-x42b.google.com with SMTP id s16so17754202pfk.0 for ; Tue, 05 Oct 2021 08:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jsoEJt9R8crAH2RcsfBnQLCdcmXo4iVFPCHH8skN9hQ=; b=Ed27JI5WdcMBjzCmHglgYbPkFapHRW8VivzST0erYb/L/PV6Fx0rpTBNDt1223jRVb eQ5IVgSRDi5VCqGDiJM5A7rbcPMvwg6w1jg0wDhDNxogy7g8tXHb5gAQu3MkQZ4aTk9Q D+35shvAdiTeBDH9W72MNR7F3tUnMUT8t+zTm8lCHdonVdqfrCyFpDQ97vP6AwGRNn/X GOqBrTVYIjZiBhdOV7etEqYr4+lx5qlCy7z4mzvugVDQwWWAnXWWM9Dac9u4kMeqF4o0 q66/1KN+gVVuBQ71H+9jz7Qi8kNlcIq5g+ueK+T83d6rxeradLUvtNWie9PUJyUcAjyk VesA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jsoEJt9R8crAH2RcsfBnQLCdcmXo4iVFPCHH8skN9hQ=; b=doQtP13rqGQIQCyVZiYJdokmlqF06OtIMBWbDJmAbaSS7wwPDMoNYULBgGmWqw1gl6 mLmzdpy1fSjw22CVUrtOisJNrj+aZqMKmpgxrKvofTmNfUs8aZ10QWgYtzlSh9odXnxY pESUyvyhAbI1Ke1w6ilhbkoED/vla6dVm84E6O18jfuTudA/p6KabQeXUSeEjVJmsglT T1+PbHSxxWjEF04spiBJpu5+1JELYp4hEeYTT4p1iIbSnxgkGX5KoeePgoQXObjxconW ItFfZqhPB8IZT0f7FAYUye5jaby4C0H2AzfysLnPYgwg0mb0WIjcyZxSuRzs4aireNfM jG2A== X-Gm-Message-State: AOAM530b2bWvgRLoi05tdEtuz+UN9RyFBC6x9ZwE1cfyoXukY2lx4utb o0dRkaK+K395qTUq6wjm00htYQ== X-Google-Smtp-Source: ABdhPJyd+BrY951cMRvWU+Hdnw02yUD1081dLTCog2uFgukEdDRDWflW+t6MGsO3nWUcqCgRuybMcw== X-Received: by 2002:a62:b50d:0:b0:44b:b81f:a956 with SMTP id y13-20020a62b50d000000b0044bb81fa956mr30655368pfe.27.1633447363159; Tue, 05 Oct 2021 08:22:43 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id z2sm6907837pfe.210.2021.10.05.08.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 08:22:42 -0700 (PDT) Date: Tue, 5 Oct 2021 15:22:39 +0000 From: Sean Christopherson To: Oliver Upton Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Paolo Bonzini , Marc Zyngier , Peter Shier , Jim Mattson , David Matlack , Ricardo Koller , Jing Zhang , Raghavendra Rao Anata , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, Andrew Jones , Will Deacon , Catalin Marinas Subject: Re: [PATCH v8 7/7] KVM: x86: Expose TSC offset controls to userspace Message-ID: References: <20210916181538.968978-1-oupton@google.com> <20210916181538.968978-8-oupton@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210916181538.968978-8-oupton@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_082244_650882_FD3E7CBD X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBTZXAgMTYsIDIwMjEsIE9saXZlciBVcHRvbiB3cm90ZToKPiArc3RhdGljIGludCBr dm1fYXJjaF90c2NfZ2V0X2F0dHIoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LAo+ICsJCQkJIHN0cnVj dCBrdm1fZGV2aWNlX2F0dHIgKmF0dHIpCj4gK3sKPiArCXU2NCBfX3VzZXIgKnVhZGRyID0gKHU2 NCBfX3VzZXIgKilhdHRyLT5hZGRyOwoKLi4uCgo+ICtzdGF0aWMgaW50IGt2bV9hcmNoX3RzY19z ZXRfYXR0cihzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUsCj4gKwkJCQkgc3RydWN0IGt2bV9kZXZpY2Vf YXR0ciAqYXR0cikKPiArewo+ICsJdTY0IF9fdXNlciAqdWFkZHIgPSAodTY0IF9fdXNlciAqKWF0 dHItPmFkZHI7CgpUaGVzZSBjYXN0cyBicmVhayAzMi1iaXQgYnVpbGRzIGJlY2F1c2Ugb2YgdHJ1 bmNhdGluZyBhdHRyLT5hZGRyIGZyb20gNjQtYml0IGludAp0byBhIDMyLWJpdCBwb2ludGVyLiAg VGhlIGFkZHJlc3Mgc2hvdWxkIGFsc28gYmUgY2hlY2tlZCB0byB2ZXJpZnkgYml0cyA2MzozMiBh cmUKbm90IHNldCBvbiAzMi1iaXQga2VybmVscy4KCmFyY2gveDg2L2t2bS94ODYuYzogSW4gZnVu Y3Rpb24g4oCYa3ZtX2FyY2hfdHNjX2dldF9hdHRy4oCZOgphcmNoL3g4Ni9rdm0veDg2LmM6NDk0 NzoyMjogZXJyb3I6IGNhc3QgdG8gcG9pbnRlciBmcm9tIGludGVnZXIgb2YgZGlmZmVyZW50IHNp emUgWy1XZXJyb3I9aW50LXRvLXBvaW50ZXItY2FzdF0KIDQ5NDcgfCAgdTY0IF9fdXNlciAqdWFk ZHIgPSAodTY0IF9fdXNlciAqKWF0dHItPmFkZHI7CiAgICAgIHwgICAgICAgICAgICAgICAgICAg ICAgXgphcmNoL3g4Ni9rdm0veDg2LmM6IEluIGZ1bmN0aW9uIOKAmGt2bV9hcmNoX3RzY19zZXRf YXR0cuKAmToKYXJjaC94ODYva3ZtL3g4Ni5jOjQ5Njc6MjI6IGVycm9yOiBjYXN0IHRvIHBvaW50 ZXIgZnJvbSBpbnRlZ2VyIG9mIGRpZmZlcmVudCBzaXplIFstV2Vycm9yPWludC10by1wb2ludGVy LWNhc3RdCiA0OTY3IHwgIHU2NCBfX3VzZXIgKnVhZGRyID0gKHU2NCBfX3VzZXIgKilhdHRyLT5h ZGRyOwogICAgICB8ICAgICAgICAgICAgICAgICAgICAgIF4KCgpOb3Qgc3VyZSBpZiB0aGVyZSdz IGEgbW9yZSBlbGVnYW50IGFwcHJvYWNoIHRoYW4gY2FzdHMgZ2Fsb3JlPwoKZGlmZiAtLWdpdCBh L2FyY2gveDg2L2t2bS94ODYuYyBiL2FyY2gveDg2L2t2bS94ODYuYwppbmRleCA4ZTVlNDYyZmZk NjUuLjM5MzBlNWRjZGYwZSAxMDA2NDQKLS0tIGEvYXJjaC94ODYva3ZtL3g4Ni5jCisrKyBiL2Fy Y2gveDg2L2t2bS94ODYuYwpAQCAtNDk0NCw5ICs0OTQ0LDEyIEBAIHN0YXRpYyBpbnQga3ZtX2Fy Y2hfdHNjX2hhc19hdHRyKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKIHN0YXRpYyBpbnQga3ZtX2Fy Y2hfdHNjX2dldF9hdHRyKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc3RydWN0IGt2bV9kZXZpY2VfYXR0ciAqYXR0cikKIHsKLSAgICAgICB1 NjQgX191c2VyICp1YWRkciA9ICh1NjQgX191c2VyICopYXR0ci0+YWRkcjsKKyAgICAgICB1NjQg X191c2VyICp1YWRkciA9ICh1NjQgX191c2VyICopKHVuc2lnbmVkIGxvbmcpYXR0ci0+YWRkcjsK ICAgICAgICBpbnQgcjsKCisgICAgICAgaWYgKCh1NjQpKHVuc2lnbmVkIGxvbmcpdWFkZHIgIT0g YXR0ci0+YWRkcikKKyAgICAgICAgICAgICAgIHJldHVybiAtRUZBVUxUOworCiAgICAgICAgc3dp dGNoIChhdHRyLT5hdHRyKSB7CiAgICAgICAgY2FzZSBLVk1fVkNQVV9UU0NfT0ZGU0VUOgogICAg ICAgICAgICAgICAgciA9IC1FRkFVTFQ7CkBAIC00OTY0LDEwICs0OTY3LDEzIEBAIHN0YXRpYyBp bnQga3ZtX2FyY2hfdHNjX2dldF9hdHRyKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKIHN0YXRpYyBp bnQga3ZtX2FyY2hfdHNjX3NldF9hdHRyKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGt2bV9kZXZpY2VfYXR0ciAqYXR0cikKIHsK LSAgICAgICB1NjQgX191c2VyICp1YWRkciA9ICh1NjQgX191c2VyICopYXR0ci0+YWRkcjsKKyAg ICAgICB1NjQgX191c2VyICp1YWRkciA9ICh1NjQgX191c2VyICopKHVuc2lnbmVkIGxvbmcpYXR0 ci0+YWRkcjsKICAgICAgICBzdHJ1Y3Qga3ZtICprdm0gPSB2Y3B1LT5rdm07CiAgICAgICAgaW50 IHI7CgorICAgICAgIGlmICgodTY0KSh1bnNpZ25lZCBsb25nKXVhZGRyICE9IGF0dHItPmFkZHIp CisgICAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsKKwogICAgICAgIHN3aXRjaCAoYXR0ci0+ YXR0cikgewogICAgICAgIGNhc2UgS1ZNX1ZDUFVfVFNDX09GRlNFVDogewogICAgICAgICAgICAg ICAgdTY0IG9mZnNldCwgdHNjLCBuczsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF074C433EF for ; Tue, 5 Oct 2021 15:22:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6F8561502 for ; Tue, 5 Oct 2021 15:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235148AbhJEPYf (ORCPT ); Tue, 5 Oct 2021 11:24:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231513AbhJEPYe (ORCPT ); Tue, 5 Oct 2021 11:24:34 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6887C061749 for ; Tue, 5 Oct 2021 08:22:43 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id 133so20112207pgb.1 for ; Tue, 05 Oct 2021 08:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jsoEJt9R8crAH2RcsfBnQLCdcmXo4iVFPCHH8skN9hQ=; b=Ed27JI5WdcMBjzCmHglgYbPkFapHRW8VivzST0erYb/L/PV6Fx0rpTBNDt1223jRVb eQ5IVgSRDi5VCqGDiJM5A7rbcPMvwg6w1jg0wDhDNxogy7g8tXHb5gAQu3MkQZ4aTk9Q D+35shvAdiTeBDH9W72MNR7F3tUnMUT8t+zTm8lCHdonVdqfrCyFpDQ97vP6AwGRNn/X GOqBrTVYIjZiBhdOV7etEqYr4+lx5qlCy7z4mzvugVDQwWWAnXWWM9Dac9u4kMeqF4o0 q66/1KN+gVVuBQ71H+9jz7Qi8kNlcIq5g+ueK+T83d6rxeradLUvtNWie9PUJyUcAjyk VesA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jsoEJt9R8crAH2RcsfBnQLCdcmXo4iVFPCHH8skN9hQ=; b=Hi7CUDBy7GKODqUNE5YVHPB7vl8uDT0ePfVMJ64W3z8nso5/ONLB6KWXvpk0vyHZK+ alLqEjKAbTZOlE00UT/t0aWmpzq/E6EqgN+IKoZCSqDua0QcfUOG5V2vOo7Bp+Hnd1z8 SYNA2kRE+h649rmgiETCglq+rtqG/rI1D5ykuGeOjC+FDm3ttVeKBMaOuoZv9vDPo5D1 CVbMGWQ/mJyInmvyOqyaLY+aEfb1s7kD562Fvt70DuHUBsB77Aw8qbnbVI/3UyK98psH P1zQ29/ePYV9EByzCMadjtAo9yWkG8r056E3jsmzy8jnjztf4x+hqRSJmO+T0gkBeG+n 9XaA== X-Gm-Message-State: AOAM5306zSlIKsrU8b3xhpMaGLIXYmF+JzCsAPH+yNFSIhmZ6tKhpwSC POe596pe9Ur0EAU2NMdQxk0ugA== X-Google-Smtp-Source: ABdhPJyd+BrY951cMRvWU+Hdnw02yUD1081dLTCog2uFgukEdDRDWflW+t6MGsO3nWUcqCgRuybMcw== X-Received: by 2002:a62:b50d:0:b0:44b:b81f:a956 with SMTP id y13-20020a62b50d000000b0044bb81fa956mr30655368pfe.27.1633447363159; Tue, 05 Oct 2021 08:22:43 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id z2sm6907837pfe.210.2021.10.05.08.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 08:22:42 -0700 (PDT) Date: Tue, 5 Oct 2021 15:22:39 +0000 From: Sean Christopherson To: Oliver Upton Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Paolo Bonzini , Marc Zyngier , Peter Shier , Jim Mattson , David Matlack , Ricardo Koller , Jing Zhang , Raghavendra Rao Anata , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, Andrew Jones , Will Deacon , Catalin Marinas Subject: Re: [PATCH v8 7/7] KVM: x86: Expose TSC offset controls to userspace Message-ID: References: <20210916181538.968978-1-oupton@google.com> <20210916181538.968978-8-oupton@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210916181538.968978-8-oupton@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Sep 16, 2021, Oliver Upton wrote: > +static int kvm_arch_tsc_get_attr(struct kvm_vcpu *vcpu, > + struct kvm_device_attr *attr) > +{ > + u64 __user *uaddr = (u64 __user *)attr->addr; ... > +static int kvm_arch_tsc_set_attr(struct kvm_vcpu *vcpu, > + struct kvm_device_attr *attr) > +{ > + u64 __user *uaddr = (u64 __user *)attr->addr; These casts break 32-bit builds because of truncating attr->addr from 64-bit int to a 32-bit pointer. The address should also be checked to verify bits 63:32 are not set on 32-bit kernels. arch/x86/kvm/x86.c: In function ‘kvm_arch_tsc_get_attr’: arch/x86/kvm/x86.c:4947:22: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 4947 | u64 __user *uaddr = (u64 __user *)attr->addr; | ^ arch/x86/kvm/x86.c: In function ‘kvm_arch_tsc_set_attr’: arch/x86/kvm/x86.c:4967:22: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 4967 | u64 __user *uaddr = (u64 __user *)attr->addr; | ^ Not sure if there's a more elegant approach than casts galore? diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 8e5e462ffd65..3930e5dcdf0e 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -4944,9 +4944,12 @@ static int kvm_arch_tsc_has_attr(struct kvm_vcpu *vcpu, static int kvm_arch_tsc_get_attr(struct kvm_vcpu *vcpu, struct kvm_device_attr *attr) { - u64 __user *uaddr = (u64 __user *)attr->addr; + u64 __user *uaddr = (u64 __user *)(unsigned long)attr->addr; int r; + if ((u64)(unsigned long)uaddr != attr->addr) + return -EFAULT; + switch (attr->attr) { case KVM_VCPU_TSC_OFFSET: r = -EFAULT; @@ -4964,10 +4967,13 @@ static int kvm_arch_tsc_get_attr(struct kvm_vcpu *vcpu, static int kvm_arch_tsc_set_attr(struct kvm_vcpu *vcpu, struct kvm_device_attr *attr) { - u64 __user *uaddr = (u64 __user *)attr->addr; + u64 __user *uaddr = (u64 __user *)(unsigned long)attr->addr; struct kvm *kvm = vcpu->kvm; int r; + if ((u64)(unsigned long)uaddr != attr->addr) + return -EFAULT; + switch (attr->attr) { case KVM_VCPU_TSC_OFFSET: { u64 offset, tsc, ns;