From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93AB2C433F5 for ; Tue, 5 Oct 2021 19:27:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D4A961181 for ; Tue, 5 Oct 2021 19:27:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D4A961181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 850536E44F; Tue, 5 Oct 2021 19:27:03 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CD2B6E44F; Tue, 5 Oct 2021 19:27:02 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="225729812" X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="225729812" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 12:27:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="458176402" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga002.jf.intel.com with SMTP; 05 Oct 2021 12:26:56 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 05 Oct 2021 22:26:55 +0300 Date: Tue, 5 Oct 2021 22:26:55 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Dan Carpenter Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Lucas De Marchi , Imre Deak , =?iso-8859-1?Q?Jos=E9?= Roberto de Souza , Matt Roper , Dave Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org Message-ID: References: <20211004103737.GC25015@kili> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211004103737.GC25015@kili> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915/tc: Delete bogus NULL check in intel_ddi_encoder_destroy() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Oct 04, 2021 at 01:37:37PM +0300, Dan Carpenter wrote: > The "digi_port" pointer can't be NULL and we have already dereferenced > it so checking for NULL is not necessary. Delete the check. > > Signed-off-by: Dan Carpenter Thanks. Applied to drm-intel-next. > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 51d07e9af9f3..b9c6eb13804f 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -4025,8 +4025,7 @@ static void intel_ddi_encoder_destroy(struct drm_encoder *encoder) > intel_display_power_flush_work(i915); > > drm_encoder_cleanup(encoder); > - if (dig_port) > - kfree(dig_port->hdcp_port_data.streams); > + kfree(dig_port->hdcp_port_data.streams); > kfree(dig_port); > } > > -- > 2.20.1 -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4FBAC433EF for ; Tue, 5 Oct 2021 19:51:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C541A61371 for ; Tue, 5 Oct 2021 19:51:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235224AbhJETwx (ORCPT ); Tue, 5 Oct 2021 15:52:53 -0400 Received: from mga05.intel.com ([192.55.52.43]:23709 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbhJETwx (ORCPT ); Tue, 5 Oct 2021 15:52:53 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="312041786" X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="312041786" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 12:27:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="458176402" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga002.jf.intel.com with SMTP; 05 Oct 2021 12:26:56 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 05 Oct 2021 22:26:55 +0300 Date: Tue, 5 Oct 2021 22:26:55 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Dan Carpenter Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Lucas De Marchi , Imre Deak , =?iso-8859-1?Q?Jos=E9?= Roberto de Souza , Matt Roper , Dave Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm/i915/tc: Delete bogus NULL check in intel_ddi_encoder_destroy() Message-ID: References: <20211004103737.GC25015@kili> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211004103737.GC25015@kili> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Mon, Oct 04, 2021 at 01:37:37PM +0300, Dan Carpenter wrote: > The "digi_port" pointer can't be NULL and we have already dereferenced > it so checking for NULL is not necessary. Delete the check. > > Signed-off-by: Dan Carpenter Thanks. Applied to drm-intel-next. > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 51d07e9af9f3..b9c6eb13804f 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -4025,8 +4025,7 @@ static void intel_ddi_encoder_destroy(struct drm_encoder *encoder) > intel_display_power_flush_work(i915); > > drm_encoder_cleanup(encoder); > - if (dig_port) > - kfree(dig_port->hdcp_port_data.streams); > + kfree(dig_port->hdcp_port_data.streams); > kfree(dig_port); > } > > -- > 2.20.1 -- Ville Syrjälä Intel