From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 1/2] io_uring: fail iopoll links if can't retry
Date: Mon, 18 Oct 2021 08:00:43 +0200 [thread overview]
Message-ID: <YW0Ni7BxHaJQsmSn@kroah.com> (raw)
In-Reply-To: <ff66f584ff352b94ef0f5cb4188da609834fe173.1634501363.git.asml.silence@gmail.com>
On Sun, Oct 17, 2021 at 08:30:55PM +0000, Pavel Begunkov wrote:
> If io_rw_should_reissue() fails in iopoll path and we can't reissue we
> fail the request. Don't forget to also mark it as failed, so links are
> broken.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> fs/io_uring.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 0d7613c7355c..40b1697e7354 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -2687,6 +2687,7 @@ static void io_complete_rw_iopoll(struct kiocb *kiocb, long res, long res2)
> req->flags |= REQ_F_REISSUE;
> return;
> }
> + req_set_fail(req);
> req->result = res;
> }
>
> --
> 2.33.1
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2021-10-18 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 20:33 [PATCH 0/2] two small fixes Pavel Begunkov
2021-10-17 20:30 ` [PATCH 1/2] io_uring: fail iopoll links if can't retry Pavel Begunkov
2021-10-17 20:33 ` Pavel Begunkov
2021-10-18 6:00 ` Greg KH [this message]
2021-10-17 20:33 ` [PATCH 2/2] io_uring: fix async_data checks for msg setup Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW0Ni7BxHaJQsmSn@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=asml.silence@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.