All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated
Date: Mon, 18 Oct 2021 10:10:43 +0200	[thread overview]
Message-ID: <YW0sA/isJebL7PHu@platinum> (raw)
In-Reply-To: <a779f5da-0875-76b6-be93-500eedba91eb@oktetlabs.ru>

Hi Andrew,

On Sat, Oct 16, 2021 at 10:50:50AM +0300, Andrew Rybchenko wrote:
> On 10/15/21 10:24 PM, Olivier Matz wrote:
> > The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are
> > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated
> > VLAN flags") (2017). But they were not using the RTE_DEPRECATED
> > macro, because it did not exist at this time. Add it, and replace
> > usage of these flags.
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> I'd remove these flags completely. 4 years is definitely
> enough. Yes, I realize that because of missing
> RTE_DEPRECATED markup users were not warning on build.

I kept them because David pointed me that these flags are still used by
other projects. Adding an explicit RTE_DEPRECATED() would prevent this,
and... it doesn't bother to add one more year :)

Thank you for the review.

  parent reply	other threads:[~2021-10-18  8:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 21:48 [dpdk-dev] [PATCH 0/3] mbuf: offload flags namespace Olivier Matz
2021-09-29 21:48 ` [dpdk-dev] [PATCH 1/3] mbuf: remove deprecated offload flags Olivier Matz
2021-10-04  8:29   ` David Marchand
2021-10-04  9:46     ` Olivier Matz
2021-09-29 21:48 ` [dpdk-dev] [PATCH 2/3] cocci: add cocci script to rename mbuf " Olivier Matz
2021-09-29 21:48 ` [dpdk-dev] [PATCH 3/3] mbuf: add rte prefix to " Olivier Matz
2021-10-15 19:24 ` [dpdk-dev] [PATCH v2 0/4] mbuf: offload flags namespace Olivier Matz
2021-10-15 19:24   ` [dpdk-dev] [PATCH v2 1/4] mbuf: remove duplicate definition of cksum offload flags Olivier Matz
2021-10-16  7:47     ` Andrew Rybchenko
2021-10-15 19:24   ` [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated Olivier Matz
2021-10-16  7:50     ` Andrew Rybchenko
2021-10-17 14:46       ` Ajit Khaparde
2021-10-18  8:10       ` Olivier Matz [this message]
2021-10-18 11:15         ` Somnath Kotur
2021-10-15 19:24   ` [dpdk-dev] [PATCH v2 3/4] cocci: add cocci script to rename mbuf offload flags Olivier Matz
2021-10-15 19:24   ` [dpdk-dev] [PATCH v2 4/4] mbuf: add rte prefix to " Olivier Matz
2021-10-16  7:57     ` Andrew Rybchenko
2021-10-17 14:45       ` Ajit Khaparde
2021-10-18 11:15         ` Somnath Kotur
2021-10-24 11:43   ` [dpdk-dev] [PATCH v2 0/4] mbuf: offload flags namespace David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YW0sA/isJebL7PHu@platinum \
    --to=olivier.matz@6wind.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.