From: Olivier Matz <olivier.matz@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Dmitry Kozlyuk <dkozlyuk@nvidia.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ray Kinsella <mdr@ashroe.eu>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH] mempool: accept user flags only
Date: Mon, 18 Oct 2021 10:35:57 +0200 [thread overview]
Message-ID: <YW0x7S8EBA5bhAyO@platinum> (raw)
In-Reply-To: <20211018082635.2054-1-david.marchand@redhat.com>
On Mon, Oct 18, 2021 at 10:26:35AM +0200, David Marchand wrote:
> As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated
> internally.
> This flag is not supposed to be requested from an application and would
> probably result in an incorrect behavior if an application did pass it.
>
> Other internal flags may be introduced later.
>
> Rework the check and export a mask of valid user flags for use in the
> unit test.
>
> Fixes: b240af8b10f9 ("mempool: enforce valid flags at creation")
>
> Reported-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2021-10-18 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 8:26 [dpdk-dev] [PATCH] mempool: accept user flags only David Marchand
2021-10-18 8:35 ` Olivier Matz [this message]
2021-10-20 7:53 ` David Marchand
2021-10-18 8:37 ` Andrew Rybchenko
2021-10-18 8:58 ` Olivier Matz
2021-10-18 9:05 ` Andrew Rybchenko
2021-10-18 12:06 ` David Marchand
2021-10-18 14:51 ` Andrew Rybchenko
2021-10-19 13:42 ` David Marchand
2021-10-19 18:17 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW0x7S8EBA5bhAyO@platinum \
--to=olivier.matz@6wind.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.