From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82133C433EF for ; Mon, 18 Oct 2021 18:08:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6604160F48 for ; Mon, 18 Oct 2021 18:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231956AbhJRSKr (ORCPT ); Mon, 18 Oct 2021 14:10:47 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:57618 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231590AbhJRSKr (ORCPT ); Mon, 18 Oct 2021 14:10:47 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E00C28C6; Mon, 18 Oct 2021 20:08:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1634580515; bh=UgDligBdkBJSa+psgu7m13DMpVB69NkjDnaxfX8vpAo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hbuxFj6IZRSym2HpPuqe+mV3XB0gclh78Ke2o65+78j2eWvCpGE+na4N5A9wuk3QR +/P6gpJeiMPaTb3QNLC6xlBTyFxi0wOBV/n6Ax+xsrjOonbnCmO3u55KW1AaN4BHT5 MHxgvWZsM0J6xLS5clVk7lUbmWx6hT7xtHsX/50M= Date: Mon, 18 Oct 2021 21:08:17 +0300 From: Laurent Pinchart To: Marek Vasut Cc: dri-devel@lists.freedesktop.org, Rob Herring , Sam Ravnborg , devicetree@vger.kernel.org Subject: Re: [PATCH v5 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select Message-ID: References: <20211017001204.299940-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211017001204.299940-1-marex@denx.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, Thank you for the patch. On Sun, Oct 17, 2021 at 02:12:03AM +0200, Marek Vasut wrote: > The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to > select input pixel data sampling edge. Add DT property "pclk-sample", not > the same as the one used by display timings but rather the same as used by > media, to define the pixel data sampling edge. > > Signed-off-by: Marek Vasut > Cc: Laurent Pinchart > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: devicetree@vger.kernel.org > To: dri-devel@lists.freedesktop.org > --- > V4: New patch split from combined V3 > V5: Rebase on recent linux-next > --- > .../bindings/display/bridge/lvds-codec.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 1faae3e323a4..708de84ac138 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -79,6 +79,14 @@ properties: > - port@0 > - port@1 > > + pclk-sample: > + description: > + Data sampling on rising or falling edge. > + enum: > + - 0 # Falling edge > + - 1 # Rising edge > + default: 0 > + Shouldn't this be moved to the endpoint, the same way data-mapping is defined as an endpoint property ? > powerdown-gpios: > description: > The GPIO used to control the power down line of this device. > @@ -102,6 +110,16 @@ then: > properties: > data-mapping: false > > +if: > + not: > + properties: > + compatible: > + contains: > + const: lvds-encoder > +then: > + properties: > + pclk-sample: false > + > required: > - compatible > - ports -- Regards, Laurent Pinchart