From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, jani.nikula@intel.com,
Dave Airlie <airlied@redhat.com>
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: drop unused parameter to dpt pin
Date: Tue, 19 Oct 2021 11:14:36 +0300 [thread overview]
Message-ID: <YW5+bMUp6ZSUK5Bi@intel.com> (raw)
In-Reply-To: <20211017234106.2412994-4-airlied@gmail.com>
On Mon, Oct 18, 2021 at 09:41:05AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> The uses_fence isn't used.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fb_pin.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> index 0beb0aa33337..721a1477e8b1 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> @@ -18,7 +18,6 @@
> static struct i915_vma *
> intel_pin_fb_obj_dpt(struct drm_framebuffer *fb,
> const struct i915_ggtt_view *view,
> - bool uses_fence,
> unsigned long *out_flags,
> struct i915_address_space *vm)
> {
> @@ -236,7 +235,7 @@ int intel_plane_pin_fb(struct intel_plane_state *plane_state)
>
> plane_state->ggtt_vma = vma;
>
> - vma = intel_pin_fb_obj_dpt(fb, &plane_state->view.gtt, false,
> + vma = intel_pin_fb_obj_dpt(fb, &plane_state->view.gtt,
> &plane_state->flags, intel_fb->dpt_vm);
> if (IS_ERR(vma)) {
> intel_dpt_unpin(intel_fb->dpt_vm);
> --
> 2.25.4
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-10-19 8:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 23:41 [Intel-gfx] [PATCH 0/4] finish/rebase fbdev pin refactor Dave Airlie
2021-10-17 23:41 ` [Intel-gfx] [PATCH 1/4] drm/i915/display: refactor fbdev pin/unpin out into functions Dave Airlie
2021-10-19 8:34 ` Ville Syrjälä
2021-10-17 23:41 ` [Intel-gfx] [PATCH 2/4] drm/i915/display: move fbdev pin code into fb_pin Dave Airlie
2021-10-19 9:15 ` Ville Syrjälä
2021-10-17 23:41 ` [Intel-gfx] [PATCH 3/4] drm/i915/display: drop unused parameter to dpt pin Dave Airlie
2021-10-19 8:14 ` Ville Syrjälä [this message]
2021-10-17 23:41 ` [Intel-gfx] [PATCH 4/4] drm/i915/display: drop some unused includes Dave Airlie
2021-10-19 8:24 ` Ville Syrjälä
2021-10-18 0:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for finish/rebase fbdev pin refactor Patchwork
2021-10-18 0:01 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-10-18 0:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-18 1:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW5+bMUp6ZSUK5Bi@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.