From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0551EC433F5 for ; Fri, 8 Oct 2021 20:49:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB98361040 for ; Fri, 8 Oct 2021 20:49:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243046AbhJHUvE (ORCPT ); Fri, 8 Oct 2021 16:51:04 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:35664 "EHLO mail-oi1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243021AbhJHUvE (ORCPT ); Fri, 8 Oct 2021 16:51:04 -0400 Received: by mail-oi1-f180.google.com with SMTP id n64so15365662oih.2; Fri, 08 Oct 2021 13:49:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=x/wNQQ1D/K6nlk72jDxw+T6dH+cLdjMzYx7cGW1fTl0=; b=AGkzDOHqpDp/ZKR9tPBqCNsjaMF8SAgzGZ2dvDDDbchD5fOz1XlQtd11ypPPtO8F/W GSDYl/wziutfwbznXXe73yYxzuyhGsGl2uLfVgGwr9IP9tP0pXxEhP8SY8pyp8+Bben0 kPjG4Y5R59+ifQgRyj5YK0cFxJs+krqw186S51L/LjhvW19B2aOjqsXvx3YlqvXuZEUd CMY+dxSvxTxu8ZQePswmsuHbfwmb1Vw1mdXAC2FTpBJtYaJeks9R1E279d+A3GGKAG+i pg3rTEiCDXKCS4Lr5XbWSVhxqeRzbR9CDbrLjsjQ5u1/huhgTDjiJAZwdYKJfgF9RsTf DVTg== X-Gm-Message-State: AOAM531Q4sG2hVBLIRyI5ePtoh9m9i1w5gzlu7Hkk1BfDWthCOjT3csN vQ7HvT1ISDpzc1offnVjGzRzaKRFOA== X-Google-Smtp-Source: ABdhPJx5jJzk17oSljHuYT7X7WHchncK/flnGkpdq9+Xrz5iTPDKOQNSkRkNIY0rJSxbdXDF/7Tldg== X-Received: by 2002:aca:ad16:: with SMTP id w22mr9134382oie.109.1633726148342; Fri, 08 Oct 2021 13:49:08 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id 12sm85039otg.69.2021.10.08.13.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 13:49:07 -0700 (PDT) Received: (nullmailer pid 3294594 invoked by uid 1000); Fri, 08 Oct 2021 20:49:06 -0000 Date: Fri, 8 Oct 2021 15:49:06 -0500 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Linus Walleij , devicetree@vger.kernel.org, Ray Jui , bcm-kernel-feedback-list@broadcom.com, Scott Branden , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 linux-pinctrl 1/2] Revert "dt-bindings: pinctrl: bcm4708-pinmux: rework binding to use syscon" Message-ID: References: <20211008153939.19685-1-zajec5@gmail.com> <1633722536.868012.3211952.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Oct 08, 2021 at 10:08:46PM +0200, Rafał Miłecki wrote: > On 08.10.2021 21:48, Rob Herring wrote: > > On Fri, 08 Oct 2021 17:39:38 +0200, Rafał Miłecki wrote: > > > From: Rafał Miłecki > > > > > > This reverts commit 2ae80900f239484069569380e1fc4340fd6e0089. > > > > > > My rework was unneeded & wrong. It replaced a clear & correct "reg" > > > property usage with a custom "offset" one. > > > > > > Back then I didn't understand how to properly handle CRU block binding. > > > I heard / read about syscon and tried to use it in a totally invalid > > > way. That change also missed Rob's review (obviously). > > > > > > Northstar's pin controller is a simple consistent hardware block that > > > can be cleanly mapped using a 0x24 long reg space. > > > > > > Since the rework commit there wasn't any follow up modifying in-kernel > > > DTS files to use the new binding. Broadcom also isn't known to use that > > > bugged binding. There is close to zero chance this revert may actually > > > cause problems / regressions. > > > > > > This commit is a simple revert. Example binding may (should) be updated > > > / cleaned up but that can be handled separately. > > > > > > Signed-off-by: Rafał Miłecki > > > --- > > > V2: Update brcm,cru.yaml to avoid new yamllint warnings/errors > > > --- > > > .../devicetree/bindings/mfd/brcm,cru.yaml | 11 +++++---- > > > .../bindings/pinctrl/brcm,ns-pinmux.yaml | 23 +++++++++++-------- > > > 2 files changed, 19 insertions(+), 15 deletions(-) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.example.dt.yaml: cru@1800c100: $nodename:0: 'cru@1800c100' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/simple-bus.yaml > > It's warning we already have and not something introduced by this > revert. We don't allow warnings, so you're saying this one was warning before? > As a revert this commit should introduce as little non-revert changes > as possible. I'm planning to improve that example later in a separated > commit. You have to fix the warning as part of this series. > > Can you take a look at this commit despite your bot warning, please? If 'CRU' is a hardware block, then I don't think most of the revert is right to use 'simple-bus'. If you want to just replace 'offset' with 'reg', then I'd be happy to see that. I've been pushing child nodes of syscons in that direction. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED63EC433F5 for ; Fri, 8 Oct 2021 20:50:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B18BB60EFF for ; Fri, 8 Oct 2021 20:50:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B18BB60EFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7kzennS0d3gyMR75zueztnt+1IGHRmQgTuHONApIix4=; b=UY3ouqpcUNKW3Z Rixg4A44hEvIdgZHRXfIVoKZxlvaufNPXqIucJRdRs5WgjepkQf9nMuo2wukIAwsUrEKZvRNo2BEl x0JiA/o42Y7yPLm7AKh1d8XTLiCQJvjvN0H0FL9gFDTG5vUD8J1ecyT0i0rEU+3YW/KX+IlMKligU dH7eOjJNsUJCrXJAiN7YBYJA2bi1EPHZUZTSA3dq06N06ZXiEXgHgMnP8PqgAjlDbU0r+dfwh2+ug /sjbqKtvnovHqDX5RUrGY7X4MRZDMuRY8P8HRV+dbnW+ajY7stLeY0SmV3qFCkqqyjHxM3JYThx0A YnxhuDGaF07khTOaaWNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYwnp-00489l-NB; Fri, 08 Oct 2021 20:49:13 +0000 Received: from mail-oi1-f179.google.com ([209.85.167.179]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYwnl-00488s-6u for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 20:49:11 +0000 Received: by mail-oi1-f179.google.com with SMTP id z126so1035481oiz.12 for ; Fri, 08 Oct 2021 13:49:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=x/wNQQ1D/K6nlk72jDxw+T6dH+cLdjMzYx7cGW1fTl0=; b=FBRgd8TQ1ev86uTmc8syAYkcA8T+WauiuYgdjs5kRXVbWt7z2k+y9WNVmhgOWEbLwl 7RrW9MdGf2FF8FAzzgtKVqpPbZcNFVUFgP8oPIgul5i8lNLI7b48qx6J8kDCY3HgMnNF ygef9VSSq84YCQ83R5YxXzjDXXalbxAIUqc8yHmZM0gbfAKZtJh3Ah3sp/0L1g3nwkDU Zndz4dCRDiMlO/kH4ZCI85wAdSXhBTnYwhJmUyr6tZiZuLV6J4lqc1YI0+U4hqwdl2RE 3PyPPL3p9Vo8AaV4PC7MWvvXsU82alE07Wlj72XtLc/5+6tF7hNpv9ftrHtdAPBwYZja M/DQ== X-Gm-Message-State: AOAM532QyDX+n9Bo1+JtHmsVPwFZxjWChWw7aKVvFKwD44iXTwxTD+yr ozw+dIjq0FXxwaufQ14Oqw== X-Google-Smtp-Source: ABdhPJx5jJzk17oSljHuYT7X7WHchncK/flnGkpdq9+Xrz5iTPDKOQNSkRkNIY0rJSxbdXDF/7Tldg== X-Received: by 2002:aca:ad16:: with SMTP id w22mr9134382oie.109.1633726148342; Fri, 08 Oct 2021 13:49:08 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id 12sm85039otg.69.2021.10.08.13.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 13:49:07 -0700 (PDT) Received: (nullmailer pid 3294594 invoked by uid 1000); Fri, 08 Oct 2021 20:49:06 -0000 Date: Fri, 8 Oct 2021 15:49:06 -0500 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Linus Walleij , devicetree@vger.kernel.org, Ray Jui , bcm-kernel-feedback-list@broadcom.com, Scott Branden , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 linux-pinctrl 1/2] Revert "dt-bindings: pinctrl: bcm4708-pinmux: rework binding to use syscon" Message-ID: References: <20211008153939.19685-1-zajec5@gmail.com> <1633722536.868012.3211952.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_134909_274847_8D6AF122 X-CRM114-Status: GOOD ( 29.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBPY3QgMDgsIDIwMjEgYXQgMTA6MDg6NDZQTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IE9uIDA4LjEwLjIwMjEgMjE6NDgsIFJvYiBIZXJyaW5nIHdyb3RlOgo+ID4gT24g RnJpLCAwOCBPY3QgMjAyMSAxNzozOTozOCArMDIwMCwgUmFmYcWCIE1pxYJlY2tpIHdyb3RlOgo+ ID4gPiBGcm9tOiBSYWZhxYIgTWnFgmVja2kgPHJhZmFsQG1pbGVja2kucGw+Cj4gPiA+IAo+ID4g PiBUaGlzIHJldmVydHMgY29tbWl0IDJhZTgwOTAwZjIzOTQ4NDA2OTU2OTM4MGUxZmM0MzQwZmQ2 ZTAwODkuCj4gPiA+IAo+ID4gPiBNeSByZXdvcmsgd2FzIHVubmVlZGVkICYgd3JvbmcuIEl0IHJl cGxhY2VkIGEgY2xlYXIgJiBjb3JyZWN0ICJyZWciCj4gPiA+IHByb3BlcnR5IHVzYWdlIHdpdGgg YSBjdXN0b20gIm9mZnNldCIgb25lLgo+ID4gPiAKPiA+ID4gQmFjayB0aGVuIEkgZGlkbid0IHVu ZGVyc3RhbmQgaG93IHRvIHByb3Blcmx5IGhhbmRsZSBDUlUgYmxvY2sgYmluZGluZy4KPiA+ID4g SSBoZWFyZCAvIHJlYWQgYWJvdXQgc3lzY29uIGFuZCB0cmllZCB0byB1c2UgaXQgaW4gYSB0b3Rh bGx5IGludmFsaWQKPiA+ID4gd2F5LiBUaGF0IGNoYW5nZSBhbHNvIG1pc3NlZCBSb2IncyByZXZp ZXcgKG9idmlvdXNseSkuCj4gPiA+IAo+ID4gPiBOb3J0aHN0YXIncyBwaW4gY29udHJvbGxlciBp cyBhIHNpbXBsZSBjb25zaXN0ZW50IGhhcmR3YXJlIGJsb2NrIHRoYXQKPiA+ID4gY2FuIGJlIGNs ZWFubHkgbWFwcGVkIHVzaW5nIGEgMHgyNCBsb25nIHJlZyBzcGFjZS4KPiA+ID4gCj4gPiA+IFNp bmNlIHRoZSByZXdvcmsgY29tbWl0IHRoZXJlIHdhc24ndCBhbnkgZm9sbG93IHVwIG1vZGlmeWlu ZyBpbi1rZXJuZWwKPiA+ID4gRFRTIGZpbGVzIHRvIHVzZSB0aGUgbmV3IGJpbmRpbmcuIEJyb2Fk Y29tIGFsc28gaXNuJ3Qga25vd24gdG8gdXNlIHRoYXQKPiA+ID4gYnVnZ2VkIGJpbmRpbmcuIFRo ZXJlIGlzIGNsb3NlIHRvIHplcm8gY2hhbmNlIHRoaXMgcmV2ZXJ0IG1heSBhY3R1YWxseQo+ID4g PiBjYXVzZSBwcm9ibGVtcyAvIHJlZ3Jlc3Npb25zLgo+ID4gPiAKPiA+ID4gVGhpcyBjb21taXQg aXMgYSBzaW1wbGUgcmV2ZXJ0LiBFeGFtcGxlIGJpbmRpbmcgbWF5IChzaG91bGQpIGJlIHVwZGF0 ZWQKPiA+ID4gLyBjbGVhbmVkIHVwIGJ1dCB0aGF0IGNhbiBiZSBoYW5kbGVkIHNlcGFyYXRlbHku Cj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBSYWZhxYIgTWnFgmVja2kgPHJhZmFsQG1pbGVj a2kucGw+Cj4gPiA+IC0tLQo+ID4gPiBWMjogVXBkYXRlIGJyY20sY3J1LnlhbWwgdG8gYXZvaWQg bmV3IHlhbWxsaW50IHdhcm5pbmdzL2Vycm9ycwo+ID4gPiAtLS0KPiA+ID4gICAuLi4vZGV2aWNl dHJlZS9iaW5kaW5ncy9tZmQvYnJjbSxjcnUueWFtbCAgICAgfCAxMSArKysrKy0tLS0KPiA+ID4g ICAuLi4vYmluZGluZ3MvcGluY3RybC9icmNtLG5zLXBpbm11eC55YW1sICAgICAgfCAyMyArKysr KysrKysrKy0tLS0tLS0tCj4gPiA+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCsp LCAxNSBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiAKPiA+IE15IGJvdCBmb3VuZCBlcnJvcnMgcnVu bmluZyAnbWFrZSBEVF9DSEVDS0VSX0ZMQUdTPS1tIGR0X2JpbmRpbmdfY2hlY2snCj4gPiBvbiB5 b3VyIHBhdGNoIChEVF9DSEVDS0VSX0ZMQUdTIGlzIG5ldyBpbiB2NS4xMyk6Cj4gPiAKPiA+IHlh bWxsaW50IHdhcm5pbmdzL2Vycm9yczoKPiA+IAo+ID4gZHRzY2hlbWEvZHRjIHdhcm5pbmdzL2Vy cm9yczoKPiA+IC9idWlsZHMvcm9iaGVycmluZy9saW51eC1kdC1yZXZpZXcvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BpbmN0cmwvYnJjbSxucy1waW5tdXguZXhhbXBsZS5kdC55 YW1sOiBjcnVAMTgwMGMxMDA6ICRub2RlbmFtZTowOiAnY3J1QDE4MDBjMTAwJyBkb2VzIG5vdCBt YXRjaCAnXihbYS16XVthLXowLTlcXC1dKy1idXN8YnVzfHNvY3xheGl8YWhifGFwYikoQFswLTlh LWZdKyk/JCcKPiA+IAlGcm9tIHNjaGVtYTogL3Vzci9sb2NhbC9saWIvcHl0aG9uMy44L2Rpc3Qt cGFja2FnZXMvZHRzY2hlbWEvc2NoZW1hcy9zaW1wbGUtYnVzLnlhbWwKPiAKPiBJdCdzIHdhcm5p bmcgd2UgYWxyZWFkeSBoYXZlIGFuZCBub3Qgc29tZXRoaW5nIGludHJvZHVjZWQgYnkgdGhpcwo+ IHJldmVydC4KCldlIGRvbid0IGFsbG93IHdhcm5pbmdzLCBzbyB5b3UncmUgc2F5aW5nIHRoaXMg b25lIHdhcyB3YXJuaW5nIGJlZm9yZT8KCj4gQXMgYSByZXZlcnQgdGhpcyBjb21taXQgc2hvdWxk IGludHJvZHVjZSBhcyBsaXR0bGUgbm9uLXJldmVydCBjaGFuZ2VzCj4gYXMgcG9zc2libGUuIEkn bSBwbGFubmluZyB0byBpbXByb3ZlIHRoYXQgZXhhbXBsZSBsYXRlciBpbiBhIHNlcGFyYXRlZAo+ IGNvbW1pdC4KCllvdSBoYXZlIHRvIGZpeCB0aGUgd2FybmluZyBhcyBwYXJ0IG9mIHRoaXMgc2Vy aWVzLgoKPiAKPiBDYW4geW91IHRha2UgYSBsb29rIGF0IHRoaXMgY29tbWl0IGRlc3BpdGUgeW91 ciBib3Qgd2FybmluZywgcGxlYXNlPwoKSWYgJ0NSVScgaXMgYSBoYXJkd2FyZSBibG9jaywgdGhl biBJIGRvbid0IHRoaW5rIG1vc3Qgb2YgdGhlIHJldmVydCBpcyAKcmlnaHQgdG8gdXNlICdzaW1w bGUtYnVzJy4gCgpJZiB5b3Ugd2FudCB0byBqdXN0IHJlcGxhY2UgJ29mZnNldCcgd2l0aCAncmVn JywgdGhlbiBJJ2QgYmUgaGFwcHkgdG8gCnNlZSB0aGF0LiBJJ3ZlIGJlZW4gcHVzaGluZyBjaGls ZCBub2RlcyBvZiBzeXNjb25zIGluIHRoYXQgZGlyZWN0aW9uLgoKUm9iCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==