From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70ACEC433F5 for ; Sun, 10 Oct 2021 13:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45AE9610C7 for ; Sun, 10 Oct 2021 13:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232670AbhJJNM1 (ORCPT ); Sun, 10 Oct 2021 09:12:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:60260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231936AbhJJNM1 (ORCPT ); Sun, 10 Oct 2021 09:12:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F1F6A61076; Sun, 10 Oct 2021 13:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633871428; bh=ofLwMdJPr8c/nsbZa56UKm1KuyjPyG9jWpmTcjItIHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FlVt5E5hCUuYIzb0anOPd40p3AUJyGYcdEiISlWEgBLmKbO3UmSM8vhIz22loHgnj fYGaBiGQC9nK1cLDkpyuwLwd9gTo48LdQ1wcM26g+fEAH7/tzGUCpu9wPqmSKgwltr +nGSMitrNMxUeVIrfQLW7Nnhm8suc7dBctswbzDE= Date: Sun, 10 Oct 2021 15:10:25 +0200 From: Greg Kroah-Hartman To: Joel Stanley Cc: Neal Liu , Alan Stern , Tony Prisk , linux-usb@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , Tao Ren , BMC-SW , OpenBMC Maillist , Bruce Mitchell , Eddie James Subject: Re: [PATCH v4] usb: ehci: handshake CMD_RUN instead of STS_HALT Message-ID: References: <20210910073619.26095-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Oct 06, 2021 at 01:27:02AM +0000, Joel Stanley wrote: > Hi Greg, > > On Fri, 10 Sept 2021 at 07:38, Neal Liu wrote: > > > > For Aspeed, HCHalted status depends on not only Run/Stop but also > > ASS/PSS status. > > Handshake CMD_RUN on startup instead. > > > > Signed-off-by: Neal Liu > > Acked-by: Alan Stern > > Reviewed-by: Tao Ren > > Tested-by: Tao Ren > > Has this one gone in? If not, here's some tags: > > Reviewed-by: Joel Stanley > > It also needs to go to stable: > > Cc: stable@vger.kernel.org > Fixes: 280a9045bb18 ("ehci: fix EHCI host controller initialization sequence") This is already in my tree, but waiting until 5.16-rc1, sorry. You can see it at commit 7f2d73788d90 ("usb: ehci: handshake CMD_RUN instead of STS_HALT") in linux-next. I'll try to remember to queue it up in stable after it hits Linus's tree. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEC8C433EF for ; Sun, 10 Oct 2021 13:11:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9807C60F92 for ; Sun, 10 Oct 2021 13:11:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9807C60F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HS2PG0qMjz2ynL for ; Mon, 11 Oct 2021 00:11:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=FlVt5E5h; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=FlVt5E5h; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HS2NT1zn4z2xtv for ; Mon, 11 Oct 2021 00:10:32 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id F1F6A61076; Sun, 10 Oct 2021 13:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633871428; bh=ofLwMdJPr8c/nsbZa56UKm1KuyjPyG9jWpmTcjItIHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FlVt5E5hCUuYIzb0anOPd40p3AUJyGYcdEiISlWEgBLmKbO3UmSM8vhIz22loHgnj fYGaBiGQC9nK1cLDkpyuwLwd9gTo48LdQ1wcM26g+fEAH7/tzGUCpu9wPqmSKgwltr +nGSMitrNMxUeVIrfQLW7Nnhm8suc7dBctswbzDE= Date: Sun, 10 Oct 2021 15:10:25 +0200 From: Greg Kroah-Hartman To: Joel Stanley Subject: Re: [PATCH v4] usb: ehci: handshake CMD_RUN instead of STS_HALT Message-ID: References: <20210910073619.26095-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW , Bruce Mitchell , Neal Liu , OpenBMC Maillist , linux-usb@vger.kernel.org, Eddie James , Linux Kernel Mailing List , Tony Prisk , Alan Stern , Tao Ren , Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Wed, Oct 06, 2021 at 01:27:02AM +0000, Joel Stanley wrote: > Hi Greg, > > On Fri, 10 Sept 2021 at 07:38, Neal Liu wrote: > > > > For Aspeed, HCHalted status depends on not only Run/Stop but also > > ASS/PSS status. > > Handshake CMD_RUN on startup instead. > > > > Signed-off-by: Neal Liu > > Acked-by: Alan Stern > > Reviewed-by: Tao Ren > > Tested-by: Tao Ren > > Has this one gone in? If not, here's some tags: > > Reviewed-by: Joel Stanley > > It also needs to go to stable: > > Cc: stable@vger.kernel.org > Fixes: 280a9045bb18 ("ehci: fix EHCI host controller initialization sequence") This is already in my tree, but waiting until 5.16-rc1, sorry. You can see it at commit 7f2d73788d90 ("usb: ehci: handshake CMD_RUN instead of STS_HALT") in linux-next. I'll try to remember to queue it up in stable after it hits Linus's tree. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54039C433F5 for ; Sun, 10 Oct 2021 13:12:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16F5F60F92 for ; Sun, 10 Oct 2021 13:12:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 16F5F60F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Slx+4yP2SMFC6MWe6OmeystzotSvXm4YmU8Ugl1tt1w=; b=sUSvKMUQHfJAUc sZI9eeQNe6vtrAn4P92+fHZBr2GMxcwApW6tHJ8sCtMXUywnjnXPonOW1j5SQR5f3gxkfsgoE6K5E lxeI3LzZfkM1IdaUT+qky3ofhDM9bIVchyMg4QCe6dBdykPUmXF7xpLBFASiATZcGAS5Hip/fuuSU 2vt8UUWgk8YR5UeAtpT1T5YKWicklZz2UM2QhGpFixXo/HhVOZAsrBhDLp9cSWACEst5pPCTbV4LN /g8CANvJ2gm5xgbdTRPMpfX5Wzqdagh0pJcGckxCIwIwlDHcTQvtSvsPhU6IhVgC/T2cYPnM11DNO 2jM+CiJrPI0YreBDbE0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZYb2-006pv3-H2; Sun, 10 Oct 2021 13:10:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZYaz-006pub-9H for linux-arm-kernel@lists.infradead.org; Sun, 10 Oct 2021 13:10:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id F1F6A61076; Sun, 10 Oct 2021 13:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633871428; bh=ofLwMdJPr8c/nsbZa56UKm1KuyjPyG9jWpmTcjItIHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FlVt5E5hCUuYIzb0anOPd40p3AUJyGYcdEiISlWEgBLmKbO3UmSM8vhIz22loHgnj fYGaBiGQC9nK1cLDkpyuwLwd9gTo48LdQ1wcM26g+fEAH7/tzGUCpu9wPqmSKgwltr +nGSMitrNMxUeVIrfQLW7Nnhm8suc7dBctswbzDE= Date: Sun, 10 Oct 2021 15:10:25 +0200 From: Greg Kroah-Hartman To: Joel Stanley Cc: Neal Liu , Alan Stern , Tony Prisk , linux-usb@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , Tao Ren , BMC-SW , OpenBMC Maillist , Bruce Mitchell , Eddie James Subject: Re: [PATCH v4] usb: ehci: handshake CMD_RUN instead of STS_HALT Message-ID: References: <20210910073619.26095-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211010_061029_365388_582CDFEE X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 06, 2021 at 01:27:02AM +0000, Joel Stanley wrote: > Hi Greg, > > On Fri, 10 Sept 2021 at 07:38, Neal Liu wrote: > > > > For Aspeed, HCHalted status depends on not only Run/Stop but also > > ASS/PSS status. > > Handshake CMD_RUN on startup instead. > > > > Signed-off-by: Neal Liu > > Acked-by: Alan Stern > > Reviewed-by: Tao Ren > > Tested-by: Tao Ren > > Has this one gone in? If not, here's some tags: > > Reviewed-by: Joel Stanley > > It also needs to go to stable: > > Cc: stable@vger.kernel.org > Fixes: 280a9045bb18 ("ehci: fix EHCI host controller initialization sequence") This is already in my tree, but waiting until 5.16-rc1, sorry. You can see it at commit 7f2d73788d90 ("usb: ehci: handshake CMD_RUN instead of STS_HALT") in linux-next. I'll try to remember to queue it up in stable after it hits Linus's tree. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel