From: Mike Rapoport <rppt@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>, Michal Hocko <mhocko@suse.com>,
Oscar Salvador <osalvador@suse.de>,
linux-doc@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/3] memory-hotplug.rst: fix two instances of "movablecore" that should be "movable_node"
Date: Mon, 11 Oct 2021 12:27:13 +0300 [thread overview]
Message-ID: <YWQDcROoBoreeiHZ@kernel.org> (raw)
In-Reply-To: <20211011082058.6076-2-david@redhat.com>
On Mon, Oct 11, 2021 at 10:20:56AM +0200, David Hildenbrand wrote:
> We really want to refer to the "movable_node" kernel command line
> parameter here.
>
> Fixes: ac3332c44767 ("memory-hotplug.rst: complete admin-guide overhaul")
> Signed-off-by: David Hildenbrand <david@redhat.com>
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> Documentation/admin-guide/mm/memory-hotplug.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst
> index 03dfbc925252..27d748cb6ee0 100644
> --- a/Documentation/admin-guide/mm/memory-hotplug.rst
> +++ b/Documentation/admin-guide/mm/memory-hotplug.rst
> @@ -166,7 +166,7 @@ Or alternatively::
> % echo 1 > /sys/devices/system/memory/memoryXXX/online
>
> The kernel will select the target zone automatically, usually defaulting to
> -``ZONE_NORMAL`` unless ``movablecore=1`` has been specified on the kernel
> +``ZONE_NORMAL`` unless ``movable_node`` has been specified on the kernel
> command line or if the memory block would intersect the ZONE_MOVABLE already.
>
> One can explicitly request to associate an offline memory block with
> @@ -393,7 +393,7 @@ command line parameters are relevant:
> ======================== =======================================================
> ``memhp_default_state`` configure auto-onlining by essentially setting
> ``/sys/devices/system/memory/auto_online_blocks``.
> -``movablecore`` configure automatic zone selection of the kernel. When
> +``movable_node`` configure automatic zone selection in the kernel. When
> set, the kernel will default to ZONE_MOVABLE, unless
> other zones can be kept contiguous.
> ======================== =======================================================
> --
> 2.31.1
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-10-11 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 8:20 [PATCH v2 0/3] memory-hotplug.rst: document the "auto-movable" online policy David Hildenbrand
2021-10-11 8:20 ` [PATCH v2 1/3] memory-hotplug.rst: fix two instances of "movablecore" that should be "movable_node" David Hildenbrand
2021-10-11 9:27 ` Mike Rapoport [this message]
2021-10-11 8:20 ` [PATCH v2 2/3] memory-hotplug.rst: fix wrong /sys/module/memory_hotplug/parameters/ path David Hildenbrand
2021-10-11 9:27 ` Mike Rapoport
2021-10-11 8:20 ` [PATCH v2 3/3] memory-hotplug.rst: document the "auto-movable" online policy David Hildenbrand
2021-10-11 9:31 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWQDcROoBoreeiHZ@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.