From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: vsementsov@virtuozzo.com, berrange@redhat.com,
libvir-list@redhat.com, eblake@redhat.com,
mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org,
pkrempa@redhat.com, marcandre.lureau@redhat.com,
jsnow@redhat.com, libguestfs@redhat.com
Subject: Re: [PATCH v2 2/5] qapi: Add feature flags to enum members
Date: Tue, 12 Oct 2021 12:41:27 +0200 [thread overview]
Message-ID: <YWVmV1gdJb66nN2+@redhat.com> (raw)
In-Reply-To: <20211009120944.2858887-3-armbru@redhat.com>
Am 09.10.2021 um 14:09 hat Markus Armbruster geschrieben:
> This is quite similar to commit 84ab008687 "qapi: Add feature flags to
> struct members", only for enums instead of structs.
>
> Special feature flag 'deprecated' is silently ignored there. This is
> okay only because it will be implemented shortly.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Should we have a test case for an invalid value for 'features'?
Kevin
next prev parent reply other threads:[~2021-10-12 11:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 12:09 [PATCH v2 0/5] qapi: Add feature flags to enum members Markus Armbruster
2021-10-09 12:09 ` [PATCH v2 1/5] qapi: Enable enum member introspection to show more than name Markus Armbruster
2021-10-11 18:37 ` Eric Blake
2021-10-12 10:08 ` Kevin Wolf
2021-10-21 7:45 ` Markus Armbruster
2021-10-09 12:09 ` [PATCH v2 2/5] qapi: Add feature flags to enum members Markus Armbruster
2021-10-12 10:41 ` Kevin Wolf [this message]
2021-10-21 8:48 ` Markus Armbruster
2021-10-09 12:09 ` [PATCH v2 3/5] qapi: Move compat policy from QObject to generic visitor Markus Armbruster
2021-10-09 12:09 ` [PATCH v2 4/5] qapi: Implement deprecated-input={reject, crash} for enum values Markus Armbruster
2021-10-11 18:53 ` [PATCH v2 4/5] qapi: Implement deprecated-input={reject,crash} " Eric Blake
2021-10-21 9:40 ` Markus Armbruster
2021-10-09 12:09 ` [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup Markus Armbruster
2021-10-11 18:58 ` Eric Blake
2021-10-12 10:52 ` Kevin Wolf
2021-10-21 9:47 ` Markus Armbruster
2021-10-12 12:39 ` [PATCH v2 0/5] qapi: Add feature flags to enum members Peter Krempa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWVmV1gdJb66nN2+@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=libguestfs@redhat.com \
--cc=libvir-list@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.