From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D26AC433EF for ; Tue, 12 Oct 2021 18:23:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F0D260E9C for ; Tue, 12 Oct 2021 18:23:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3F0D260E9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H0kMNLlbSxh0+CCgjuLlrL/WgJYp6rHBxCUJwGTtsV8=; b=zX8ImXe91Ryc4g V1hoPZ8jfpCd4GSQD/ZTdM10zjoCeMMaMAYJxiv7hrZjFxKWZiiteO4LNvBXb7lJq4ibfPPXIwep4 JMsZ03cokMc/TozEWDIFtlYM6VYzPEMAxEvYxO4U2ETPjpZOibnaOY4CKmyhlKY/C5PX5nBG7GAyj lfDM/S0MdwWD2BUOWW2ZIbtFQvq6ihsHOdO2IGxJpaoNngbgPlHVpv1jm4aekgISH0PhR7fq2f7n2 metiRJ1EdnlxCrs4CXw8k5BRk0ew3ZvGutMhH488cT9gq2Snrx00wUMk+CZLMhXJlaXViRGLb/UDB cgPoPMJhOxcIJ6l30vxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maMP4-00Dj7a-LS; Tue, 12 Oct 2021 18:21:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maMP0-00Dj6z-MB for linux-arm-kernel@lists.infradead.org; Tue, 12 Oct 2021 18:21:27 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 37ACB60D07; Tue, 12 Oct 2021 18:21:24 +0000 (UTC) Date: Tue, 12 Oct 2021 19:21:20 +0100 From: Catalin Marinas To: Kefeng Wang Cc: will@kernel.org, ryabinin.a.a@gmail.com, andreyknvl@gmail.com, dvyukov@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, elver@google.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v4 1/3] vmalloc: Choose a better start address in vm_area_register_early() Message-ID: References: <20210910053354.26721-1-wangkefeng.wang@huawei.com> <20210910053354.26721-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210910053354.26721-2-wangkefeng.wang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_112126_782150_29EFD2DC X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 10, 2021 at 01:33:52PM +0800, Kefeng Wang wrote: > There are some fixed locations in the vmalloc area be reserved > in ARM(see iotable_init()) and ARM64(see map_kernel()), but for > pcpu_page_first_chunk(), it calls vm_area_register_early() and > choose VMALLOC_START as the start address of vmap area which > could be conflicted with above address, then could trigger a > BUG_ON in vm_area_add_early(). > > Let's choose a suit start address by traversing the vmlist. > > Signed-off-by: Kefeng Wang Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AC5C433EF for ; Tue, 12 Oct 2021 18:21:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3618B60ED4 for ; Tue, 12 Oct 2021 18:21:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3618B60ED4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8FDAB900003; Tue, 12 Oct 2021 14:21:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ACEC900002; Tue, 12 Oct 2021 14:21:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C2A0900003; Tue, 12 Oct 2021 14:21:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 6BBB4900002 for ; Tue, 12 Oct 2021 14:21:30 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 259D982499B9 for ; Tue, 12 Oct 2021 18:21:30 +0000 (UTC) X-FDA: 78688603140.18.644C2F3 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf19.hostedemail.com (Postfix) with ESMTP id DD5F5B0000A7 for ; Tue, 12 Oct 2021 18:21:29 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 37ACB60D07; Tue, 12 Oct 2021 18:21:24 +0000 (UTC) Date: Tue, 12 Oct 2021 19:21:20 +0100 From: Catalin Marinas To: Kefeng Wang Cc: will@kernel.org, ryabinin.a.a@gmail.com, andreyknvl@gmail.com, dvyukov@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, elver@google.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v4 1/3] vmalloc: Choose a better start address in vm_area_register_early() Message-ID: References: <20210910053354.26721-1-wangkefeng.wang@huawei.com> <20210910053354.26721-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210910053354.26721-2-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DD5F5B0000A7 X-Stat-Signature: tsrs638pd9nrx7tw873oosi9uqqojwii Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf19.hostedemail.com: domain of cmarinas@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-HE-Tag: 1634062889-126640 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 10, 2021 at 01:33:52PM +0800, Kefeng Wang wrote: > There are some fixed locations in the vmalloc area be reserved > in ARM(see iotable_init()) and ARM64(see map_kernel()), but for > pcpu_page_first_chunk(), it calls vm_area_register_early() and > choose VMALLOC_START as the start address of vmap area which > could be conflicted with above address, then could trigger a > BUG_ON in vm_area_add_early(). > > Let's choose a suit start address by traversing the vmlist. > > Signed-off-by: Kefeng Wang Reviewed-by: Catalin Marinas