From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5FBC433EF for ; Wed, 13 Oct 2021 12:03:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E343610E5 for ; Wed, 13 Oct 2021 12:03:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232299AbhJMMFY (ORCPT ); Wed, 13 Oct 2021 08:05:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:55896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbhJMMFX (ORCPT ); Wed, 13 Oct 2021 08:05:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E007560EB4; Wed, 13 Oct 2021 12:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634126600; bh=6Lpra3ez8JWIpg3SdW3vfWuYRu+xZGQ3by9f1A53ShY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TE077WFAvKOf+ldex8I6AHVm2qgh3cbckzUT+koRTwIjsEVpPaAJSCb9hDWVT3kGg N3pqSyHto9aPTY6jsNFiYrduG8CjwfYXLjRtOmjltNttVgW+YNea6MgbXHM5s1KZw8 CXIQHzIA/7Q2QmKbnje49x5Io7JBxUvsqGdbXXSg= Date: Wed, 13 Oct 2021 14:03:18 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Felipe Balbi , Nathan Chancellor , Nick Desaulniers , Arnd Bergmann , Rikard Falkeborn , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] [RFC] usb: gadget: avoid unusual inline assembly Message-ID: References: <20210927123830.1278953-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210927123830.1278953-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Sep 27, 2021 at 02:38:20PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang does not understand the "mrc%?" syntax: > > drivers/usb/gadget/udc/pxa25x_udc.c:2330:11: error: invalid % escape in inline assembly string > > I don't understand it either, but removing the %? here gets it to build. > This is probably wrong and someone else should do a proper patch. > > Any suggestions? > > Signed-off-by: Arnd Bergmann > --- > drivers/usb/gadget/udc/pxa25x_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c > index a09ec1d826b2..52cdfd8212d6 100644 > --- a/drivers/usb/gadget/udc/pxa25x_udc.c > +++ b/drivers/usb/gadget/udc/pxa25x_udc.c > @@ -2325,7 +2325,7 @@ static int pxa25x_udc_probe(struct platform_device *pdev) > pr_info("%s: version %s\n", driver_name, DRIVER_VERSION); > > /* insist on Intel/ARM/XScale */ > - asm("mrc%? p15, 0, %0, c0, c0" : "=r" (chiprev)); > + asm("mrc p15, 0, %0, c0, c0" : "=r" (chiprev)); > if ((chiprev & CP15R0_VENDOR_MASK) != CP15R0_XSCALE_VALUE) { > pr_err("%s: not XScale!\n", driver_name); > return -ENODEV; > -- > 2.29.2 > Given that no one had any objections, I'll queue this up and see what breaks :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B99DC433F5 for ; Wed, 13 Oct 2021 12:50:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8F1B60C4B for ; Wed, 13 Oct 2021 12:50:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C8F1B60C4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cZ2C5PBPx4n7xJgdZhPG2dQE0hKbFILnB34gHnnvTVM=; b=D9yUNn7CPv2Ssv eIOMeZ/5koxDeyHC/sAJ3a8U47DNcReSbkwF/Bf7sDwKTRcqV8XCCzfDJVrjGtNrCPcXHhFeZFZ+Y fIR0GzmntGJIOIoqzXVhiLtsvU6sGQfYV/g5GRe19XMAc0sRucMth6kSkPuJBCqeMZk3m703y/uHb aMUcMJRwns17HumSXhFXem74+P1y2sXJA/xvhUpdqcBb8yGCoV0ucl/ijbX+yM3fZctq7ifR5QBBZ Ph68HEBDiaAWL+kqgzwpy8GHItzt09Zp/uVk3xcXkqb8zW49WtvyyxNTn5S/3xQ9OP8QKfBgx1og4 bpSI6NkhldYqrVKfc9RQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1madg7-00GfWZ-I0; Wed, 13 Oct 2021 12:48:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1macye-00GRiw-Te for linux-arm-kernel@lists.infradead.org; Wed, 13 Oct 2021 12:03:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E007560EB4; Wed, 13 Oct 2021 12:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634126600; bh=6Lpra3ez8JWIpg3SdW3vfWuYRu+xZGQ3by9f1A53ShY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TE077WFAvKOf+ldex8I6AHVm2qgh3cbckzUT+koRTwIjsEVpPaAJSCb9hDWVT3kGg N3pqSyHto9aPTY6jsNFiYrduG8CjwfYXLjRtOmjltNttVgW+YNea6MgbXHM5s1KZw8 CXIQHzIA/7Q2QmKbnje49x5Io7JBxUvsqGdbXXSg= Date: Wed, 13 Oct 2021 14:03:18 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Felipe Balbi , Nathan Chancellor , Nick Desaulniers , Arnd Bergmann , Rikard Falkeborn , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] [RFC] usb: gadget: avoid unusual inline assembly Message-ID: References: <20210927123830.1278953-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210927123830.1278953-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211013_050321_034611_76E68DCE X-CRM114-Status: GOOD ( 21.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 27, 2021 at 02:38:20PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang does not understand the "mrc%?" syntax: > > drivers/usb/gadget/udc/pxa25x_udc.c:2330:11: error: invalid % escape in inline assembly string > > I don't understand it either, but removing the %? here gets it to build. > This is probably wrong and someone else should do a proper patch. > > Any suggestions? > > Signed-off-by: Arnd Bergmann > --- > drivers/usb/gadget/udc/pxa25x_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c > index a09ec1d826b2..52cdfd8212d6 100644 > --- a/drivers/usb/gadget/udc/pxa25x_udc.c > +++ b/drivers/usb/gadget/udc/pxa25x_udc.c > @@ -2325,7 +2325,7 @@ static int pxa25x_udc_probe(struct platform_device *pdev) > pr_info("%s: version %s\n", driver_name, DRIVER_VERSION); > > /* insist on Intel/ARM/XScale */ > - asm("mrc%? p15, 0, %0, c0, c0" : "=r" (chiprev)); > + asm("mrc p15, 0, %0, c0, c0" : "=r" (chiprev)); > if ((chiprev & CP15R0_VENDOR_MASK) != CP15R0_XSCALE_VALUE) { > pr_err("%s: not XScale!\n", driver_name); > return -ENODEV; > -- > 2.29.2 > Given that no one had any objections, I'll queue this up and see what breaks :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel