All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "Colin King" <colin.king@canonical.com>,
	"Marc Zyngier" <maz@kernel.org>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] PCI: apple: Remove redundant initialization of pointer port_pdev
Date: Wed, 13 Oct 2021 10:06:20 -0400	[thread overview]
Message-ID: <YWbn3MoXwXZ/r4Hn@sunset> (raw)
In-Reply-To: <20211013134114.GC11036@lpieralisi>

Hi Lorenzo,

> > The pointer port_pdev is being initialized with a value that is never
> > read, it is being updated later on. The assignment is redundant and
> > can be removed.
> > 
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  drivers/pci/controller/pcie-apple.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Squashed into the commit it is fixing.

It seems the commit already landed in linux-next? [1]

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=00723f494020aceb92f789af634fecba1477fc01

Alyssa

  reply	other threads:[~2021-10-13 14:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 13:32 [PATCH][next] PCI: apple: Remove redundant initialization of pointer port_pdev Colin King
2021-10-12 15:02 ` Alyssa Rosenzweig
2021-10-13  0:47 ` Krzysztof Wilczyński
2021-10-13 13:41 ` Lorenzo Pieralisi
2021-10-13 14:06   ` Alyssa Rosenzweig [this message]
2021-10-13 14:14     ` Lorenzo Pieralisi
2021-10-13 14:22   ` Colin Ian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWbn3MoXwXZ/r4Hn@sunset \
    --to=alyssa@rosenzweig.io \
    --cc=bhelgaas@google.com \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=maz@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.