From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Antonov <alexander.antonov@linux.intel.com>,
Alexei Budankov <abudankov@huawei.com>,
Riccardo Mancini <rickyman7@gmail.com>
Subject: Re: [PATCH v3 0/8] perf session: Extend reader object to allow multiple readers
Date: Thu, 14 Oct 2021 08:45:53 +0200 [thread overview]
Message-ID: <YWfSIRxh5Fu4m75f@krava> (raw)
In-Reply-To: <cover.1634113027.git.alexey.v.bayduraev@linux.intel.com>
On Wed, Oct 13, 2021 at 12:06:34PM +0300, Alexey Bayduraev wrote:
> Changes in v4:
> - set/unset active_decomp within reader__process_events
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
>
> Changes in v3:
> - removed struct reader_state in [PATCH v3 1/8]
> - fixed repeating code in [PATCH v3 2/8]
> - split [PATCH v2 4/5] to [PATCH v3 4/8], [PATCH v3 5/8]
> - split [PATCH v2 5/5] to [PATCH v3 6/8] - [PATCH v3 8/8]
>
> Changes in v2:
> - introduced struct decomp_data suggested by Jiri Olsa
> - removed unnecessary [PATCH v1 1/6]
> - removed unnecessary extra line in [PATCH v2 4/5]
> - removed unnecessary reader_state.eof flag in [PATCH v2 5/5]
>
> Patchset moves state info and decompressor object into reader object
> that made possible to split reader__process_events function into three
> logical parts: init, map/unmap and single event reader which are used
> in events reader loop. This approach allows reading multiple trace
> files at the same time.
>
> The design and implementation are based on the prototype [1], [2].
> The patchset was separated from [3].
>
> Tested:
>
> tools/perf/perf record -o prof.data -- matrix.gcc.g.O3
> tools/perf/perf record -o prof.data -z -- matrix.gcc.g.O3
> tools/perf/perf report -i prof.data
> tools/perf/perf report -i prof.data --call-graph=callee
> tools/perf/perf report -i prof.data --stdio --header
> tools/perf/perf report -i prof.data -D --header
>
> [1] git clone https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git -b perf/record_threads
> [2] https://lore.kernel.org/lkml/20180913125450.21342-1-jolsa@kernel.org/
> [3] https://lore.kernel.org/lkml/cover.1629186429.git.alexey.v.bayduraev@linux.intel.com/
>
> Alexey Bayduraev (8):
> perf session: Move all state items to reader object
> perf session: Introduce decompressor in reader object
> perf session: Move init/release code to separate functions
> perf session: Move map code to separate function
> perf session: Move unmap code to reader__mmap
> perf session: Move event read code to separate function
> perf session: Introduce reader return codes
> perf session: Introduce reader EOF function
>
> tools/perf/util/session.c | 193 ++++++++++++++++++++++++++------------
> tools/perf/util/session.h | 10 +-
> 2 files changed, 141 insertions(+), 62 deletions(-)
>
> --
> 2.19.0
>
prev parent reply other threads:[~2021-10-14 6:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 9:06 [PATCH v3 0/8] perf session: Extend reader object to allow multiple readers Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 1/8] perf session: Move all state items to reader object Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 2/8] perf session: Introduce decompressor in " Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 3/8] perf session: Move init/release code to separate functions Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 4/8] perf session: Move map code to separate function Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 5/8] perf session: Move unmap code to reader__mmap Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 6/8] perf session: Move event read code to separate function Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 7/8] perf session: Introduce reader return codes Alexey Bayduraev
2021-10-13 9:06 ` [PATCH v4 8/8] perf session: Introduce reader EOF function Alexey Bayduraev
2021-10-13 9:17 ` [PATCH v3 0/8] perf session: Extend reader object to allow multiple readers Bayduraev, Alexey V
2021-10-14 6:45 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWfSIRxh5Fu4m75f@krava \
--to=jolsa@redhat.com \
--cc=abudankov@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.antonov@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.