From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFE8C433EF for ; Thu, 14 Oct 2021 18:54:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B225561027 for ; Thu, 14 Oct 2021 18:54:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B225561027 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C95E36E8A1; Thu, 14 Oct 2021 18:54:45 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B5AC6E8A1 for ; Thu, 14 Oct 2021 18:54:43 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 35c7f8f9-2d20-11ec-ac3c-0050568cd888; Thu, 14 Oct 2021 18:54:50 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 147BE194B57; Thu, 14 Oct 2021 20:54:49 +0200 (CEST) Date: Thu, 14 Oct 2021 20:54:39 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Dan Carpenter Cc: Andrzej Hajda , Laurent Pinchart , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Boris Brezillon , Tomi Valkeinen , Sebastian Reichel , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm/bridge: display-connector: fix an uninitialized pointer in probe() Message-ID: References: <20211013080825.GE6010@kili> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013080825.GE6010@kili> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dan, On Wed, Oct 13, 2021 at 11:08:25AM +0300, Dan Carpenter wrote: > The "label" pointer is used for debug output. The code assumes that it > is either NULL or valid, but it is never set to NULL. It is either > valid or uninitialized. > > Fixes: 0c275c30176b ("drm/bridge: Add bridge driver for display connectors") > Signed-off-by: Dan Carpenter Thanks, applied to drm-misc-next. It was IMO not urgent. Sam