From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16E4C433EF for ; Thu, 14 Oct 2021 18:51:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 971DD60E78 for ; Thu, 14 Oct 2021 18:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232227AbhJNSxJ (ORCPT ); Thu, 14 Oct 2021 14:53:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231682AbhJNSxI (ORCPT ); Thu, 14 Oct 2021 14:53:08 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FEEDC061570 for ; Thu, 14 Oct 2021 11:51:03 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id d13-20020a17090ad3cd00b0019e746f7bd4so7636354pjw.0 for ; Thu, 14 Oct 2021 11:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LVHr0bsBDvFWzi52IOLJNCVpf9+SHH8Rz7Qy8n0fv+E=; b=e1/6dh3LqsPP5mEDUNgJN/5k38hTVQq//lcTvS/8eKW3U4cfLo6IFof8/fdVM2/nPf 5SjiNpGQwk8RJHhIEJB+3YsfqIwH4TYwCiu/CYy5CekjNne89tKqxBgcZfxDlBTiDtJ6 AEGtVgxbV0tH/6HtTB0DC8dltaWRkZ6bLPc1IO4TBMoI4YJVRmrXZ5gbTd0jbu9lNbeb B5KW8HGAtw9CHapYy9nd+RHhvEVCR2FLAEeALHLxJgSLJ2FnAhR3PWGRM0J0VBmiSxVv 796qkEOVCgL7KsOrL/cP3y3M/mJwu1XNJokzfWe9jJfls/zdKi71r2P+4At7x6A/VoDg 4duA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LVHr0bsBDvFWzi52IOLJNCVpf9+SHH8Rz7Qy8n0fv+E=; b=psX+QCFnMUHkfCinatZFiUcTFxokyqXWU6ibF4VbaT2qWPUbCpf0x9CODR0TnBcf1z B7GnvnWdcMgKw2ifKCnNWUX/f9krF8mXr/acq1xLKFzS8D1O+CjEpynkDLsgoBS/gGeJ 6FVbpE7aP4WPOZlhEZpTHxupQ+2FG301cvOHtJEXCWBhrVCeCf22hZn8dhW0Tn+t4pF1 TO+ZPjAppNE8Dc8+MbG51NpYA4vSh5Zt95+SEHAh7embe6JQ6K1SHOKmWr0QSohJOmlQ cE6GhnsZY7yIMRwkWALaOk8I5h0iw6L96mZrZSVh1PaWPtqxsiZU+nrmhwIfapEe/TaA myOA== X-Gm-Message-State: AOAM533R1E29ZGfTxf/d3dJLtL8k68UpNK4odkoxLUNJsPKIa8/wxaSW llvkhVSAKUkSj4KmnncwB/71WA== X-Google-Smtp-Source: ABdhPJzAlaDaotn9nIMDhY0E0m/un8LtOqwH+qJ09R0Mjj0DRTrA9QmBRZIeXkpBTkaNBWkJcMNvBQ== X-Received: by 2002:a17:90b:390d:: with SMTP id ob13mr22724433pjb.50.1634237462466; Thu, 14 Oct 2021 11:51:02 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id oo9sm3380968pjb.53.2021.10.14.11.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 11:51:01 -0700 (PDT) Date: Thu, 14 Oct 2021 18:50:58 +0000 From: Sean Christopherson To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov , kvm@vger.kernel.org, Lai Jiangshan , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH 2/2] KVM: X86: Don't reset mmu context when toggling X86_CR4_PGE Message-ID: References: <20210919024246.89230-1-jiangshanlai@gmail.com> <20210919024246.89230-3-jiangshanlai@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210919024246.89230-3-jiangshanlai@gmail.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sun, Sep 19, 2021, Lai Jiangshan wrote: > From: Lai Jiangshan > > X86_CR4_PGE doesn't participate in kvm_mmu_role, so the mmu context > doesn't need to be reset. It is only required to flush all the guest > tlb. > > It is also inconsistent that X86_CR4_PGE is in KVM_MMU_CR4_ROLE_BITS > while kvm_mmu_role doesn't use X86_CR4_PGE. So X86_CR4_PGE is also > removed from KVM_MMU_CR4_ROLE_BITS. > > Signed-off-by: Lai Jiangshan > --- With the KVM_REQ_TLB_FLUSH_GUEST caveat, Reviewed-by: Sean Christopherson