All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Qing Wang <wangqing@vivo.com>
Cc: Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: vt: replace snprintf in show functions with sysfs_emit
Date: Fri, 15 Oct 2021 08:59:03 +0200	[thread overview]
Message-ID: <YWkmt6NePIUnNUXf@kroah.com> (raw)
In-Reply-To: <1634280696-5056-1-git-send-email-wangqing@vivo.com>

On Thu, Oct 14, 2021 at 11:51:36PM -0700, Qing Wang wrote:
> show() must not use snprintf() when formatting the value to be
> returned to user space.

Again, who is making this "must" requirement?

I, as the sysfs maintainer, am not saying that all existing show
functions MUST be converted, so I find it hard to believe that someone
else is...


> 
> Fix the following coccicheck warning:
> drivers/tty/vt/vt.c:3902: WARNING: use scnprintf or sprintf.
> drivers/tty/vt/vt.c:3910: WARNING: use scnprintf or sprintf.

Someone needs to change this warning to show the correct thing here.

thanks,

greg k-h

  reply	other threads:[~2021-10-15  6:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  6:51 [PATCH] tty: vt: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-15  6:59 ` Greg Kroah-Hartman [this message]
     [not found] ` <APcArgDIEqvUlprBO4*Tk4rA.9.1634281148594.Hmail.wangqing@vivo.com>
2021-10-15  7:10   ` 回复: " 王擎
2021-10-15  7:29     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWkmt6NePIUnNUXf@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangqing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.