From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB065C433F5 for ; Fri, 15 Oct 2021 19:43:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84D9C61151 for ; Fri, 15 Oct 2021 19:43:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 84D9C61151 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E630B6E56A; Fri, 15 Oct 2021 19:43:03 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9994A6E56A for ; Fri, 15 Oct 2021 19:43:02 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 20418419-2df0-11ec-ac3c-0050568cd888; Fri, 15 Oct 2021 19:43:09 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 9E329194B3E; Fri, 15 Oct 2021 21:43:08 +0200 (CEST) Date: Fri, 15 Oct 2021 21:42:59 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Simon Ser Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 1/6] drm/sysfs: introduce drm_sysfs_connector_hotplug_event Message-ID: References: <20211015163336.95188-1-contact@emersion.fr> <20211015163336.95188-2-contact@emersion.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Oct 15, 2021 at 09:37:04PM +0200, Sam Ravnborg wrote: > Hi Simon, > > On Fri, Oct 15, 2021 at 04:33:41PM +0000, Simon Ser wrote: > > This function sends a hotplug uevent with a CONNECTOR property. > > A little late feedback. > > Sam If you keep current code then patch is: Reviewed-by: Sam Ravnborg As current code is perfectly fine and a similar pattern is used in the same file elsewhere. Sam