From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 654E7C433EF for ; Fri, 15 Oct 2021 19:44:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26E2961164 for ; Fri, 15 Oct 2021 19:44:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 26E2961164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 742C16EDDB; Fri, 15 Oct 2021 19:44:52 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09C926EDDB for ; Fri, 15 Oct 2021 19:44:51 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10138"; a="288838290" X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="288838290" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 12:44:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="525533566" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga001.jf.intel.com with SMTP; 15 Oct 2021 12:44:48 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 15 Oct 2021 22:44:47 +0300 Date: Fri, 15 Oct 2021 22:44:47 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Simon Ser Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 6/6] i915/display/dp: send a more fine-grained link-status uevent Message-ID: References: <20211015163336.95188-1-contact@emersion.fr> <20211015163336.95188-7-contact@emersion.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211015163336.95188-7-contact@emersion.fr> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Oct 15, 2021 at 04:33:46PM +0000, Simon Ser wrote: > When link-status changes, send a hotplug uevent which contains the > connector and property ID. That way, user-space can more easily > figure out that only the link-status property of this connector has > been updated. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 04175f359fd6..afbe34b6e5be 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5264,6 +5264,8 @@ static void intel_dp_modeset_retry_work_fn(struct work_struct *work) > mutex_unlock(&connector->dev->mode_config.mutex); > /* Send Hotplug uevent so userspace can reprobe */ > drm_kms_helper_hotplug_event(connector->dev); > + drm_sysfs_connector_status_event(connector, > + connector->dev->mode_config.link_status_property); So we're now doing two uevents back to back? Is one not enough? > } > > bool > -- > 2.33.1 > -- Ville Syrjälä Intel