From: Greg KH <gregkh@linuxfoundation.org>
To: Gabriel Goller <gabrielgoller123@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: Removed unused comments
Date: Sat, 30 Oct 2021 14:17:34 +0200 [thread overview]
Message-ID: <YX033kO2Ivbn+xop@kroah.com> (raw)
In-Reply-To: <YX0m1jF6p6OjMTRV@desktop>
On Sat, Oct 30, 2021 at 01:04:54PM +0200, Gabriel Goller wrote:
> Removed commented-out code pieces that are not used anymore.
>
> Signed-off-by: Gabriel Goller <gabrielgoller123@gmail.com>
> ---
> drivers/staging/wlan-ng/prism2mib.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index c04fc17b3c64..fcf8313870af 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -679,16 +679,8 @@ static int prism2mib_priv(struct mibrec *mib,
> HFA384x_RID_CNFWPADATA,
> (u8 *)&wpa,
> sizeof(wpa));
> - /*
> - * pstr->len = le16_to_cpu(wpa.datalen);
> - * memcpy(pstr->data, wpa.data, pstr->len);
> - */
> pstr->len = 0;
> } else {
> - /*
> - * wpa.datalen = cpu_to_le16(pstr->len);
> - * memcpy(wpa.data, pstr->data, pstr->len);
> - */
> wpa.datalen = 0;
>
> hfa384x_drvr_setconfig(hw,
> --
> 2.30.2
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2021-10-30 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 11:04 [PATCH] staging: wlan-ng: Removed unused comments Gabriel Goller
2021-10-30 12:17 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-30 12:51 Gabriel Goller
2021-11-12 20:35 Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YX033kO2Ivbn+xop@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gabrielgoller123@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.