All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] netdevsim: remove max_vfs dentry
Date: Sun, 31 Oct 2021 09:55:11 +0200	[thread overview]
Message-ID: <YX5L31YA+7JRBKon@unreal> (raw)
In-Reply-To: <20211028211753.22612-1-kuba@kernel.org>

On Thu, Oct 28, 2021 at 02:17:53PM -0700, Jakub Kicinski wrote:
> Commit d395381909a3 ("netdevsim: Add max_vfs to bus_dev")
> added this file and saved the dentry for no apparent reason.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  drivers/net/netdevsim/dev.c       | 8 +++-----
>  drivers/net/netdevsim/netdevsim.h | 1 -
>  2 files changed, 3 insertions(+), 6 deletions(-)

I think that "debugfs_create_file("ipsec", 0400, ..." can be cleaned
too. It is connected to ddir, which is removed recursively.

Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Thanks

      reply	other threads:[~2021-10-31  7:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 21:17 [PATCH net-next] netdevsim: remove max_vfs dentry Jakub Kicinski
2021-10-31  7:55 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YX5L31YA+7JRBKon@unreal \
    --to=leon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.