From: Eryu Guan <guan@eryu.me>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: djwong@kernel.org, fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs/126: Add a getxattr opeartion
Date: Sun, 31 Oct 2021 23:15:04 +0800 [thread overview]
Message-ID: <YX6y+Bt6+euS8CP6@desktop> (raw)
In-Reply-To: <1635497424-8095-1-git-send-email-xuyang2018.jy@fujitsu.com>
On Fri, Oct 29, 2021 at 04:50:24PM +0800, Yang Xu wrote:
> It is design to reproduce a deadlock on upstream kernel. It is introduced
> by kernel commit 07120f1abdff ("xfs: Add xfs_has_attr and subroutines").
>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
As this will trigger deadlock, I'd just wait for the fix to land first,
the we also could reference the commit that fixed the issue in commit
log.
Thanks,
Eryu
> ---
> tests/xfs/126 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/126 b/tests/xfs/126
> index c3a74b1c..9a77a60e 100755
> --- a/tests/xfs/126
> +++ b/tests/xfs/126
> @@ -69,7 +69,7 @@ done
>
> echo "+ mount image && modify xattr"
> if _try_scratch_mount >> $seqres.full 2>&1; then
> -
> + getfattr "${SCRATCH_MNT}/attrfile" -n "user.x00000000" 2> /dev/null || _fail "modified corrupt xattr"
> setfattr -x "user.x00000000" "${SCRATCH_MNT}/attrfile" 2> /dev/null && _fail "modified corrupt xattr"
> umount "${SCRATCH_MNT}"
> fi
> --
> 2.23.0
prev parent reply other threads:[~2021-10-31 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 8:50 [PATCH] xfs/126: Add a getxattr opeartion Yang Xu
2021-10-31 15:15 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YX6y+Bt6+euS8CP6@desktop \
--to=guan@eryu.me \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.