From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9E0C433F5 for ; Mon, 1 Nov 2021 02:34:37 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 088FE60F45 for ; Mon, 1 Nov 2021 02:34:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 088FE60F45 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-220-KlXnYe0BPcCpN6hMHFv7Ww-1; Sun, 31 Oct 2021 22:34:31 -0400 X-MC-Unique: KlXnYe0BPcCpN6hMHFv7Ww-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 84231362FF; Mon, 1 Nov 2021 02:34:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C2A2F2B399; Mon, 1 Nov 2021 02:34:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 921044A703; Mon, 1 Nov 2021 02:34:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A12YGJN024980 for ; Sun, 31 Oct 2021 22:34:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id EDC6F400F3EC; Mon, 1 Nov 2021 02:34:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA169401A972 for ; Mon, 1 Nov 2021 02:34:15 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D08A4800C00 for ; Mon, 1 Nov 2021 02:34:15 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-uhRo7JgNM3Gyz9yLlla0Nw-1; Sun, 31 Oct 2021 22:34:13 -0400 X-MC-Unique: uhRo7JgNM3Gyz9yLlla0Nw-1 Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhN6c-003SWk-T1; Mon, 01 Nov 2021 02:31:47 +0000 Date: Mon, 1 Nov 2021 02:31:26 +0000 From: Matthew Wilcox To: Pavel Begunkov Message-ID: References: <2102a2e6-c543-2557-28a2-8b0bdc470855@oracle.com> <20211028002451.GB2237511@magnolia> <20211028225955.GA449541@dread.disaster.area> <22255117-52de-4b2d-822e-b4bc50bbc52b@gmail.com> <20211029223233.GB449541@dread.disaster.area> <1a76314d-9b62-82a3-2787-96e6b83720fc@gmail.com> MIME-Version: 1.0 In-Reply-To: <1a76314d-9b62-82a3-2787-96e6b83720fc@gmail.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-loop: dm-devel@redhat.com Cc: Jane Chu , "nvdimm@lists.linux.dev" , "dave.jiang@intel.com" , "snitzer@redhat.com" , "Darrick J. Wong" , Dave Chinner , "linux-kernel@vger.kernel.org" , Christoph Hellwig , "dm-devel@redhat.com" , "vgoyal@redhat.com" , "vishal.l.verma@intel.com" , "linux-fsdevel@vger.kernel.org" , "dan.j.williams@intel.com" , "ira.weiny@intel.com" , "linux-xfs@vger.kernel.org" , "agk@redhat.com" Subject: Re: [dm-devel] [PATCH 0/6] dax poison recovery with RWF_RECOVERY_DATA flag X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Oct 31, 2021 at 01:19:48PM +0000, Pavel Begunkov wrote: > On 10/29/21 23:32, Dave Chinner wrote: > > Yup, you just described RWF_HIPRI! Seriously, Pavel, did you read > > past this? I'll quote what I said again, because I've already > > addressed this argument to point out how silly it is: > > And you almost got to the initial point in your penult paragraph. A > single if for a single flag is not an issue, what is the problem is > when there are dozens of them and the overhead for it is not isolated, > so the kernel has to jump through dozens of those. This argument can be used to reject *ANY* new feature. For example, by using your argument, we should have rejected the addition of IOCB_WAITQ because it penalises the vast majority of IOs which do not use it. But we didn't. Because we see that while it may not be of use to US today, it's a generally useful feature for Linux to support. You say yourself that this feature doesn't slow down your use case, so why are you spending so much time and energy annoying the people who actually want to use it? Seriously. Stop arguing about something you actually don't care about. You're just making Linux less fun to work on. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93AB2C433F5 for ; Mon, 1 Nov 2021 02:35:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C5A460F02 for ; Mon, 1 Nov 2021 02:35:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbhKACha (ORCPT ); Sun, 31 Oct 2021 22:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230222AbhKACh3 (ORCPT ); Sun, 31 Oct 2021 22:37:29 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5CEAC061714; Sun, 31 Oct 2021 19:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YVq1DQ33vlTfqQwlUVtldRtum7VTJ4Qf1wo2xOWYsbs=; b=gRMXvXUxYDh5PXfGY5PmoKkYNO XFLFQoynUl1o2KWv51EHkiPEdljCH01lPjc7+M/bKuM+7+9IMZ5jSaJ1MGCpifQEIS4Qcd4dJc1Wa 8dO9Kqrf/Di+5EBltPtFcL+YtbwV3OLvk6Xd+aK2ECFw7/Gdg6aHCwAbztH3lXoJa/BeCs6oUo293 PDjr1JQ8F7sTCQXgKQMS9nw7lOnA4+04vMjmHw0d21F6Bmw25BeerzvqDabqxyqC/dw8tJs3qOPJ5 esyiwcXYwn4sfB97InYFLCCmiTcpnwhbut8Sq53K97IVVQd9qJb66Xm71VeQJPsOdp6iE9VKRW5XR oQBeZ3uw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhN6c-003SWk-T1; Mon, 01 Nov 2021 02:31:47 +0000 Date: Mon, 1 Nov 2021 02:31:26 +0000 From: Matthew Wilcox To: Pavel Begunkov Cc: Dave Chinner , "Darrick J. Wong" , Christoph Hellwig , Jane Chu , "dan.j.williams@intel.com" , "vishal.l.verma@intel.com" , "dave.jiang@intel.com" , "agk@redhat.com" , "snitzer@redhat.com" , "dm-devel@redhat.com" , "ira.weiny@intel.com" , "vgoyal@redhat.com" , "linux-fsdevel@vger.kernel.org" , "nvdimm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-xfs@vger.kernel.org" Subject: Re: [dm-devel] [PATCH 0/6] dax poison recovery with RWF_RECOVERY_DATA flag Message-ID: References: <2102a2e6-c543-2557-28a2-8b0bdc470855@oracle.com> <20211028002451.GB2237511@magnolia> <20211028225955.GA449541@dread.disaster.area> <22255117-52de-4b2d-822e-b4bc50bbc52b@gmail.com> <20211029223233.GB449541@dread.disaster.area> <1a76314d-9b62-82a3-2787-96e6b83720fc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a76314d-9b62-82a3-2787-96e6b83720fc@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Oct 31, 2021 at 01:19:48PM +0000, Pavel Begunkov wrote: > On 10/29/21 23:32, Dave Chinner wrote: > > Yup, you just described RWF_HIPRI! Seriously, Pavel, did you read > > past this? I'll quote what I said again, because I've already > > addressed this argument to point out how silly it is: > > And you almost got to the initial point in your penult paragraph. A > single if for a single flag is not an issue, what is the problem is > when there are dozens of them and the overhead for it is not isolated, > so the kernel has to jump through dozens of those. This argument can be used to reject *ANY* new feature. For example, by using your argument, we should have rejected the addition of IOCB_WAITQ because it penalises the vast majority of IOs which do not use it. But we didn't. Because we see that while it may not be of use to US today, it's a generally useful feature for Linux to support. You say yourself that this feature doesn't slow down your use case, so why are you spending so much time and energy annoying the people who actually want to use it? Seriously. Stop arguing about something you actually don't care about. You're just making Linux less fun to work on.