From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D167BC433F5 for ; Thu, 21 Oct 2021 10:57:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D579D60F46 for ; Thu, 21 Oct 2021 10:57:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D579D60F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QOQ57wTWXv7+x685g+JEkkbfT4xAj75R0SeDheumVpg=; b=v2iOrP71CacMQF 3OkiIJRkYfGuHWEU0+Ox1B/4+gC+J730sRxCKnyktAwXebvqz79L5lwPUzRI++Mbt4/Ktavh0Vv8q tAOmNbJJlwJludBwzgSI/RQ1USCjRI69i3JYf75/9yzp0OuYoE1mMxIvwHT/7Mh/xC0UwgYMmyt2s 1CYw+Tkia1NwI9FV+RaOWL8mahT2KUID0LNK8Fx06IP+utZ7RpbqhXqSODw2CSN1xkZJ8rBi8II9c M0I20+oqr46a5i5Pee85WA05ExF22Zwzs8V6ygZqtJuOkmS64IFfdJKwrZxSNqVoGpO5h4ZPzbqyC cwdsoxAiK50p45s78YzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdVlB-007Ihv-98; Thu, 21 Oct 2021 10:57:21 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdVl8-007IhJ-D5 for linux-mtd@lists.infradead.org; Thu, 21 Oct 2021 10:57:19 +0000 Received: by mail-wm1-x334.google.com with SMTP id s198-20020a1ca9cf000000b0030d6986ea9fso366118wme.1 for ; Thu, 21 Oct 2021 03:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2q8epunI2YJhS7Y5OvXRSfgnjSjIlOxQhWm8Zime4ZA=; b=wzK981VLSe8rOftFqyi7FSQznuKzeJC7z9un27zFAQKuoZaLfKG+i6biCvyisY7FSn zP8ZeN28SeeIlOCbB5YLgUvfTp0AdPc3HHatbOdQWH+iPb3dZcdvHe8u5phYwiBwUYvX yuVhM3qbhR11RJQzT75URYmoIeBXBfZCApiliAPma5gmh0gfMmZJtwGuQvat131RkNSF fKnE1gqepZtoaGLI4oh21Oaf+Rx+oI902OfGpeZD1Yi4xfMAeILgyRjHJ6A8CGSL1d8n PSv0ZGM/CctnF5vQP97w039WJ+upPbg3VIzC+kS/RWWA0bPmUdwuNJFLrUEqQI2TInzP 2urA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2q8epunI2YJhS7Y5OvXRSfgnjSjIlOxQhWm8Zime4ZA=; b=Z5lTrVb4aErojU9yDF54r+DNzbjXX6NTtF/k413Ry33BZc4TFGgVWvh20lhqMYJNix jUGjkNnuBxfUqVFCetIH9WvJ2YboVMdCp0z20qEHC/M45rSIcGhkgLpqi7bq8FVG/b0u uWgzV6vb9iPsaWTBFv7IKof+CZ6s6KkkK3edHi6joqqV6GtOjjhq/OyQHyZOEX2vQW4e 5ZjoQynZjxX+zcrzrJ3wOqjXxu7St9omatqqUV/lBggAbAMM3AkYTDvWomf5jiMI+anf Mdbhw9YrJKR+a/ZfuQgK4638yjnftkdQ09OymzeNqU2mOWikcaYqpleu+5XzletbjRCm gu2Q== X-Gm-Message-State: AOAM533ked/h4A/vyWqWJS0V4EXtwSgRPsrO0kNNJ/dwvSMxkx4OpVO+ NBv3edASsbgdR1bz1O+PlCGAqw== X-Google-Smtp-Source: ABdhPJwq6IzyGk5NqRL6jkJfSRsLMIAxvgYpLGUX6cV1w4RGXuY5ZSGXnYWzepTgkl78EuNFZdHfkA== X-Received: by 2002:a1c:7c0e:: with SMTP id x14mr5795779wmc.128.1634813836516; Thu, 21 Oct 2021 03:57:16 -0700 (PDT) Received: from google.com ([95.148.6.207]) by smtp.gmail.com with ESMTPSA id l40sm4871132wms.31.2021.10.21.03.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 03:57:16 -0700 (PDT) Date: Thu, 21 Oct 2021 11:57:14 +0100 From: Lee Jones To: Mika Westerberg Cc: Tudor Ambarus , Mark Brown , Michael Walle , Pratyush Yadav , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jonathan Corbet , Mauro Lima , Alexander Sverdlin , Andy Shevchenko , linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org Subject: Re: [PATCH v2 2/3] mtd: spi-nor: intel-spi: Convert to SPI MEM Message-ID: References: <20211007112132.30934-1-mika.westerberg@linux.intel.com> <20211007112132.30934-3-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211007112132.30934-3-mika.westerberg@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211021_035718_471903_77300BF5 X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwNyBPY3QgMjAyMSwgTWlrYSBXZXN0ZXJiZXJnIHdyb3RlOgoKPiBUaGUgcHJlZmVy cmVkIHdheSB0byBpbXBsZW1lbnQgU1BJLU5PUiBjb250cm9sbGVyIGRyaXZlcnMgaXMgdGhyb3Vn aCBTUEkKPiBzdWJzdWJzeXN0ZW0gdXRpbGl6aW5nIHRoZSBTUEkgTUVNIGNvcmUgZnVuY3Rpb25z LiBUaGlzIGNvbnZlcnRzIHRoZQo+IEludGVsIFNQSSBmbGFzaCBjb250cm9sbGVyIGRyaXZlciBv dmVyIHRoZSBTUEkgTUVNIGJ5IG1vdmluZyB0aGUgZHJpdmVyCj4gZnJvbSBTUEktTk9SIHN1YnN5 c3RlbSB0byBTUEkgc3Vic3lzdGVtIGFuZCBpbiBvbmUgZ28gbWFrZSBpdCB1c2UgdGhlCj4gU1BJ IE1FTSBmdW5jdGlvbnMuIFRoZSBkcml2ZXIgbmFtZSB3aWxsIGJlIGNoYW5nZWQgZnJvbSBpbnRl bC1zcGkgdG8KPiBzcGktaW50ZWwgdG8gbWF0Y2ggdGhlIGNvbnZlbnRpb24gdXNlZCBpbiB0aGUg U1BJIHN1YnN5c3RlbS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNaWthIFdlc3RlcmJlcmcgPG1pa2Eu d2VzdGVyYmVyZ0BsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL3NwaS1ub3Iv Y29udHJvbGxlcnMvS2NvbmZpZyAgICAgICB8ICAzNiAtLS0KPiAgZHJpdmVycy9tdGQvc3BpLW5v ci9jb250cm9sbGVycy9NYWtlZmlsZSAgICAgIHwgICAzIC0KPiAgZHJpdmVycy9tdGQvc3BpLW5v ci9jb250cm9sbGVycy9pbnRlbC1zcGkuaCAgIHwgIDIxIC0tCj4gIGRyaXZlcnMvc3BpL0tjb25m aWcgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAzOSArKysKPiAgZHJpdmVycy9zcGkvTWFr ZWZpbGUgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAzICsKPiAgLi4uL2ludGVsLXNwaS1w Y2kuYyA9PiBzcGkvc3BpLWludGVsLXBjaS5jfSAgIHwgIDIwICstCj4gIC4uLi9zcGktaW50ZWwt cGxhdGZvcm0uY30gICAgICAgICAgICAgICAgICAgICB8ICAyMSArLQo+ICAuLi4vaW50ZWwtc3Bp LmMgPT4gc3BpL3NwaS1pbnRlbC5jfSAgICAgICAgICAgfCAzMDQgKysrKysrKysrKystLS0tLS0t Cj4gIGRyaXZlcnMvc3BpL3NwaS1pbnRlbC5oICAgICAgICAgICAgICAgICAgICAgICB8ICAxOSAr Kwo+ICBpbmNsdWRlL2xpbnV4L21mZC9scGNfaWNoLmggICAgICAgICAgICAgICAgICAgfCAgIDIg Ky0KPiAgLi4uL3g4Ni97aW50ZWwtc3BpLmggPT4gc3BpLWludGVsLmh9ICAgICAgICAgIHwgICA2 ICstCj4gIDExIGZpbGVzIGNoYW5nZWQsIDI1NCBpbnNlcnRpb25zKCspLCAyMjAgZGVsZXRpb25z KC0pCj4gIGRlbGV0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL210ZC9zcGktbm9yL2NvbnRyb2xsZXJz L2ludGVsLXNwaS5oCj4gIHJlbmFtZSBkcml2ZXJzL3ttdGQvc3BpLW5vci9jb250cm9sbGVycy9p bnRlbC1zcGktcGNpLmMgPT4gc3BpL3NwaS1pbnRlbC1wY2kuY30gKDg2JSkKPiAgcmVuYW1lIGRy aXZlcnMve210ZC9zcGktbm9yL2NvbnRyb2xsZXJzL2ludGVsLXNwaS1wbGF0Zm9ybS5jID0+IHNw aS9zcGktaW50ZWwtcGxhdGZvcm0uY30gKDY1JSkKPiAgcmVuYW1lIGRyaXZlcnMve210ZC9zcGkt bm9yL2NvbnRyb2xsZXJzL2ludGVsLXNwaS5jID0+IHNwaS9zcGktaW50ZWwuY30gKDgwJSkKPiAg Y3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvc3BpL3NwaS1pbnRlbC5oCj4gIHJlbmFtZSBpbmNs dWRlL2xpbnV4L3BsYXRmb3JtX2RhdGEveDg2L3tpbnRlbC1zcGkuaCA9PiBzcGktaW50ZWwuaH0g KDg5JSkKCkZvciB0aGUgTUZEIHBhcnRzOiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAKIEFja2VkLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPiAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIApXaG9ldmVyIGVu ZHMgdXAgdGFraW5nIHRoaXMgbmVlZHMgdG8gc2VuZCBvdXQgYSBwdWxsLXJlcXVlc3QgdG8gYW4K aW1tdXRhYmxlIGJyYW5jaCBwbGVhc2UuICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVh ZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2Fy ZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A48D5C433F5 for ; Thu, 21 Oct 2021 10:57:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 890CD6112D for ; Thu, 21 Oct 2021 10:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230285AbhJUK7e (ORCPT ); Thu, 21 Oct 2021 06:59:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbhJUK7d (ORCPT ); Thu, 21 Oct 2021 06:59:33 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E826FC06161C for ; Thu, 21 Oct 2021 03:57:17 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id d198-20020a1c1dcf000000b00322f53b9b89so387467wmd.0 for ; Thu, 21 Oct 2021 03:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2q8epunI2YJhS7Y5OvXRSfgnjSjIlOxQhWm8Zime4ZA=; b=wzK981VLSe8rOftFqyi7FSQznuKzeJC7z9un27zFAQKuoZaLfKG+i6biCvyisY7FSn zP8ZeN28SeeIlOCbB5YLgUvfTp0AdPc3HHatbOdQWH+iPb3dZcdvHe8u5phYwiBwUYvX yuVhM3qbhR11RJQzT75URYmoIeBXBfZCApiliAPma5gmh0gfMmZJtwGuQvat131RkNSF fKnE1gqepZtoaGLI4oh21Oaf+Rx+oI902OfGpeZD1Yi4xfMAeILgyRjHJ6A8CGSL1d8n PSv0ZGM/CctnF5vQP97w039WJ+upPbg3VIzC+kS/RWWA0bPmUdwuNJFLrUEqQI2TInzP 2urA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2q8epunI2YJhS7Y5OvXRSfgnjSjIlOxQhWm8Zime4ZA=; b=KoB4QQQJWmgdbAD6MQ7WjlO+kDQUnX5pWyA3LbcjJ88t9Xb15dB8ycuZ/mfqsqkJi1 Mj1X0eGmB1IjjWD+GmWuiP2/PCckgmIEv+PmlIb2bXiLZ/V76BvdY7y7tukFZsaEnXNK 1aG1wd7VOtCaXd7sN8auhbGu3Pv6RhP5rPJP5coUeOfRphLVWqJnW8D25rfVNYiAzToj giYxgLszebyruM+xHiVek1XPs9OO0wP867K+T6Kiq8NNiUbFh8gOeOVv9TgAZG+IKS2Y MyZuID1OAfmJyMcucyIzzH1ZxdHFEckSCBPwFNyD+Lo/PGxHfNsxMpb9JbtBSzxXBMol JHKg== X-Gm-Message-State: AOAM5305Urb/iWqy1tWFINWc7EKwIuKvJv1NQeiEkihX9lz0lXKG7wrn EjF6WmzJZZBnCfhwGVQzAswelA== X-Google-Smtp-Source: ABdhPJwq6IzyGk5NqRL6jkJfSRsLMIAxvgYpLGUX6cV1w4RGXuY5ZSGXnYWzepTgkl78EuNFZdHfkA== X-Received: by 2002:a1c:7c0e:: with SMTP id x14mr5795779wmc.128.1634813836516; Thu, 21 Oct 2021 03:57:16 -0700 (PDT) Received: from google.com ([95.148.6.207]) by smtp.gmail.com with ESMTPSA id l40sm4871132wms.31.2021.10.21.03.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 03:57:16 -0700 (PDT) Date: Thu, 21 Oct 2021 11:57:14 +0100 From: Lee Jones To: Mika Westerberg Cc: Tudor Ambarus , Mark Brown , Michael Walle , Pratyush Yadav , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jonathan Corbet , Mauro Lima , Alexander Sverdlin , Andy Shevchenko , linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org Subject: Re: [PATCH v2 2/3] mtd: spi-nor: intel-spi: Convert to SPI MEM Message-ID: References: <20211007112132.30934-1-mika.westerberg@linux.intel.com> <20211007112132.30934-3-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211007112132.30934-3-mika.westerberg@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Thu, 07 Oct 2021, Mika Westerberg wrote: > The preferred way to implement SPI-NOR controller drivers is through SPI > subsubsystem utilizing the SPI MEM core functions. This converts the > Intel SPI flash controller driver over the SPI MEM by moving the driver > from SPI-NOR subsystem to SPI subsystem and in one go make it use the > SPI MEM functions. The driver name will be changed from intel-spi to > spi-intel to match the convention used in the SPI subsystem. > > Signed-off-by: Mika Westerberg > --- > drivers/mtd/spi-nor/controllers/Kconfig | 36 --- > drivers/mtd/spi-nor/controllers/Makefile | 3 - > drivers/mtd/spi-nor/controllers/intel-spi.h | 21 -- > drivers/spi/Kconfig | 39 +++ > drivers/spi/Makefile | 3 + > .../intel-spi-pci.c => spi/spi-intel-pci.c} | 20 +- > .../spi-intel-platform.c} | 21 +- > .../intel-spi.c => spi/spi-intel.c} | 304 +++++++++++------- > drivers/spi/spi-intel.h | 19 ++ > include/linux/mfd/lpc_ich.h | 2 +- > .../x86/{intel-spi.h => spi-intel.h} | 6 +- > 11 files changed, 254 insertions(+), 220 deletions(-) > delete mode 100644 drivers/mtd/spi-nor/controllers/intel-spi.h > rename drivers/{mtd/spi-nor/controllers/intel-spi-pci.c => spi/spi-intel-pci.c} (86%) > rename drivers/{mtd/spi-nor/controllers/intel-spi-platform.c => spi/spi-intel-platform.c} (65%) > rename drivers/{mtd/spi-nor/controllers/intel-spi.c => spi/spi-intel.c} (80%) > create mode 100644 drivers/spi/spi-intel.h > rename include/linux/platform_data/x86/{intel-spi.h => spi-intel.h} (89%) For the MFD parts: Acked-by: Lee Jones Whoever ends up taking this needs to send out a pull-request to an immutable branch please. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog