From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED58C433F5 for ; Thu, 21 Oct 2021 12:15:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2102F6121F for ; Thu, 21 Oct 2021 12:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbhJUMRz (ORCPT ); Thu, 21 Oct 2021 08:17:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:58802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230231AbhJUMRy (ORCPT ); Thu, 21 Oct 2021 08:17:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A90166120F; Thu, 21 Oct 2021 12:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634818539; bh=G9Fyn+LXoWKA+dJXkGbE/r3nlPUNszZi5Xifq7aBcs8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A+XN+IKTW8mMDKiQknDVE/GjUOi8ZFe8YM6VSwOo00MupvnhUh9NWggpyAxnMzIgA HsJezYF4ECzVSCc1AvUFJEjnqGXhivPp7aO6F384SE/4BKYsDdAqSpIH8ThrF9ZWQ3 8Xe4v25f+YPtKxZEa+mUDw//5Obi6dt39+HbXKew2qMAmitwvMkNCqDJq8I1aZy0ww anG4Hwda4MEoUbAyyCNYZ+75Fr67RZwCfkbb7vUHMOqLrab0AZVvMoxBdBU8jEhpSg ZuFEyaAjh4xpukw/pau4M3QTamiYSNkwKgvWlZbN6bNhYtgdzJ1xpt7PDwd8n9gCF7 HI613S/nSxkbA== Date: Thu, 21 Oct 2021 13:15:36 +0100 From: Mark Brown To: Will Deacon Cc: Catalin Marinas , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 10/42] arm64/sve: Make sysctl interface for SVE reusable by SME Message-ID: References: <20211019172247.3045838-1-broonie@kernel.org> <20211019172247.3045838-11-broonie@kernel.org> <20211021095550.GA16377@willie-the-truck> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KZ0sz92NMjGU1gkP" Content-Disposition: inline In-Reply-To: <20211021095550.GA16377@willie-the-truck> X-Cookie: I program, therefore I am. Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org --KZ0sz92NMjGU1gkP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 21, 2021 at 10:55:51AM +0100, Will Deacon wrote: > On Tue, Oct 19, 2021 at 06:22:15PM +0100, Mark Brown wrote: > > + if (!info) > > + return -EINVAL; > Is this check actually needed? If so, you've already dereferenced the > pointer. It's redundant, just defensiveness. --KZ0sz92NMjGU1gkP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFxWecACgkQJNaLcl1U h9A5Kgf/a7iis1Wb8eZkh4Uz3o9Y8YEpVhnS1QtF5DTOfG6KpoAo4zh5hSkOlul0 vI84jzx/ltUVbn3hk8goBqF6rt07EWOyd5K74lP6TBDvTKZMnv3SRI4qEKGAmUky zlN3BzihaiqwcKWx6l2Iuy6WGU4I4DY/gnPnE5mehryLWyHyfpdRSAXJbMGS9Qeb rJK+0JAm+A4atkqZ2i5Jlt9ESdA2AX4Y0TiuSXw7Aw6ZLZO5SpkcihKCwN/LHGVD rzvQcWkCQubW900zvPL19VZd8WbmvCGN0gdP3YBKpJUI3t/p1HmVZSItsmiYGlfw JCHjxSJKBz9angq9DPK7Zt9Uc6Gu2Q== =DLJo -----END PGP SIGNATURE----- --KZ0sz92NMjGU1gkP-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A16EC433EF for ; Thu, 21 Oct 2021 12:16:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC1026120C for ; Thu, 21 Oct 2021 12:16:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC1026120C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YNjqCu4iLWgzy2zoGHv8J0DyL1P/b+qai1yediej3/g=; b=ZJBPG8SxgANRIlpUvqggEiROdG fGnJ6DxfgtNHZaL2pJP5QcqCXFSbPQSxYHOhlHxXLhEV0McwmMoWmh67iEvN1G9m6rK09vlbR7j2W Mhei7YZvIyJ5u7P+gq5Dr+Co5IvfR0zvkETlocbNBzwcOpLuyOuzgQxdfSXyVbBYagrE6hfFYyokE r/aJm7Idy+oyxUVTPMqazGc171UMZaEnNX+X71FpPYFV6n6dJYtx/Akvuo8H6AMknk3PorDtSyhda KEhu/z2mUvEiHqMApeCGwTilN67JpFErSCI382Ix/m2fnV7U2n7Yh4Eu26iVMk4aLakDbnXB0+y7O o7uZL0XA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdWz0-007R4i-Ti; Thu, 21 Oct 2021 12:15:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdWyx-007R4D-C6 for linux-arm-kernel@lists.infradead.org; Thu, 21 Oct 2021 12:15:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A90166120F; Thu, 21 Oct 2021 12:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634818539; bh=G9Fyn+LXoWKA+dJXkGbE/r3nlPUNszZi5Xifq7aBcs8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A+XN+IKTW8mMDKiQknDVE/GjUOi8ZFe8YM6VSwOo00MupvnhUh9NWggpyAxnMzIgA HsJezYF4ECzVSCc1AvUFJEjnqGXhivPp7aO6F384SE/4BKYsDdAqSpIH8ThrF9ZWQ3 8Xe4v25f+YPtKxZEa+mUDw//5Obi6dt39+HbXKew2qMAmitwvMkNCqDJq8I1aZy0ww anG4Hwda4MEoUbAyyCNYZ+75Fr67RZwCfkbb7vUHMOqLrab0AZVvMoxBdBU8jEhpSg ZuFEyaAjh4xpukw/pau4M3QTamiYSNkwKgvWlZbN6bNhYtgdzJ1xpt7PDwd8n9gCF7 HI613S/nSxkbA== Date: Thu, 21 Oct 2021 13:15:36 +0100 From: Mark Brown To: Will Deacon Cc: Catalin Marinas , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 10/42] arm64/sve: Make sysctl interface for SVE reusable by SME Message-ID: References: <20211019172247.3045838-1-broonie@kernel.org> <20211019172247.3045838-11-broonie@kernel.org> <20211021095550.GA16377@willie-the-truck> MIME-Version: 1.0 In-Reply-To: <20211021095550.GA16377@willie-the-truck> X-Cookie: I program, therefore I am. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211021_051539_464947_669565A8 X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6051440695297177974==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6051440695297177974== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KZ0sz92NMjGU1gkP" Content-Disposition: inline --KZ0sz92NMjGU1gkP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 21, 2021 at 10:55:51AM +0100, Will Deacon wrote: > On Tue, Oct 19, 2021 at 06:22:15PM +0100, Mark Brown wrote: > > + if (!info) > > + return -EINVAL; > Is this check actually needed? If so, you've already dereferenced the > pointer. It's redundant, just defensiveness. --KZ0sz92NMjGU1gkP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFxWecACgkQJNaLcl1U h9A5Kgf/a7iis1Wb8eZkh4Uz3o9Y8YEpVhnS1QtF5DTOfG6KpoAo4zh5hSkOlul0 vI84jzx/ltUVbn3hk8goBqF6rt07EWOyd5K74lP6TBDvTKZMnv3SRI4qEKGAmUky zlN3BzihaiqwcKWx6l2Iuy6WGU4I4DY/gnPnE5mehryLWyHyfpdRSAXJbMGS9Qeb rJK+0JAm+A4atkqZ2i5Jlt9ESdA2AX4Y0TiuSXw7Aw6ZLZO5SpkcihKCwN/LHGVD rzvQcWkCQubW900zvPL19VZd8WbmvCGN0gdP3YBKpJUI3t/p1HmVZSItsmiYGlfw JCHjxSJKBz9angq9DPK7Zt9Uc6Gu2Q== =DLJo -----END PGP SIGNATURE----- --KZ0sz92NMjGU1gkP-- --===============6051440695297177974== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6051440695297177974==--