From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: dledford@redhat.com, jgg@nvidia.com, linux-rdma@vger.kernel.org,
saeedm@nvidia.com
Subject: Re: [PATCH rdma-next 2/3] mlx5: use dev_addr_mod()
Date: Thu, 21 Oct 2021 16:40:43 +0300 [thread overview]
Message-ID: <YXFt2/mx30fmDoj2@unreal> (raw)
In-Reply-To: <20211021055823.2319a4c8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Oct 21, 2021 at 05:58:23AM -0700, Jakub Kicinski wrote:
> On Thu, 21 Oct 2021 12:49:53 +0300 Leon Romanovsky wrote:
> > > - dev->dev_addr[1] = (ipriv->qpn >> 16) & 0xff;
>
> ^ the original modifies starting at offset 1
Ahh, right.
>
> > > - dev->dev_addr[2] = (ipriv->qpn >> 8) & 0xff;
> > > - dev->dev_addr[3] = (ipriv->qpn) & 0xff;
> > > + addr_mod[0] = (ipriv->qpn >> 16) & 0xff;
> > > + addr_mod[1] = (ipriv->qpn >> 8) & 0xff;
> > > + addr_mod[2] = (ipriv->qpn) & 0xff;
> > > + dev_addr_mod(dev, 1, addr_mod, sizeof(addr_mod));
> > ^^^ It should be 0, no?
next prev parent reply other threads:[~2021-10-21 13:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 18:26 [PATCH rdma-next 0/3] rdma: prepare for const netdev->dev_addr Jakub Kicinski
2021-10-19 18:26 ` [PATCH rdma-next 1/3] ipoib: use dev_addr_mod() Jakub Kicinski
2021-10-21 9:51 ` Leon Romanovsky
2021-10-19 18:26 ` [PATCH rdma-next 2/3] mlx5: " Jakub Kicinski
2021-10-21 9:49 ` Leon Romanovsky
2021-10-21 12:58 ` Jakub Kicinski
2021-10-21 13:40 ` Leon Romanovsky [this message]
2021-10-21 13:40 ` Leon Romanovsky
2021-10-19 18:26 ` [PATCH rdma-next 3/3] RDMA: constify netdev->dev_addr accesses Jakub Kicinski
2021-10-21 9:51 ` Leon Romanovsky
2021-10-21 11:48 ` Dennis Dalessandro
2021-10-25 17:36 ` [PATCH rdma-next 0/3] rdma: prepare for const netdev->dev_addr Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXFt2/mx30fmDoj2@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.