From: Adam Borowski <kilobyte@angband.pl>
To: Christoph Hellwig <hch@lst.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>, Jens Axboe <axboe@kernel.dk>,
Yi Zhang <yi.zhang@redhat.com>,
linux-block@vger.kernel.org, nvdimm@lists.linux.dev,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] memremap: remove support for external pgmap refcounts
Date: Thu, 21 Oct 2021 15:40:17 +0200 [thread overview]
Message-ID: <YXFtwcAC0WyxIWIC@angband.pl> (raw)
In-Reply-To: <20211019073641.2323410-3-hch@lst.de>
On Tue, Oct 19, 2021 at 09:36:41AM +0200, Christoph Hellwig wrote:
> No driver is left using the external pgmap refcount, so remove the
> code to support it.
> --- a/include/linux/memremap.h
> +++ b/include/linux/memremap.h
> @@ -109,8 +98,7 @@ struct dev_pagemap_ops {
> */
> struct dev_pagemap {
> struct vmem_altmap altmap;
> - struct percpu_ref *ref;
> - struct percpu_ref internal_ref;
> + struct percpu_ref ref;
> struct completion done;
> enum memory_type type;
> unsigned int flags;
This breaks at least drivers/pci/p2pdma.c:222
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ Certified airhead; got the CT scan to prove that!
⠈⠳⣄⠀⠀⠀⠀
next prev parent reply other threads:[~2021-10-21 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 7:36 fix a pmem regression due to drain the block queue in del_gendisk Christoph Hellwig
2021-10-19 7:36 ` [PATCH 1/2] nvdimm/pmem: stop using q_usage_count as external pgmap refcount Christoph Hellwig
2021-10-19 7:36 ` [PATCH 2/2] memremap: remove support for external pgmap refcounts Christoph Hellwig
2021-10-21 13:40 ` Adam Borowski [this message]
2021-10-22 5:55 ` Christoph Hellwig
2021-10-22 8:52 ` Adam Borowski
2021-10-22 15:43 ` Dan Williams
2021-10-26 1:42 ` Dan Williams
2021-10-26 5:53 ` Christoph Hellwig
2021-10-26 17:34 ` Dan Williams
2021-11-06 5:35 ` kernel test robot
2021-11-06 5:35 ` kernel test robot
2021-11-14 0:13 ` kernel test robot
2021-10-20 6:38 ` fix a pmem regression due to drain the block queue in del_gendisk Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXFtwcAC0WyxIWIC@angband.pl \
--to=kilobyte@angband.pl \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.