From: Mark Brown <broonie@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: alsa-devel@alsa-project.org,
David Rhodes <david.rhodes@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
kernel@pengutronix.de, James Schulman <james.schulman@cirrus.com>
Subject: Re: [PATCH] ASoC: cs42l51: improve error handling in cs42l51_remove()
Date: Thu, 21 Oct 2021 19:38:08 +0100 [thread overview]
Message-ID: <YXGzkNEUpil9lsdh@sirena.org.uk> (raw)
In-Reply-To: <20211021103627.70975-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Thu, Oct 21, 2021 at 12:36:27PM +0200, Uwe Kleine-König wrote:
> a bit unsure if regulator_bulk_force_disable() is indeed the right
> function here, its documentation specifies a different usecase.
> My motivation for this change was to make it obvious in
> cs42l51_i2c_remove() that there is no error to handle to eventually make
> i2c remove callbacks return void, too.
It would be better to just ignore the errors on disable. Realistically
you'd have to really be trying to trigger an error here and it's most
likely that the system is in enough trouble if one is triggered that
it's just not worrying about. I'm not sure how likely it is that anyone
would ever remove one of these devices in production though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-21 18:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 10:36 [PATCH] ASoC: cs42l51: improve error handling in cs42l51_remove() Uwe Kleine-König
2021-10-21 18:38 ` Mark Brown [this message]
2021-10-21 20:58 ` Uwe Kleine-König
2021-10-21 21:31 ` Mark Brown
2021-10-22 7:12 ` Uwe Kleine-König
2021-10-22 12:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXGzkNEUpil9lsdh@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.