From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 341BEC433EF for ; Fri, 22 Oct 2021 09:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D3FD610CF for ; Fri, 22 Oct 2021 09:08:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232282AbhJVJLB (ORCPT ); Fri, 22 Oct 2021 05:11:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:41776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232203AbhJVJLA (ORCPT ); Fri, 22 Oct 2021 05:11:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 42CFF60F12; Fri, 22 Oct 2021 09:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634893723; bh=zsP3z2McQlmTD60dB3Z+iafB+Ib7BOmZMfoEKTSrah0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cjpHZuCwKCmNSXFjSqIFDjAZWsbAvE5JoGJhniJ1AYxw6VXBSS5L207al3NwMCBAs yQGo5L5EAqfLqXdtQaJm6YD/9ub+eqkz6q4zZUQTPXnmtNWCciQgnnvfHofLaLy9KQ vf5xzzgalwAAAHaR1fBDIcbD7EXHkHKZtwZF5ESc= Date: Fri, 22 Oct 2021 11:08:41 +0200 From: Greg Kroah-Hartman To: Sergey Shtylyov Cc: linux-usb@vger.kernel.org, Alan Stern , Sergey Shtylyov Subject: Re: [PATCH 07/10] usb: host: ohci-da8xx: fix deferred probing Message-ID: References: <20211021191437.8737-1-s.shtylyov@omp.ru> <20211021191437.8737-8-s.shtylyov@omp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Oct 21, 2021 at 10:17:43PM +0300, Sergey Shtylyov wrote: > On 10/21/21 10:14 PM, Sergey Shtylyov wrote: > > > From: Sergey Shtylyov > > Oops, should have been @omp.ru -- missed it somehow... :-? > > > The driver overrides the error codes returned by platform_get_irq() to > > -ENODEV for some strange reason, so if it returns -EPROBE_DEFER, the driver > > will fail the probe permanently instead of the deferred probing. Switch to > > propagating the error codes upstream. > > > > Fixes: efe7daf2231a ("USB: OHCI: DA8xx/OMAP-L1x glue layer") > > Signed-off-by: Sergey Shtylyov > > Hm, this needs fixing too... > > > Signed-off-by: Sergey Shtylyov > [...] Please fix up and add Alan's acks and send a v2 of this series. thanks, greg k-h