Re: [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART

[Lee Jones <lee.jones@linaro.org>]

On Fri, 22 Oct 2021, Aditya Garg wrote:

> 
> From 76d8253d90233b2c2d3fbc82355c603bf0eb9964 Mon Sep 17 00:00:00 2001
> From: Orlando Chamberlain <redecorating@protonmail.com>
> Date: Fri, 1 Oct 2021 13:30:19 +0530
> Subject: [PATCH] Add support for MacBookPro16,2 UART
> Cc: stable@vger.kernel.org

What is this?

These headers should not be part of the patch.

How are you submitting this?
What tools are you using?
Did you read the documents I sent you (see below)?

> Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake PCH-N UART controller present on the MacBookPro16,2.

This line is too long.

> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
>  drivers/mfd/intel-lpss-pci.c | 2 ++
>  1 file changed, 2 insertions(+)

This diff looks better.

> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index c54d19fb1..33d5043fd 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
>  	{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
>  	{ PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
>  	{ PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
> +	/* ICL-N*/
> +	{ PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
>  	/* TGL-H */
>  	{ PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
>  	{ PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
> 
> > On 21-Oct-2021, at 4:45 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > 
> > On Thu, 14 Oct 2021, andriy.shevchenko@linux.intel.com wrote:
> > 
> >> On Thu, Oct 14, 2021 at 04:15:05AM +0000, Aditya Garg wrote:
> >> 
> >> Entire message looks like a mess. Are you sure you are using proper tools
> >> for sending it?
> > 
> > Agreed.
> > 
> > I can't apply this until it's submitted properly.
> > 
> > - Please read Documentation/process/submitting-patches.rst
> > - Please read Documentation/process/coding-style.rst
> > 
> > If you have any questions, please reach out.  We're happy to help.
> > 

This quoted text can't be part of a submitted patch.

Please submit the patch on its own, as a new thread, using the correct
tooling (provided mostly by the Git package (i.e. `git format-patch`
and `git send-email`).

If you're stuck, or there is something you do not understand, please
ask.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog