From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5873BC433EF for ; Fri, 22 Oct 2021 19:13:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BEA961073 for ; Fri, 22 Oct 2021 19:13:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1BEA961073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D8D66EDA1; Fri, 22 Oct 2021 19:13:04 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8CF536EDA1 for ; Fri, 22 Oct 2021 19:13:02 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10145"; a="292831800" X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="292831800" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 12:13:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="495799065" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga008.jf.intel.com with SMTP; 22 Oct 2021 12:12:58 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 22 Oct 2021 22:12:57 +0300 Date: Fri, 22 Oct 2021 22:12:57 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann , Peter Robinson , Neal Gompa , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , dri-devel@lists.freedesktop.org Subject: Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal Message-ID: References: <20211022144040.3418284-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211022144040.3418284-1-javierm@redhat.com> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Oct 22, 2021 at 04:40:40PM +0200, Javier Martinez Canillas wrote: > The simpledrm driver allows to use the frame buffer that was set-up by the > firmware. This gives early video output before the platform DRM driver is > probed and takes over. > > But it would be useful to have a way to disable this take over by the real > DRM drivers. For example, there may be bugs in the DRM drivers that could > cause the display output to not work correctly. > > For those cases, it would be good to keep the simpledrm driver instead and > at least get a working display as set-up by the firmware. > > Let's add a drm.remove_fb boolean kernel command line parameter, that when > set to false will prevent the conflicting framebuffers to being removed. > > Since the drivers call drm_aperture_remove_conflicting_framebuffers() very > early in their probe callback, this will cause the drivers' probe to fail. Why is that better than just modprobe.blacklisting those drivers? -- Ville Syrjälä Intel