From: Andrew Lunn <andrew@lunn.ch>
To: Yuiko Oshino <yuiko.oshino@microchip.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
nisar.sayed@microchip.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next] net: phy: microchip_t1: add cable test support for lan87xx phy
Date: Fri, 22 Oct 2021 21:48:06 +0200 [thread overview]
Message-ID: <YXMVdkXIenVuD3gV@lunn.ch> (raw)
In-Reply-To: <20211022183632.8415-1-yuiko.oshino@microchip.com>
> +/* MISC Control 1 Register */
> +#define LAN87XX_CTRL_1 (0x11)
> +#define LAN87XX_MASK_RGMII_TXC_DLY_EN (0x4000)
> +#define LAN87XX_MASK_RGMII_RXC_DLY_EN (0x2000)
Interesting to know, but not used in this patch.
Please can you write a patch to actually make use of these bits, and
do the right thing when phydev->interface is one of the four
PHY_INTERFACE_MODE_RGMII values.
Andrew
next prev parent reply other threads:[~2021-10-22 19:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 18:36 [PATCH net-next] net: phy: microchip_t1: add cable test support for lan87xx phy Yuiko Oshino
2021-10-22 19:48 ` Andrew Lunn [this message]
2021-10-27 14:21 ` Yuiko.Oshino
2021-10-22 19:56 ` Andrew Lunn
2021-10-27 14:30 ` Yuiko.Oshino
2021-10-27 14:46 ` Andrew Lunn
2021-10-27 14:54 ` Yuiko.Oshino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXMVdkXIenVuD3gV@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nisar.sayed@microchip.com \
--cc=yuiko.oshino@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.